Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <ba0b674f-32c5-4ded-a8aa-7d1f3d396b73@intel.com>
Date:   Thu, 26 Oct 2023 16:22:17 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v2 4/5] net: phy: broadcom: Add support for
 WAKE_FILTER
Content-Language: en-US
To:     Florian Fainelli <florian.fainelli@broadcom.com>,
        <netdev@vger.kernel.org>
CC:     Doug Berger <opendmb@gmail.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        "Tariq Toukan" <tariqt@nvidia.com>, Gal Pressman <gal@nvidia.com>,
        Willem de Bruijn <willemb@google.com>,
        Daniil Tatianin <d-tatianin@yandex-team.ru>,
        "Simon Horman" <horms@kernel.org>,
        Justin Chen <justin.chen@broadcom.com>,
        "Ratheesh Kannoth" <rkannoth@marvell.com>,
        Joe Damato <jdamato@fastly.com>,
        "Vincent Mailhol" <mailhol.vincent@wanadoo.fr>,
        Jiri Pirko <jiri@resnulli.us>,
        "open list" <linux-kernel@vger.kernel.org>
References: <20231026224509.112353-1-florian.fainelli@broadcom.com>
 <20231026224509.112353-5-florian.fainelli@broadcom.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231026224509.112353-5-florian.fainelli@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VEkweHBxVm5teGVNb3ZqV2lsb3hiZitCSEZrczJRNkNnTHRZeWJkNzEwcHc1?=
 =?utf-8?B?T3hYV2pGSHE4K0RQUGlwajZLdFUvVzVVcW1Jb05FQlR6SG9rN1k1QU1OdlI2?=
 =?utf-8?B?S1NMRXF0Y2g3NXAyVmplQ1FwVHFmZlMwb2hmU25TbkhnWCtZcFI2d29SY0Ju?=
 =?utf-8?B?MkdSQlhpVUI5TEZySHhqWjhUdHUwMHRiK3liWktubUdDb09LN0ZVUUsrTTZ4?=
 =?utf-8?B?TGpFM3ptT20vNUd6YlJHZ0szUk9vcmNlNGhFUUZ2UitzRUtUM25hYjdZeUtS?=
 =?utf-8?B?K24xek9QSFRBVUtwaVltUERnbDJLZWZucVRtL2dkYXJUYzNIanZYODFsSklR?=
 =?utf-8?B?Z1hVbXZLdEFCdjJ0M1pldCtobmoreEtHRWVqcHIxc0tBeW1LOTljbUNCVXl1?=
 =?utf-8?B?VjJjdGhRa0ZRMytFbURBYi9KNnhpS0ZnOXNuUERHdjF3Q09zZzhkdUNRZFNB?=
 =?utf-8?B?c3RLbGRtTEpoS29zYkhQVlZ1am5FdXdUcVhkT09aQm02QUZhRm0wK2F2QkEv?=
 =?utf-8?B?VHZvQnNTc29xRzV2TXJ2WkpPK1QvT0RXMUdQYXBNQ0NxaXNnQlNMYjBhb0cv?=
 =?utf-8?B?OVpuNU5pbXEyV2o1NjJLMStVanhwZHNYcWVEZ1ZoZ2xqNzJ5MEZGQXZFMXh5?=
 =?utf-8?B?aVFEYmpEc3NqdFNsUFpZODV6L2dmNExHY2d2aHp0eHg2ZGRZRTAvNEJQZEt3?=
 =?utf-8?B?dFV5cElkU1hPbXpEREZ6L3ZQaGdrWUdOU0x5ODl6UktXLzJ1VjNHRStwRjZi?=
 =?utf-8?B?TDRNQis3R3IwY3hodjV6VXZVVzV1THdOTkZlczdvVWhXOTg4Z3hnaG01R2cw?=
 =?utf-8?B?azhWb2xjdXQyZWx5SlIwQmMvbjVEZUxJdFFhdTkrTVp2ckZLSzlBZU14U1or?=
 =?utf-8?B?R3NTaFhiR3JaVWRvdVJMcmtaR3lhK2lLSjNnNGVaU1FCVjZqeEp6K0ZaczBY?=
 =?utf-8?B?T3RRWHpjbVpyZERvMXo3N2F1M04xa2l5Z21heUxtTjVXakVqYUVBWWFFV0pz?=
 =?utf-8?B?OFVjdDhDZ3hwRnFudjNKNHArNGtuZXA3YzY0cTczKzV4MGhORDh5ZElnTUgz?=
 =?utf-8?B?ZnE3UXVxVENxSVlKMzJyd2taZDNyZ1hNeDBlaTJqUXR1OU5kSG1CalBNRXN5?=
 =?utf-8?B?d3hPUlJSU2RENlU0cThmY0FOOU50L1hzeTRXOU5iVzg5VVZ5Wkh6WG1tc2xN?=
 =?utf-8?B?ZGlTazlWQnZwOUsyTmU0Sk1wYm1PaWtxd2NRUnpCR2R0dTBZVU5VOTRHNE5E?=
 =?utf-8?B?eG43TzEyODFoY3FmVW1BNFFoWDYzS01oNmJLcnhVbWg0VFh4bHR2ak41V0pT?=
 =?utf-8?B?bzQ2WnU3SlloQlpRL1VYRThuUGR6STRSQmQydzNndkJUMHowbWgvdkY5SXNn?=
 =?utf-8?B?emF4SWd5Vzl4aWVNWXIvMWY2eko4bXRKTVZLeXJSVFppRlRRTmhUNWdndU1i?=
 =?utf-8?B?TWFkQ253ejUrWEFSNHVNc1BUa0JIcTJOd25KMkhscGo4S0RrKzlybnl5QjFZ?=
 =?utf-8?B?dEd6THdyWko1M1hwQVhlUno1cWQ1REJKV1k4SUtHVHBiUkNmbUhGMjY3Y2Yx?=
 =?utf-8?B?WFlxakVXL3dLRDVMWHJKdWV4UDlTZVVYUzIyZzR6N2R2ejBSOTBOMDl1RGds?=
 =?utf-8?B?dnZWcGlxTHhvSDM4Nkl1TTdxZXFtcHZvVjdRN25BbkdNczNJVDF3eGZKY3hW?=
 =?utf-8?B?RnFVczRtUnlRUWozOC8wcWxQWEtPUGNCbFJTaXp0Y1B0K1V1aGVvcTdPcngv?=
 =?utf-8?B?MHphaXdJMUFNa1RrVDFlUzM1QVBFellxVjRLS25Bd0pVNDFPQ2lLelVaNHg5?=
 =?utf-8?B?MGZHaWFtM2VlMU1aenlqK1ZaRXVUWEdWU1M4MnJqaTV4WUZMKythMVBpOThS?=
 =?utf-8?B?aFV4cHk3aGdyUm1RK05iT1EwQXk5Y20wY05kcXVrSGx1UE9PeCtQL0h2NTZs?=
 =?utf-8?B?VlZoZ1kyZFdrUkRtRjE5NVp6Z1B4a1ZNdWlCbjZvbEdXTmlsMVBKc2haTTRj?=
 =?utf-8?B?VXVrb0cyWWg2YW5kSjROWlBzRWJldkc2cFZXVWhzQjh0dERKNXRrTjBMQ2Jy?=
 =?utf-8?B?cVBSMC9qRmthaGRPNDBwak5aMTE4Nk96dFVGdk1GMHQyY1d2emZ5QmVJa0VK?=
 =?utf-8?B?WndQNGFEWjlJVkpmUnplZmxDWm1TWGFta1ErOG16cmN2Ym9DVDE0alFCV0t0?=
 =?utf-8?B?aHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e3716e48-8f69-4f23-91ec-08dbd67a65af
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 23:22:18.4284
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zeBNmwF+DFC6RX1ly2xpH9dj9rcK0E9qF9QcaN7lY8xAzBUBCSCUHCUAGetBx87w8HuO4xXedvMfvL3K+N2dMHQw3nspd7q8C5MvodZckzo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7385
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 26 Oct 2023 16:22:37 -0700 (PDT)


On 10/26/2023 3:45 PM, Florian Fainelli wrote:
> Since the PHY is capable of matching any arbitrary Ethernet MAC
> destination as a programmable wake-up pattern, add support for doing
> that using the WAKE_FILTER and ethtool::rxnfc API. For instance, in
> order to wake-up from the Ethernet MAC address corresponding to the IPv4
> multicast IP address of 224.0.0.251 (e.g.: multicast DNS), one could do:
> 
>   ethtool -N eth0 flow-type ether dst 01:00:5e:00:00:fb loc 0 action -2
>   ethtool -n eth0
>   Total 1 rules
> 
>   Filter: 0
>           Flow Type: Raw Ethernet
>           Src MAC addr: 00:00:00:00:00:00 mask: FF:FF:FF:FF:FF:FF
>           Dest MAC addr: 01:00:5E:00:00:FB mask: 00:00:00:00:00:00
>           Ethertype: 0x0 mask: 0xFFFF
>           Action: Wake-on-LAN
>   ethtool -s eth0 wol f
> 
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>