Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <0a164b9b-4f9b-4886-b19e-48298cdcff8d@intel.com>
Date:   Thu, 26 Oct 2023 16:23:44 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v2 5/5] net: bcmgenet: Interrogate PHY for
 WAKE_FILTER programming
Content-Language: en-US
To:     Florian Fainelli <florian.fainelli@broadcom.com>,
        <netdev@vger.kernel.org>
CC:     Doug Berger <opendmb@gmail.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        "Tariq Toukan" <tariqt@nvidia.com>, Gal Pressman <gal@nvidia.com>,
        Willem de Bruijn <willemb@google.com>,
        Daniil Tatianin <d-tatianin@yandex-team.ru>,
        "Simon Horman" <horms@kernel.org>,
        Justin Chen <justin.chen@broadcom.com>,
        "Ratheesh Kannoth" <rkannoth@marvell.com>,
        Joe Damato <jdamato@fastly.com>,
        "Vincent Mailhol" <mailhol.vincent@wanadoo.fr>,
        Jiri Pirko <jiri@resnulli.us>,
        "open list" <linux-kernel@vger.kernel.org>
References: <20231026224509.112353-1-florian.fainelli@broadcom.com>
 <20231026224509.112353-6-florian.fainelli@broadcom.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231026224509.112353-6-florian.fainelli@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDRvVWlhd0VMN3hkQVV0YkUyZmUwMUxreDZwS2RReWUwWFkzeGthQytUSGdN?=
 =?utf-8?B?TzAzMVRHZGlWcVQ2WSsxT0JIZEVReEJkdVJUVmhTeVg5aCtFRUxmUmc3a0JF?=
 =?utf-8?B?NlVQVnVjS0NxMkt1MHpsTWlBTm9uV1ZuR0VuVnppdGIyaWpxRy8zUk9IdVZx?=
 =?utf-8?B?ZlBWOHNsOE05aUVla3loTFdNdE9nOWlqWFRmL1BtWEFJaTJPRnhZU3VDbUxL?=
 =?utf-8?B?Q2ZjbHBlOVNGUW1YdExpTGJJOXQzUU1JNHlZemVQMDF6K1NPOHhnUGxJWkFv?=
 =?utf-8?B?cW5MZVM4VnhtZGlXU3F6RFo3TFdYaWQzZnBQZDZKVGp3VjduM2k0UTM2NEIy?=
 =?utf-8?B?ZnFMSFl0clRnMEhTMjI4cWdYekJwQk95S2hjMkN1blFIU2w5d0FhN1FtMGFn?=
 =?utf-8?B?djRKSXVMMWRiUTA2bWg1ZXh1NmlMcE0xcTFTVExmbjFKbENUdEVXdE5tZFJy?=
 =?utf-8?B?ZElZYmxCRzExczZKK1JpQnhvM2dWQm03SFFlQ0hjMWJiYlhwRDVFY043NEhi?=
 =?utf-8?B?bjNRbHh5NnNZUlpFaGt2RngzdnZFYk8xSzFwMnVjdS9Sc2xBd3pRbUVsZlk2?=
 =?utf-8?B?c3ExSm1ZUFVYN3U4bzQ5bWZGMThyME5zUU1SWkhaUXpNcGpIcUZEZW9ZbmxT?=
 =?utf-8?B?eE1UUmVFa1pWZ1FmcEpWc3p6YzdaK1NWcTBmZi9HSHY3REVJYmRqcDZWNjNG?=
 =?utf-8?B?YTl1UE0xTFczQy9CTFdvaVZ4MmU3TXJLVnFrYlpLT0FDcnVqeHo1K3pKL0Iv?=
 =?utf-8?B?RVloR1c0TkpuTFErdWNXM2x3QktNY052eG5GK2JmS2d3RjU3cWFCS2hVUmxp?=
 =?utf-8?B?MUJ3STBoL2QyYVF5Q3hZL2JOVVFoWkpvbG9LRDhESEl6b001T0lOSFRlL2ZF?=
 =?utf-8?B?eURNV1NmRW15L3NuK0RqeGZ3dm5EVWJ0bENNc0xqbmplNkhsS0dwTnRvNGtr?=
 =?utf-8?B?dytUK1poU3EvNGdUTzEyaGpNeWZJMGFqZnJnaDV0VFBSREcrTzBRdzlPVGNH?=
 =?utf-8?B?TXNqL3l4UnB5dFZGOFl0T2xzQ0tmdGt0anY2azYvN0YzOG5qSGx6UW0yUG81?=
 =?utf-8?B?OVp3d0xNYmZhQ3dLMUVZaUJyUElwMy9sVzNLQnNzSG45cW1qb2piTWJaR2pQ?=
 =?utf-8?B?d2phYW8vcmxIbWY0SURHQy9wOGlFeEUxNysrbE1xK3NyOFBpdDNydlI3d3ho?=
 =?utf-8?B?NmhUekh2ckxkV3plVURkVk1uazhuUFk0WXRYSHVXZ1FvUXVSVXFpckJmZTk0?=
 =?utf-8?B?QThiZmJOaUNnTG5VeFFOTTk5ejMxTUtuMkxQRTdWWWphclRUMk42cWRkWSti?=
 =?utf-8?B?cHlnakxzZjNOSXNkd2JXbXpzZENGU09ZQXRwRFBHYklDNC82cGZYTHhIKzlm?=
 =?utf-8?B?bE9rOGh6YmQyYU5OeGVqK0xwdkhmOUViU0JPUEt1MkxMNXJCT0dQWTFSNzZB?=
 =?utf-8?B?MWhJRjh4bitvN3VCMjJxdFdoRDJON1FPYzV0WmZ1aDBPcFpnU3k4ZkJFekFz?=
 =?utf-8?B?djlWb1lLb0dJZ0ozclBwQzJkTXByRnp4cXRPbkd6MURJdjRrQ1pSQmczdXRl?=
 =?utf-8?B?ZFI3WmxxajBHSmxnRERIWFR2c1EycExTVTIrc3RGMldnSURxMFFkdzVPZytj?=
 =?utf-8?B?TGgyVVArMFVmN1labXFiRllZc2tmbXlkUWtyYVJhUy8vcURKakJvbE1VT1RB?=
 =?utf-8?B?SDBRNTdjQkhjaC9VOFNVUmxyMjE5Z0JmYXg1dDJXYmo4NENKQWdybFBvQ0JQ?=
 =?utf-8?B?WGRPblhpZkhTZFJzR0Z3RHI0TlFhTEJxMXNqRWZ4UjVwdmZRU2d5N3NQd2x3?=
 =?utf-8?B?MExqamlwZ3BIRVBQOVErR2VLNG5aQ2YvdFJoMTdhckQzcGJWZFhvR0hOMkhQ?=
 =?utf-8?B?STJRM0F2Q2ZvUmc0aGJNUElQbXd3aEluUjM1OFl0UFN6VHFuQjluYk1DeUQz?=
 =?utf-8?B?QXpFMnBWUW5vZlNrc3AyL1VXMDhqNlNPcmpPR29SaUdCR2xzREk2L2dBcDBm?=
 =?utf-8?B?QnBvMFo5dy9qYk5FR3FDMGhsS1laaXQ5UW1ZWkxQaTJZelgrbzJwd0owd0hB?=
 =?utf-8?B?cHBHcTBYNjJKR3Z6UVhHczNXWVFDQkdmSnZiUnJ4WnkrcC9aMWQ0SDU4a3cy?=
 =?utf-8?B?cnhyWlpEcWtmN2lmZTRreDBXV0l3OGZLWnZacExiSFdmZW5uQVIyWUg2Und5?=
 =?utf-8?B?TXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 14a0bc4c-dabf-4f58-5005-08dbd67a9971
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 23:23:45.2643
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8XFGXqpb4YY93lcoyGEoby5ZE8KCfrm8JsbUdOgtTlint+tNRR+LFZobUsOptUJzo4rifZdZJDa/+SBjcP2cjzGuMmiYTwc62cAS05+gsUE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5463
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 26 Oct 2023 16:24:02 -0700 (PDT)


On 10/26/2023 3:45 PM, Florian Fainelli wrote:
> Determine whether the PHY can support waking up from the user programmed
> network filter, and if it can utilize it.
> 

Here, you're passing through to phy_ethtool_set_rxnfc, basically
allowing the lower device to program the wakeup filter if its supported. Ok.

This almost feels like it would belong generally in the higher level
ethtool code rather than in the driver?

Thanks,
Jake