Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <006e6dc4-1b5d-f46c-b03f-c60576dcf620@marcan.st>
Date:   Fri, 27 Oct 2023 08:55:54 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] regmap: Ensure range selector registers are updated after
 cache sync
To:     Mark Brown <broonie@kernel.org>, linux-kernel@vger.kernel.org
Cc:     stable@vger.kernel.org
References: <20231026-regmap-fix-selector-sync-v1-1-633ded82770d@kernel.org>
 <66c2f5d4-23de-4faf-a816-919516927f94@sirena.org.uk>
Content-Language: en-US
From:   Hector Martin <marcan@marcan.st>
In-Reply-To: <66c2f5d4-23de-4faf-a816-919516927f94@sirena.org.uk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 27/10/2023 01.22, Mark Brown wrote:
> On Thu, Oct 26, 2023 at 04:49:19PM +0100, Mark Brown wrote:
>> When we sync the register cache we do so with the cache bypassed in order
>> to avoid overhead from writing the synced values back into the cache. If
>> the regmap has ranges and the selector register for those ranges is in a
>> register which is cached this has the unfortunate side effect of meaning
>> that the physical and cached copies of the selector register can be out of
>> sync after a cache sync. The cache will have whatever the selector was when
>> the sync started and the hardware will have the selector for the register
>> that was synced last.
> 
> Given the nearness to the release I've dropped this into my CI and am
> intending to just apply it as soon as that's done in the hopes that it
> hits tomorrow's -next and gets a bit more coverage, it would be great if
> you could confirm if this fixes the systems where you saw the original
> issue.

Can confirm, this fixes the sleep borking issue on my end after
reverting my workaround.

Tested-by: Hector Martin <marcan@marcan.st>

- Hector