Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
From:   "Zhang, Tina" <tina.zhang@intel.com>
To:     Jason Gunthorpe <jgg@ziepe.ca>, Joerg Roedel <joro@8bytes.org>
CC:     "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "David Woodhouse" <dwmw2@infradead.org>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        "Will Deacon" <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        "Tian, Kevin" <kevin.tian@intel.com>,
        Nicolin Chen <nicolinc@nvidia.com>,
        Michael Shavit <mshavit@google.com>,
        Vasant Hegde <vasant.hegde@amd.com>
Subject: RE: [PATCH v9 0/5] Share sva domains with all devices bound to a mm
Thread-Topic: [PATCH v9 0/5] Share sva domains with all devices bound to a mm
Thread-Index: AQHaAYDvo1dMRebqg0WIkJITnmWIJbBbt/QAgABSlwCAABlYAIAArDCg
Date:   Fri, 27 Oct 2023 00:10:20 +0000
Message-ID: <MW5PR11MB58811AD51C945F94F7BCD0AE89DCA@MW5PR11MB5881.namprd11.prod.outlook.com>
References: <20231018050640.24936-1-tina.zhang@intel.com>
 <ZToUOKSqqI6Bh_03@8bytes.org> <20231026122016.GU691768@ziepe.ca>
 <20231026135058.GW691768@ziepe.ca>
In-Reply-To: <20231026135058.GW691768@ziepe.ca>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7yhIi5oUkfy1f8sgpiHJsdaqFErOuypm2z+En9It2Aky/qfVIAeZQma/LUIM?=
 =?us-ascii?Q?22IYfXb+upFFTTj60IgbDkjfMPl/ISW4pgIt4sKTTcjtc+d+CHWenZh96Ugl?=
 =?us-ascii?Q?mYY9ozU5eSmLaCoDb+hjOCufPfpBXVf4MUzyUjY/aUKL27LCkpIQ4VnZyfaA?=
 =?us-ascii?Q?nVory5hEVPTcDBbt5UT8B3fiKWYbs5vd4RO6hyv2hCa4k/o/c9nsk8Deq9PZ?=
 =?us-ascii?Q?GrIh5XDjlskxtetU5Zspgj22++Qgriz10aP2Q0ay9KfWjPNRVQlQfe3vGWc/?=
 =?us-ascii?Q?JkJHfs8mcgppipwRQSG9sqv7zHWZkorgajYWfGpYaKpz7Qdrzwkox2zgRJPH?=
 =?us-ascii?Q?HufTs/lJHaKVg9MYp6gyaArL8eBUJVjOHUzLEUZhXGGZ2uFXKf1oMWxNtgfR?=
 =?us-ascii?Q?V+fqZV5V7lVfz3TB0C5B9oFzD5o1D4LA6/VbOIBRFXjAS7hjvnGxgbt78wE3?=
 =?us-ascii?Q?N8pfzIWSc8PlnJfnj53SkVSej4D3FIxt28Qqfu8OQZju7NU+PQ3d9tRw0Ztq?=
 =?us-ascii?Q?LvmAs4lHG8taPKxfYt8Vmc3g0SWDzyg1dHccRCzUhq0ibIVAMnWFmixQ1y5o?=
 =?us-ascii?Q?0v/R3zTDHxDLKxiEKR+xNhW/rErwaUaue9/Z35zv7UBScXoB6os66xIbkGZl?=
 =?us-ascii?Q?AZFQ9LIpbtQGExtczyV7QPaT+aeMtnbvu/kPPIhPnxB3hvbnCg6pSwx1WHKn?=
 =?us-ascii?Q?+FqXb/FCLy6PhaARtso8ZB0N0DjM5VofOznUK6OC/xtEad0DBQdEhtaPgDMj?=
 =?us-ascii?Q?JD08IGHy4LMwvsHIJY1n7HEj1K6niRh5DoUOyHZbwHMv7FJm0bFoYeqF1pUJ?=
 =?us-ascii?Q?QuU1Q2O6fHn4OpaOMW/jAS4Bw9xU/eHaKyKcizYD2Yh6WRZNpP7Rsk2h0F2E?=
 =?us-ascii?Q?EgwhyvIo24W7hkxL+bmaWQtXL96LRBm4Ks6vyrFOCuJ+AZUwUbJIUf/XVX70?=
 =?us-ascii?Q?RCbnqlI0svA405J2utqH3SCHu9FuQNLjswnNMueZy5BBA8Z/6AcDyhjAZbbM?=
 =?us-ascii?Q?eCexxSh51PIv7GrR07IvefC4rjLRr4EMaMTBGHJBl6++QGgCFYYJYqNNSf/x?=
 =?us-ascii?Q?kMd3VS/kuw9jdNtCBmJTB0oli5D/DYJHAI3nH3upZ73p2ZfScSLRKQR64gmZ?=
 =?us-ascii?Q?sv6Zxw/lEIpVKf7KCQAo/D+zz+HjK2JwFLt1mm/Zzsf0tfFsYZ9vXhouQffk?=
 =?us-ascii?Q?NQvOUoVZ5BaNJmzQJluG+TEkS7sJpNvyEjpJeQWsS2jrRlITKf3pn9/CJG1e?=
 =?us-ascii?Q?l2H9bsGixKuk05S1OTa3udQgs176IeiBzDPLkAj7cSpEHRxtG69BOk+kVjgV?=
 =?us-ascii?Q?/fQj7xY6QOcm+d5jAWQAxhearjBbCTpuAMYev5LrvAGfVG6u4cutSpHFvmC6?=
 =?us-ascii?Q?8fmo4yy+fHFxK3l6ym1ZPLtzmOmFzWPBI9mrI0JGHnsw+W2urxVgALcFWiJP?=
 =?us-ascii?Q?7h4592na4k1gy8gYtBEe0CJGlqR+VtITYrgZI38UUC66y+Xygz3lR0BJNg/F?=
 =?us-ascii?Q?H76kp37mW1Uxeh6ttmzj3kiYLsKAJWJtAqeGtaESlkhEK+kW9jDRIqA576Jc?=
 =?us-ascii?Q?8LEQygiR5kLvaINxTDGpkVdWTns/LRJHn6mtxswn?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5881.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f5687aaa-2535-4fb6-8565-08dbd6811b9f
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2023 00:10:20.5157
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hPgE9HlGAG9uqx1TBG0w5u6Ytra5yZeU1dCX1NVV/FlX3QurmldzD2sg7S9NwDZLZ523djpfUii0QPycUwmNwg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4927
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 26 Oct 2023 17:10:39 -0700 (PDT)

Hi Jason and Joerg,

Thanks for this commit. Version 10 of this patch-set has been submitted and=
 this patch is added.

Regards,
-Tina

> -----Original Message-----
> From: Jason Gunthorpe <jgg@ziepe.ca>
> Sent: Thursday, October 26, 2023 9:51 PM
> To: Joerg Roedel <joro@8bytes.org>
> Cc: Zhang, Tina <tina.zhang@intel.com>; iommu@lists.linux.dev; linux-
> kernel@vger.kernel.org; David Woodhouse <dwmw2@infradead.org>; Lu Baolu
> <baolu.lu@linux.intel.com>; Will Deacon <will@kernel.org>; Robin Murphy
> <robin.murphy@arm.com>; Tian, Kevin <kevin.tian@intel.com>; Nicolin Chen
> <nicolinc@nvidia.com>; Michael Shavit <mshavit@google.com>; Vasant Hegde
> <vasant.hegde@amd.com>
> Subject: Re: [PATCH v9 0/5] Share sva domains with all devices bound to a=
 mm
>=20
> On Thu, Oct 26, 2023 at 09:20:16AM -0300, Jason Gunthorpe wrote:
> > On Thu, Oct 26, 2023 at 09:24:40AM +0200, Joerg Roedel wrote:
> > > Hi Tina,
> > >
> > > On Wed, Oct 18, 2023 at 01:06:35PM +0800, Tina Zhang wrote:
> > > > Tina Zhang (5):
> > > >   iommu/vt-d: Remove mm->pasid in intel_sva_bind_mm()
> > > >   iommu: Add mm_get_enqcmd_pasid() helper function
> > > >   mm: Add structure to keep sva information
> > > >   iommu: Support mm PASID 1:n with sva domains
> > > >   mm: Deprecate pasid field
> > >
> > > Thanks for doing this, it all looks reasonable to me. But there is
> > > one thing missing which needs to be done before we can move forward
> > > with this.
> > >
> > > There was a discussion about the Kconfig symbol naming used in
> > > mm_struct. Please see the discussion here:
> > >
> > >
> > > https://lore.kernel.org/all/CAHk-=3DwgUiAtiszwseM1p2fCJ+sC4XWQ+YN4Tan=
F
> > > hUgvUqjr9Xw@mail.gmail.com/
> > >
> > > Please update this patch-set to solve this and I will take the series=
.
> >
> > Lets call it CONFIG_IOMMU_MM_DATA then. It is still pretty nonsensical
> > but it speaks to what it does after this series
>=20
> This is what I came up with:
>=20
> From ca97b6cb94eadc4066d762aa4c54e7ba9789f3f4 Mon Sep 17 00:00:00
> 2001
> From: Jason Gunthorpe <jgg@nvidia.com>
> Date: Thu, 26 Oct 2023 10:43:12 -0300
> Subject: [PATCH] iommu: Change kconfig around IOMMU_SVA
>=20
> Linus suggested that the kconfig here is confusing:
>=20
> https://lore.kernel.org/all/CAHk-
> =3DwgUiAtiszwseM1p2fCJ+sC4XWQ+YN4TanFhUgvUqjr9Xw@mail.gmail.com/
>=20
> Let's break it into three kconfigs controlling distinct things:
>=20
>  - CONFIG_IOMMU_MM_DATA controls if the mm_struct has the additional
>    fields for the IOMMU. Currently only PASID, but later patches store
>    a struct iommu_mm_data *
>=20
>  - CONFIG_ARCH_HAS_CPU_PASID controls if the arch needs the scheduling bi=
t
>    for keeping track of the ENQCMD instruction. x86 will select this if
>    IOMMU_SVA is enabled
>=20
>  - IOMMU_SVA controls if the IOMMU core compiles in the SVA support code
>    for iommu driver use and the IOMMU exported API
>=20
> This way ARM will not enable CONFIG_ARCH_HAS_CPU_PASID
>=20
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
>  arch/Kconfig             | 5 +++++
>  arch/x86/Kconfig         | 1 +
>  arch/x86/kernel/traps.c  | 2 +-
>  drivers/iommu/Kconfig    | 1 +
>  include/linux/iommu.h    | 2 +-
>  include/linux/mm_types.h | 2 +-
>  include/linux/sched.h    | 2 +-
>  kernel/fork.c            | 2 +-
>  mm/Kconfig               | 3 +++
>  mm/init-mm.c             | 2 +-
>  10 files changed, 16 insertions(+), 6 deletions(-)
>=20
> diff --git a/arch/Kconfig b/arch/Kconfig index
> 12d51495caec18..35b9fd559bb697 100644
> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -301,6 +301,11 @@ config ARCH_HAS_DMA_CLEAR_UNCACHED  config
> ARCH_HAS_CPU_FINALIZE_INIT
>  	bool
>=20
> +# The architecture has a per-task state that includes the mm's PASID
> +config ARCH_HAS_CPU_PASID
> +	bool
> +	select IOMMU_MM_DATA
> +
>  # Select if arch init_task must go in the __init_task_data section  conf=
ig
> ARCH_TASK_STRUCT_ON_STACK
>  	bool
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index
> 66bfabae881491..afd9c2dc228bdf 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -72,6 +72,7 @@ config X86
>  	select ARCH_HAS_CACHE_LINE_SIZE
>  	select ARCH_HAS_CPU_CACHE_INVALIDATE_MEMREGION
>  	select ARCH_HAS_CPU_FINALIZE_INIT
> +	select ARCH_HAS_CPU_PASID		if IOMMU_SVA
>  	select ARCH_HAS_CURRENT_STACK_POINTER
>  	select ARCH_HAS_DEBUG_VIRTUAL
>  	select ARCH_HAS_DEBUG_VM_PGTABLE	if !X86_PAE
> diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c index
> c876f1d36a81a7..2b62dbb3396add 100644
> --- a/arch/x86/kernel/traps.c
> +++ b/arch/x86/kernel/traps.c
> @@ -565,7 +565,7 @@ static bool fixup_iopl_exception(struct pt_regs *regs=
)
>   */
>  static bool try_fixup_enqcmd_gp(void)
>  {
> -#ifdef CONFIG_IOMMU_SVA
> +#ifdef CONFIG_ARCH_HAS_CPU_PASID
>  	u32 pasid;
>=20
>  	/*
> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig index
> 5cc869db1b79fc..0f9c3f6ae8d32d 100644
> --- a/drivers/iommu/Kconfig
> +++ b/drivers/iommu/Kconfig
> @@ -160,6 +160,7 @@ config IOMMU_DMA
>=20
>  # Shared Virtual Addressing
>  config IOMMU_SVA
> +	select IOMMU_MM_DATA
>  	bool
>=20
>  config FSL_PAMU
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h index
> 8fb1b41b4d1580..0d2e01404c3e50 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -1324,7 +1324,7 @@ static inline bool
> tegra_dev_iommu_get_stream_id(struct device *dev, u32 *stream
>  	return false;
>  }
>=20
> -#ifdef CONFIG_IOMMU_SVA
> +#ifdef CONFIG_IOMMU_MM_DATA
>  static inline void mm_pasid_init(struct mm_struct *mm)  {
>  	mm->pasid =3D IOMMU_PASID_INVALID;
> diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index
> 36c5b43999e608..330f3cd8d5ad97 100644
> --- a/include/linux/mm_types.h
> +++ b/include/linux/mm_types.h
> @@ -881,7 +881,7 @@ struct mm_struct {
>  #endif
>  		struct work_struct async_put_work;
>=20
> -#ifdef CONFIG_IOMMU_SVA
> +#ifdef CONFIG_IOMMU_MM_DATA
>  		u32 pasid;
>  #endif
>  #ifdef CONFIG_KSM
> diff --git a/include/linux/sched.h b/include/linux/sched.h index
> 77f01ac385f7a5..3ac8e8556c3d93 100644
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -949,7 +949,7 @@ struct task_struct {
>  	/* Recursion prevention for eventfd_signal() */
>  	unsigned			in_eventfd:1;
>  #endif
> -#ifdef CONFIG_IOMMU_SVA
> +#ifdef CONFIG_ARCH_HAS_CPU_PASID
>  	unsigned			pasid_activated:1;
>  #endif
>  #ifdef	CONFIG_CPU_SUP_INTEL
> diff --git a/kernel/fork.c b/kernel/fork.c index
> 3b6d20dfb9a85e..d28f0d4582dcc1 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -1179,7 +1179,7 @@ static struct task_struct *dup_task_struct(struct
> task_struct *orig, int node)
>  	tsk->use_memdelay =3D 0;
>  #endif
>=20
> -#ifdef CONFIG_IOMMU_SVA
> +#ifdef CONFIG_ARCH_HAS_CPU_PASID
>  	tsk->pasid_activated =3D 0;
>  #endif
>=20
> diff --git a/mm/Kconfig b/mm/Kconfig
> index 264a2df5ecf5b9..fee4a15e444b74 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -1258,6 +1258,9 @@ config LOCK_MM_AND_FIND_VMA
>  	bool
>  	depends on !STACK_GROWSUP
>=20
> +config IOMMU_MM_DATA
> +	bool
> +
>  source "mm/damon/Kconfig"
>=20
>  endmenu
> diff --git a/mm/init-mm.c b/mm/init-mm.c index
> cfd367822cdd2e..c52dc2740a3de2 100644
> --- a/mm/init-mm.c
> +++ b/mm/init-mm.c
> @@ -44,7 +44,7 @@ struct mm_struct init_mm =3D {  #endif
>  	.user_ns	=3D &init_user_ns,
>  	.cpu_bitmap	=3D CPU_BITS_NONE,
> -#ifdef CONFIG_IOMMU_SVA
> +#ifdef CONFIG_IOMMU_MM_DATA
>  	.pasid		=3D IOMMU_PASID_INVALID,
>  #endif
>  	INIT_MM_CONTEXT(init_mm)
> --
> 2.42.0