Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Fri, 27 Oct 2023 12:42:11 +0900
From:   asmadeus@codewreck.org
To:     Hangyu Hua <hbh25y@gmail.com>
Cc:     ericvh@kernel.org, lucho@ionkov.net, linux_oss@crudebyte.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, v9fs@lists.linux.dev, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: 9p: fix possible memory leak in p9_check_errors()
Message-ID: <ZTsxkzODZ9yve0XL@codewreck.org>
References: <20231027030302.11927-1-hbh25y@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20231027030302.11927-1-hbh25y@gmail.com>
Precedence: bulk

Hangyu Hua wrote on Fri, Oct 27, 2023 at 11:03:02AM +0800:
> When p9pdu_readf() is called with "s?d" attribute, it allocates a pointer
> that will store a string. But when p9pdu_readf() fails while handling "d"
> then this pointer will not be freed in p9_check_errors().
> 
> Fixes: 51a87c552dfd ("9p: rework client code to use new protocol support functions")
> Reviewed-by: Christian Schoenebeck <linux_oss@crudebyte.com>
> Signed-off-by: Hangyu Hua <hbh25y@gmail.com>

Thanks, pushed for next
-- 
Dominique Martinet | Asmadeus