Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757507AbXKUGXS (ORCPT ); Wed, 21 Nov 2007 01:23:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752013AbXKUGXA (ORCPT ); Wed, 21 Nov 2007 01:23:00 -0500 Received: from an-out-0708.google.com ([209.85.132.251]:58856 "EHLO an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751735AbXKUGXA (ORCPT ); Wed, 21 Nov 2007 01:23:00 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=mqEQnfoEqKXE1Qe1gwI2Z6zaLh8EwJs+RhC4WhslD7TkLQyz2RCz1cb0olA/lFifh/ttU7V5ry6A7SHOaifjFeDMOiqo7KbUtgOvjBWOzidhtiadGivWJeUoyk1vlg97MmJfcaW/049+ckkuzmTyoUNCpJpZjjr5VJmAOYAdezw= Message-ID: Date: Wed, 21 Nov 2007 14:22:59 +0800 From: "Dave Young" To: "Andrew Morton" Subject: Re: 2.6.24-rc3-mm1 Cc: linux-kernel@vger.kernel.org, "Avi Kivity" , "Thomas Gleixner" , "Ingo Molnar" In-Reply-To: <20071120221552.1f42ebfa.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20071120204525.ff27ac98.akpm@linux-foundation.org> <20071120220046.db5c8fde.akpm@linux-foundation.org> <20071120221552.1f42ebfa.akpm@linux-foundation.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1487 Lines: 50 On Nov 21, 2007 2:15 PM, Andrew Morton wrote: > > On Wed, 21 Nov 2007 14:03:34 +0800 "Dave Young" wrote: > > > On Nov 21, 2007 2:00 PM, Andrew Morton wrote: > > > > > > On Wed, 21 Nov 2007 13:51:47 +0800 "Dave Young" wrote: > > > > > > > Hi, andrew > > > > > > > > modpost failed for me: > > > > MODPOST 360 modules > > > > ERROR: "empty_zero_page" [drivers/kvm/kvm.ko] undefined! > > > > make[1]: *** [__modpost] Error 1 > > > > make: *** [modules] Error 2 > > > > > > > > > > You're a victim of the hasty unexporting fad. Which architecture? > > > x86_64 I guess? > > > > > Hi, > > ia32 instead. > > > > oic. Like this, I guess. > > --- a/arch/x86/kernel/i386_ksyms_32.c~git-x86-i386-export-empty_zero_page > +++ a/arch/x86/kernel/i386_ksyms_32.c > @@ -2,6 +2,7 @@ > #include > #include > #include > +#include > > EXPORT_SYMBOL(__down_failed); > EXPORT_SYMBOL(__down_failed_interruptible); > @@ -22,3 +23,4 @@ EXPORT_SYMBOL(__put_user_8); > EXPORT_SYMBOL(strstr); > > EXPORT_SYMBOL(csum_partial); > +EXPORT_SYMBOL(empty_zero_page); > _ > Yes, passed :) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/