Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-1048-g9229b632c5-fm-20231019.001-g9229b632
MIME-Version: 1.0
Message-Id: <b20fe713-28c6-4ca8-b64a-df017f161524@app.fastmail.com>
In-Reply-To: <20231026235433.yuvxf7opxg74ncmd@moria.home.lan>
References: <20231024134637.3120277-1-surenb@google.com>
 <20231024134637.3120277-29-surenb@google.com> <87h6me620j.ffs@tglx>
 <CAJuCfpH1pG513-FUE_28MfJ7xbX=9O-auYUjkxKLmtve_6rRAw@mail.gmail.com>
 <87jzr93rxv.ffs@tglx> <20231026235433.yuvxf7opxg74ncmd@moria.home.lan>
Date:   Fri, 27 Oct 2023 08:35:03 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Kent Overstreet" <kent.overstreet@linux.dev>,
        "Thomas Gleixner" <tglx@linutronix.de>
Cc:     "Suren Baghdasaryan" <surenb@google.com>,
        "Andrew Morton" <akpm@linux-foundation.org>,
        "Michal Hocko" <mhocko@suse.com>,
        "Vlastimil Babka" <vbabka@suse.cz>,
        "Johannes Weiner" <hannes@cmpxchg.org>,
        "Roman Gushchin" <roman.gushchin@linux.dev>,
        "Mel Gorman" <mgorman@suse.de>,
        "Davidlohr Bueso" <dave@stgolabs.net>,
        "Matthew Wilcox" <willy@infradead.org>,
        "Liam R. Howlett" <liam.howlett@oracle.com>,
        "Jonathan Corbet" <corbet@lwn.net>, void@manifault.com,
        "Peter Zijlstra" <peterz@infradead.org>, juri.lelli@redhat.com,
        ldufour@linux.ibm.com, "Catalin Marinas" <catalin.marinas@arm.com>,
        "Will Deacon" <will@kernel.org>, "Ingo Molnar" <mingo@redhat.com>,
        "Dave Hansen" <dave.hansen@linux.intel.com>, x86@kernel.org,
        peterx@redhat.com, "David Hildenbrand" <david@redhat.com>,
        "Jens Axboe" <axboe@kernel.dk>,
        "Luis Chamberlain" <mcgrof@kernel.org>,
        "Masahiro Yamada" <masahiroy@kernel.org>,
        "Nathan Chancellor" <nathan@kernel.org>, dennis@kernel.org,
        "Tejun Heo" <tj@kernel.org>, "Muchun Song" <muchun.song@linux.dev>,
        "Mike Rapoport" <rppt@kernel.org>,
        "Paul E. McKenney" <paulmck@kernel.org>, pasha.tatashin@soleen.com,
        yosryahmed@google.com, "Yu Zhao" <yuzhao@google.com>,
        "David Howells" <dhowells@redhat.com>,
        "Hugh Dickins" <hughd@google.com>,
        "Andrey Konovalov" <andreyknvl@gmail.com>,
        "Kees Cook" <keescook@chromium.org>,
        "Nick Desaulniers" <ndesaulniers@google.com>, vvvvvv@google.com,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        "Eric Biggers" <ebiggers@google.com>, ytcoode@gmail.com,
        "Vincent Guittot" <vincent.guittot@linaro.org>,
        dietmar.eggemann@arm.com, "Steven Rostedt" <rostedt@goodmis.org>,
        bsegall@google.com, bristot@redhat.com, vschneid@redhat.com,
        "Christoph Lameter" <cl@linux.com>,
        "Pekka Enberg" <penberg@kernel.org>,
        "Joonsoo Kim" <iamjoonsoo.kim@lge.com>,
        "Hyeonggon Yoo" <42.hyeyoo@gmail.com>,
        "Alexander Potapenko" <glider@google.com>,
        "Marco Elver" <elver@google.com>,
        "Dmitry Vyukov" <dvyukov@google.com>,
        "Shakeel Butt" <shakeelb@google.com>,
        "Muchun Song" <songmuchun@bytedance.com>,
        "Jason Baron" <jbaron@akamai.com>,
        "David Rientjes" <rientjes@google.com>, minchan@google.com,
        kaleshsingh@google.com, kernel-team@android.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        iommu@lists.linux.dev, Linux-Arch <linux-arch@vger.kernel.org>,
        linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
        linux-modules@vger.kernel.org, kasan-dev@googlegroups.com,
        cgroups@vger.kernel.org
Subject: Re: [PATCH v2 28/39] timekeeping: Fix a circular include dependency
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Oct 27, 2023, at 01:54, Kent Overstreet wrote:
> On Fri, Oct 27, 2023 at 01:05:48AM +0200, Thomas Gleixner wrote:
>> On Thu, Oct 26 2023 at 18:33, Suren Baghdasaryan wrote:
>> > On Wed, Oct 25, 2023 at 5:33=E2=80=AFPM Thomas Gleixner <tglx@linut=
ronix.de> wrote:
>> >> > This avoids a circular header dependency in an upcoming patch by=
 only
>> >> > making hrtimer.h depend on percpu-defs.h
>> >>
>> >> What's the actual dependency problem?
>> >
>> > Sorry for the delay.
>> > When we instrument per-cpu allocations in [1] we need to include
>> > sched.h in percpu.h to be able to use alloc_tag_save(). sched.h
>>=20
>> Including sched.h in percpu.h is fundamentally wrong as sched.h is the
>> initial place of all header recursions.
>>=20
>> There is a reason why a lot of funtionalitiy has been split out of
>> sched.h into seperate headers over time in order to avoid that.
>
> Yeah, it's definitely unfortunate. The issue here is that
> alloc_tag_save() needs task_struct - we have to pull that in for
> alloc_tag_save() to be inline, which we really want.
>
> What if we moved task_struct to its own dedicated header? That might be
> good to do anyways...

Yes, I agree that is the best way to handle it. I've prototyped
a more thorough header cleanup with good results (much improved
build speed) in the past, and most of the work to get there is
to seperate out structures like task_struct, mm_struct, net_device,
etc into headers that only depend on the embedded structure
definitions without needing all the inline functions associated
with them.

      Arnd