Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <abf335aa-1366-4c66-80f1-86e273143702@kontron.de>
Date:   Fri, 27 Oct 2023 08:51:49 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 4/4] spi: spi-fsl-qspi: Add support for rx data sample
 point adjustment
To:     kernel test robot <lkp@intel.com>, Eberhard Stoll <estl@gmx.net>,
        Han Xu <han.xu@nxp.com>, linux-kernel@vger.kernel.org,
        linux-spi@vger.kernel.org, Mark Brown <broonie@kernel.org>
Cc:     oe-kbuild-all@lists.linux.dev,
        Eberhard Stoll <eberhard.stoll@kontron.de>,
        Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>,
        Amit Kumar Mahapatra via Alsa-devel 
        <alsa-devel@alsa-project.org>, Michal Simek <monstr@monstr.eu>,
        Rob Herring <robh@kernel.org>,
        =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>,
        Yang Yingliang <yangyingliang@huawei.com>
References: <20231026152316.2729575-5-estl@gmx.net>
 <202310270332.mcbckKCr-lkp@intel.com>
Content-Language: en-US, de-DE
From:   Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <202310270332.mcbckKCr-lkp@intel.com>
Content-Type: text/plain; charset=UTF-8
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzZQRUJuZnZRc1JhVUlLL2Rqdms4SUlQOFh1UTBKcVRYTGFMaU5TQ0svMmRT?=
 =?utf-8?B?K2NaV09tQ2laYnBIV1VZK0ViYUVhV2FiWGVzT3RzdU96U0lhV0RYNGVVRWZy?=
 =?utf-8?B?d3ZJQ01YbTM3ZDhhK0p3azVvcnI5SU8zOE1IRjZiOHdyRlRBelJOWVJ1bGQ5?=
 =?utf-8?B?WkJsMjJVMWIzVEE2aytEQjlITEI4QjlHZVJNM2tLL2lOTDM3dUVyeGNvL3Fa?=
 =?utf-8?B?WXUvNlBmZFkxaHdOc0tYVUR4SVFzbW85V1pLQWd0TklRQVZNa3JSNC92aWQ1?=
 =?utf-8?B?SFc4bHhBNlByV1hJeHRla1k1OWlLNnlqRmd2YVRuUHBUWVFIZ3ptOEZKQklu?=
 =?utf-8?B?S1gwZ04vUzdxVzZyaHJwZkYzTEhlanFRTW5nSXdKdEFWb2lsYkhmQ3RoWmtv?=
 =?utf-8?B?Qmg2eEhlWUFMQndqTVQyTURzYXJQWC94NHdiVGZoOWFOTVN2bDVVcDUrMTVm?=
 =?utf-8?B?RlI4eFdDcUlMdjlZbkdQbzdTYW9udjZOcmQ4U3VVTmRxUEEyVmhIODMyZXBL?=
 =?utf-8?B?c2cwcENNQm90N08xTTYyaG8zaXA0SU5ETnN2ek5PR1Z3NUZrUnQ4ZWVaYThJ?=
 =?utf-8?B?OVRSL3ZKcGJVV3hYMEwxNlVGcVVEN2ZYSHFPUFh5TEtIVDFqVFZSWmp0UG96?=
 =?utf-8?B?c1NGME81U3RlUThBWU1UUWhXWlBlN2VQZUNaZlNZSmZSeHlWVWNjWmxkK1ZF?=
 =?utf-8?B?Wk1zTGlGVkVYMkZwd1dVVEM1b0xFMEhVYW1oekxnajV5alAyQUs4ckRnalhk?=
 =?utf-8?B?bDQ1dk9uV1BHTUhXZHRPN09JdlhaREtJODMxaTdZdld2UWNLKy9yc1VVVFoz?=
 =?utf-8?B?U2ZxVFYyamdyUTlBc0V4NlRldnZzWkJEY04zc2tDOXFpdGNMQmRoYnBWSFQ3?=
 =?utf-8?B?U1cwalUrbGVia1NLQ3JBN0hISjh3b1BGazVVaWF5V0tkT3pjV0NzY3N3WmZS?=
 =?utf-8?B?M3llaXA3M0Y3ZUFMQkZvVGtzN1VONURGS3B4UU9WcWc0ZDErVEw5RFc2UC9O?=
 =?utf-8?B?OXlCbHhwdFJ5ZytlRlR5Vkxxc2NRakcwVXlmWTg4MUx1REEwVjJ5bmZ1Wk1I?=
 =?utf-8?B?WjVDNVV0SmwxYk05b1lzcTNFVFlGVWJzSjlQa1BpUWhUWnlFcUROQWFkaG13?=
 =?utf-8?B?THdwZGtyZk5VKzM5VTlmQnJCOUpNeE5hU29vMXc3QXBDM1BNUysxRExSc05Y?=
 =?utf-8?B?aENQemVCaGIwNXRSWUNQN1NaVmtRVDZ3cm91LzAwTXpNOHZGS2t2N21RMFN6?=
 =?utf-8?B?QVc4ek5BNkxEWURrbTJtNHhRV3c2ZmhGdzBUU1hJaG9BK1FRWmp6SDV3a0JZ?=
 =?utf-8?B?V2tDTHNRajZ1ejNMS3M5cmZGVDJCVFVqZ3JEWnFGdDkycElZcldHenNna01W?=
 =?utf-8?B?S0hFU0xlaUY1RUdwbjZhRWRNWS92UUxaSWRvZUwwSVZwYnVFS05vRUpPWnVa?=
 =?utf-8?B?bjFRWWVYMEx4ZTg5L1g0Ui9CdjNWcTJvVVFnK3lwMEtkQXYzNVdqTmdpWHFp?=
 =?utf-8?B?UVNsRGUwTlFaS0FOZzJVQTF5dGNtOTJ1T2Y5Q0U5Ulo3dG8yWVdUNVl0U2t3?=
 =?utf-8?B?SGtzWDZjUkRyMmltdUZxSVNuNGVTK054TTFFaHhiMFFiOUEvWk84TFlWRmo5?=
 =?utf-8?B?NnhwNUt4Mi9tMHdLRFplRXN6bUN5VzgzQVY3QjRaT2RnZ1Yzb0g0ZnNqbnBz?=
 =?utf-8?B?OGhFa2k1QURFcFk3L2JKQk1SZ1NYM0srY2llUTQ2eTk5UmdtZ2ZCVlpDamZk?=
 =?utf-8?B?ZjBiYmJDNy8zL05EZndaUWdUbUplaHcxbWdpT3VQYjNYZ1QvSmgxNWl6eFpN?=
 =?utf-8?B?Y2pDVlNoUVFGTjZFK2dpZWRncmt0RmRBZmsvVWtSdCt5ckF5WmR4MDlTRHdS?=
 =?utf-8?B?d3h5am1wVTdqakdwZXVpcndaaVc1UWQvOXJzMUJuTGNnaDJPZlhxcHVIMm1N?=
 =?utf-8?B?MmNBNC9hTHVUODF5OUNRTHRFVFh1NjlNZWVwTSszOW9KZmxuLzd5UWQvcE1O?=
 =?utf-8?B?UkFqK1lXbTVIUXdXZ2I1aXpOdWVYUEd3RTNxemhKM2NWZTROS3ZlcHo0WVpq?=
 =?utf-8?B?SkRyeHd2QmxjcXBYSUtBRnF1K2o1TzRjbFovS0lQM3ZMdTRiUGZBVXFzeE1Y?=
 =?utf-8?B?QUl3aWdGQ0JRc09LUnNQbDdlWUF6VVRFdUNPRmZoeUo2MHA5ZXFLSGtlaXR5?=
 =?utf-8?B?M3c9PQ==?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: 89e8c010-b281-49f6-a471-08dbd6b93438
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2023 06:51:53.8826
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XG8nkqJB7hlRN0fqA5DbGmNMalfvhOkH6EkGiWYeI1dg1hxBLMhQqFKBt6gmJLQ/cVvVzUXZ5Q3gtgyE8wJolH9I919o2GEDhEamDInFkcA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR10MB5513
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 26 Oct 2023 23:52:15 -0700 (PDT)

On 26.10.23 22:03, kernel test robot wrote:
> Hi Eberhard,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on 05d3ef8bba77c1b5f98d941d8b2d4aeab8118ef1]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Eberhard-Stoll/spi-Add-parameter-for-clock-to-rx-delay/20231026-232547
> base:   05d3ef8bba77c1b5f98d941d8b2d4aeab8118ef1
> patch link:    https://lore.kernel.org/r/20231026152316.2729575-5-estl%40gmx.net
> patch subject: [PATCH 4/4] spi: spi-fsl-qspi: Add support for rx data sample point adjustment
> config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231027/202310270332.mcbckKCr-lkp@intel.com/config)
> compiler: m68k-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231027/202310270332.mcbckKCr-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202310270332.mcbckKCr-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>    drivers/spi/spi-fsl-qspi.c: In function 'fsl_qspi_select_mem':
>>> drivers/spi/spi-fsl-qspi.c:558:38: warning: suggest parentheses around comparison in operand of '|' [-Wparentheses]
>      558 |         if (chip->rx_sample_delay_ns != spi->rx_sample_delay_ns |
>          |             ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~

IIRC, when I prepared the patches for sending "checkpatch.pl --strict"
suggested to remove the parentheses here. Seems a bit inconsistent...