Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <ff389793-1226-49fd-b599-07dbda0b97be@amd.com>
Date:   Fri, 27 Oct 2023 09:35:01 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH drm-misc-next v3] drm/sched: implement dynamic job-flow
 control
Content-Language: en-US
To:     Boris Brezillon <boris.brezillon@collabora.com>
Cc:     Danilo Krummrich <dakr@redhat.com>, airlied@gmail.com,
        daniel@ffwll.ch, matthew.brost@intel.com, faith@gfxstrand.net,
        luben.tuikov@amd.com, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20231026161431.5934-1-dakr@redhat.com>
 <0bc79ae3-04fe-4e85-9fd0-e8b281148390@amd.com>
 <20231027093238.2ff8172e@collabora.com>
From:   =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
In-Reply-To: <20231027093238.2ff8172e@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkEwaVFpZWRYaFE4OHY4M1VpdjhNd2VNQ1JEdmE4a08vR0M4cFJxa3liTGdn?=
 =?utf-8?B?WE9kelh1cHZsdnpaM1lSaEYyMHplUXhjbEgzdERnMENXZzZtMXFLaVRFMmhE?=
 =?utf-8?B?aFphK0tWQ2FOcFVQM1l4UDB6SEl1NnBYbTc1Nm1jWGRrZndkTHRwU204RVQ2?=
 =?utf-8?B?cHZ6cy9obDYvR01ocHppZkhLRkxzODQyWWhLQjdSNUhhWDJleEVTQUJrWGIr?=
 =?utf-8?B?V3hrM0JQSy9yaXpTNm5GMXlSRTVwNUZ4VFdVK0lNaEQ0VFZxTytISW9ZREwr?=
 =?utf-8?B?TExacTlxUERoT256RlpHaHlpRE1MNTFTbWJ1UzRkYUxSRmpka0RRVCtiNEJP?=
 =?utf-8?B?d0hMTUNhWjY2S2dJbHhSRzhNOW9yaWxyZGhWUEt0TlF0SmxBZWhIbCtyd2NE?=
 =?utf-8?B?T2hMTVFSc1o4VSticHZLRkl3TzVnd285Mm4xQW5JMmNWZEdMM3lSb2UrMkRp?=
 =?utf-8?B?MVkydzFRcE16QTdoQjZHUWNFOUE3RWFhTGZ5cWZpR0xTV05XWmJ1aFBvMWRD?=
 =?utf-8?B?TzdqR0xLTG04cWJjdlNMY1R0bGF4dHZtN2VzbGJqa1F6UEtVSFo2OW1XcW40?=
 =?utf-8?B?NUNBMEtPR0FuQkRrSkNadEpEK01JWWQ5NGVOc3p6bGRNbCtidkIxdzFoS2d1?=
 =?utf-8?B?RVVTZTR1RnBTcjVEeWpIVFF1UzBZeVpxWm5rcHlleXpRTW1kY2xhaEYxL2hB?=
 =?utf-8?B?YWFpSGIzRXRLcTEySXFMWkxFamFWU2pSVDMrT2Z2ZFg5aHpza0lzT005bUdI?=
 =?utf-8?B?NDF1Q2dmNlova096SXYzRlhuaDFYU2lYMm9HWFhMc0M2SUI4U2F5SDZsZExy?=
 =?utf-8?B?WmRQd2U5b0M0TkZrd0xWWVZpQUZTQlVXUllqdllJQ3hHTHNzZy9scytqMXVB?=
 =?utf-8?B?SkNTeXdURCtsYXViN0ZyOGZxZm41NW5LU1U5M2R2KzZJdXNOSk9RM2svdEdF?=
 =?utf-8?B?eThkdmxGQVg1QUdrWmU3WTZCYVB6SUtYZjlDRkdzbzREQ3h3R3dMdmk2KzNL?=
 =?utf-8?B?WURoMmkyTHlSeUZRVVJYc1phc0gxdWprZEZOdmMrcWJSZGtPWG1peWFuOXJa?=
 =?utf-8?B?WndrVzZUZU8yZEpPeXE0a28wT21FcWN1N1M5ZW1OSnlacjYxUTF5Vit6L3hu?=
 =?utf-8?B?TkU2VjYrZmk0UkVsSGFONUsxTFFZeGRQb0xLY3dRNjAzbmxVVnRKMVB6Zk1V?=
 =?utf-8?B?dEZmaEJpMkpCeHYxNzJYSVRMc2VQTmgzcFZrOGl2aGdRRTJ3Z2RiRzh0VDZp?=
 =?utf-8?B?TGx5UVJhQStoZ0JrbDR6WTd6SS9MbmVBeklES0o4d2hBV2lVaWNDMEpiVnI0?=
 =?utf-8?B?MEJUMEJERjJLM3ZZVmJJYUIxY2Q2bEIwckVheEpIeXg0TWRKUXB2OVJGaVBR?=
 =?utf-8?B?SStZdkNwQUM2ZFI1M0g0TmM5VGIvb0VUbmQ1ZHl3SmM0TS9iYU9CR0ZvRFM3?=
 =?utf-8?B?dnYvRWt4bm1WVzEvOVdmVmExdkZubnRneDBEWVBJL3VVRXBLUXY3RDY1NXRX?=
 =?utf-8?B?bC82STgwUlA4eGs2dEgvTFNsWFhkQjhYQVl1U1pOZVZjRy9PdUhPTUNvQUFS?=
 =?utf-8?B?R3dyTS8rVlBVYjBZeDRRTE9vS0VVMERVbXFXYjY1ZkRzeGNVMFN5UEVCM2NU?=
 =?utf-8?B?WktpUHVBd2JZemR4RXZnYjg3OEdvWDQ1b2orWmh5K3hITXRPU3FPNFRmUlZa?=
 =?utf-8?B?dUdibWg3VXFYaDNVNGZxVFdrQWljV1dCY045TmJpSW5aUTJZNzJMWk5PeEYr?=
 =?utf-8?B?NEZSS1lQa05Hd0NyM3NSOHZoU1MzQzErNE9velhpSlN0R0NNNC9FQm9YanJq?=
 =?utf-8?B?V05QdHRYcm54dHM2Nm1ENkhLOE5aUE9zUHVVbnJNMEFPWHNrK3IrdW9LcnhL?=
 =?utf-8?B?ME14MTZHK0tEcGU0aW5Xa2FiQzlWMlVUYkpWVUYzY2xJcDlKQnFJZU8yL21m?=
 =?utf-8?B?WGlCRGxqVEZrQm41QXFNV1VPQjUzekJ0NWpOV0tqYXdFRjN0NVBCWm5Odzlq?=
 =?utf-8?B?Z2lxRXJPRlMwbXZSVk1tU0xwMWQyeEFoQTZCV3JOcUZUektuVWRIeFVRMFdW?=
 =?utf-8?B?bWp6NmNOamRzamdoNkdHSlZiTjFGRi9sT3ZtcFlrdlpSTnB6QmEyd2E0WkxC?=
 =?utf-8?Q?6oroCqqe9DzJ39FR0yxoqxVl7?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a9faf5d-d29e-4b41-56d4-08dbd6bf3d2a
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2023 07:35:05.8072
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WPMrYfznBarPBScv2h2cSoTCeh9W/nznQL1Mdwv2oH5giw9YwVbf97rYGGK/yWlU
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9261
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 27 Oct 2023 00:35:23 -0700 (PDT)

Am 27.10.23 um 09:32 schrieb Boris Brezillon:
> On Fri, 27 Oct 2023 09:22:12 +0200
> Christian König <christian.koenig@amd.com> wrote:
>
>>> +
>>> +	/**
>>> +	 * @update_job_credits: Called once the scheduler is considering this
>>> +	 * job for execution.
>>> +	 *
>>> +	 * Drivers may use this to update the job's submission credits, which is
>>> +	 * useful to e.g. deduct the number of native fences which have been
>>> +	 * signaled meanwhile.
>>> +	 *
>>> +	 * The callback must either return the new number of submission credits
>>> +	 * for the given job, or zero if no update is required.
>>> +	 *
>>> +	 * This callback is optional.
>>> +	 */
>>> +	u32 (*update_job_credits)(struct drm_sched_job *sched_job);
>> Why do we need an extra callback for this?
>>
>> Just document that prepare_job() is allowed to reduce the number of
>> credits the job might need.
> ->prepare_job() is called only once if the returned fence is NULL, but
> we need this credit-update to happen every time a job is considered for
> execution by the scheduler.

But the job is only considered for execution once. How do you see that 
this is called multiple times?

Regards,
Christian.

> If you're saying this control-flow should
> be implemented with a dma_fence that's signaled when enough space is
> available, I fear Danilo's work won't be that useful to the PowerVR
> driver, unfortunately.