Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   "Zhang, Tina" <tina.zhang@intel.com>
To:     Joerg Roedel <joro@8bytes.org>
CC:     "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "David Woodhouse" <dwmw2@infradead.org>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        "Will Deacon" <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        "Jason Gunthorpe" <jgg@ziepe.ca>,
        "Tian, Kevin" <kevin.tian@intel.com>,
        Nicolin Chen <nicolinc@nvidia.com>,
        Michael Shavit <mshavit@google.com>,
        Vasant Hegde <vasant.hegde@amd.com>,
        Jason Gunthorpe <jgg@nvidia.com>
Subject: RE: [PATCH v10 1/6] iommu: Change kconfig around IOMMU_SVA
Thread-Topic: [PATCH v10 1/6] iommu: Change kconfig around IOMMU_SVA
Thread-Index: AQHaCGlk1cvAoUzubk6PoTMGEq8RvbBdOPMAgAACSlA=
Date:   Fri, 27 Oct 2023 07:36:45 +0000
Message-ID: <MW5PR11MB5881E07803D25E3588FFABB789DCA@MW5PR11MB5881.namprd11.prod.outlook.com>
References: <20231027000525.1278806-1-tina.zhang@intel.com>
 <20231027000525.1278806-2-tina.zhang@intel.com> <ZTtixEgSkBI-TRro@8bytes.org>
In-Reply-To: <ZTtixEgSkBI-TRro@8bytes.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?X5FQ4fYNuMTvL5fzdDwn3achn224EGFJxH+HVRUibPVZtlq98AKkPOrRTB12?=
 =?us-ascii?Q?9CKQOipFHxSQ3Vox+XLW7j8YSTk/cGOst2rM7rS5n0zxUa72JPSQe5M8MPOC?=
 =?us-ascii?Q?Tb3uThwfffrps9dP4PMZGIxlZkEGcQ4jrTocQmzypNFzTPDKSihc3+3pFRWk?=
 =?us-ascii?Q?1bWhvL+k4swPf0Z/9RFtzyq3YKHk6TSb65qrC1IOXpZMDeV0M+VDfsHwJTiF?=
 =?us-ascii?Q?SsSbF60jdhIY/AK8vHBdmfis5/b5PmNmCS+z2eZIW96AZZUOVy8SchXN0zw0?=
 =?us-ascii?Q?i9/2nM7VGzyxb0ZhPJvUGddq11TT89WVBcIuFgscE1nAeqQidUz0PkE7B9kx?=
 =?us-ascii?Q?cSDFWSXakKKIwtaS+tNK06AGjOosvSPMrtRxE1OAYGhxdr8xXXPPyjb4ccw9?=
 =?us-ascii?Q?5o3SvsVC1o3KQKhDRk1m6R25ugxypRifPetBxPk+j+yIsYeoE/Vsj47dwKTk?=
 =?us-ascii?Q?YvrwJoiuSKoaNcvkOUVUOzVriO5Zm0XbZebNVdkZUVBIHkHXmCTjCGlg7RMD?=
 =?us-ascii?Q?Gm6SLE82BgiAHRYlQDo412pTCmVyPYhOmBiovgbZaSzNpEtGYjSTIVShfIjt?=
 =?us-ascii?Q?EyGz9GLX+mPG9IK7YCdm6Rqo+LlryCqnNN9xBFrMEkKsgE4jvjdxCDXMRAGd?=
 =?us-ascii?Q?3/DVbxmKiRgrZAHN4APurgF+QOrDegu9py8JdAFq0e4XFB6LKl4Oepnr8mU6?=
 =?us-ascii?Q?6pxB0/S+bR+k+HleaOwqNQ+rewc/8svz3ttQ8ioXavAOmo86bPhLRJVdKN+a?=
 =?us-ascii?Q?lZ/PUICDF0Apjwevs/98vgXVq9jbrajN3HtKszicglTtzJT8DU045pGctdVs?=
 =?us-ascii?Q?v03Oj+IgU0rT0eJ7hoD1nd9A4ada9KoKr8kv3WF0fnWkt0SUk5FmJXRrXZuM?=
 =?us-ascii?Q?QwZwNLcL4BGyxe2xhYxK6NQd41iHePEn5DU6HXqCCgOoBEH7kpVrGgEPWsgY?=
 =?us-ascii?Q?GHRivpiJ9sCRblybXf2/zc+g1CjiGxh9XC6Ml55aS1m4AGBxDVaiwYPanVC0?=
 =?us-ascii?Q?p3H4odBBKdyaeKCKT0BPEIGxN5svGxOGi1waKZJCBqNylPK3Oh27etl28bu/?=
 =?us-ascii?Q?zjxn1nUhXHJ2S1z5XiSo47+MypzYz2Z2FzfiO/W8lSp+nWzUX6XcmuvpDuI+?=
 =?us-ascii?Q?z3Z6wmhI06Oq3ixhtskhbRfajyGhdV/nxuw+CqXZozey7y+tL+EK0peePJg0?=
 =?us-ascii?Q?ZMKyce3s5bVBmIFMAkYAMtKPv0VTXbRcN9rnvmD3RFh403/yUN0VpwjqGz8n?=
 =?us-ascii?Q?KMEq69zzdFpjPhHKV+9gkmXPZqy4DjkTg1Q3okWGlcjvRuROjONtrUcPUuYO?=
 =?us-ascii?Q?qfannXV195G4sTe4NmzDeirtH+9ttxeqSm8lVvvNyYBDfUB8dedz6iU/Z+0i?=
 =?us-ascii?Q?I7wLTXgU8HBq+asiG2JvHNqwdr9d3J+PEY2HcoXD2S7vKfs+wLCfoY6+1roc?=
 =?us-ascii?Q?LE3B6A294+c9T4xQBCVx0rZJ+qJcHiIgeCSNe71vNhTehIUzqSJymQNO1rWF?=
 =?us-ascii?Q?K9zJDSubVLoT8OBPrecR7UwuKXoWsv6UBCdruRki5dQCpYtFOrWTf/RQ08pS?=
 =?us-ascii?Q?zLcctLx4zjzdBehkui/gIPHeLXyJMMZ8UtXuzJYX?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5881.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7afc03b6-4608-46e1-3004-08dbd6bf7903
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2023 07:36:46.0009
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8O6zSYbBtXPGMH0YsShdX80jUPcu26iRX/9DbH+h11AFZis53x/wzWI6Iq7/PW07VL3LQIKJUv1VXsRl5LcuWw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR11MB7983
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 27 Oct 2023 00:37:00 -0700 (PDT)

Hi Joerg,

> -----Original Message-----
> From: Joerg Roedel <joro@8bytes.org>
> Sent: Friday, October 27, 2023 3:12 PM
> To: Zhang, Tina <tina.zhang@intel.com>
> Cc: iommu@lists.linux.dev; linux-kernel@vger.kernel.org; David Woodhouse
> <dwmw2@infradead.org>; Lu Baolu <baolu.lu@linux.intel.com>; Will Deacon
> <will@kernel.org>; Robin Murphy <robin.murphy@arm.com>; Jason
> Gunthorpe <jgg@ziepe.ca>; Tian, Kevin <kevin.tian@intel.com>; Nicolin Che=
n
> <nicolinc@nvidia.com>; Michael Shavit <mshavit@google.com>; Vasant
> Hegde <vasant.hegde@amd.com>; Jason Gunthorpe <jgg@nvidia.com>
> Subject: Re: [PATCH v10 1/6] iommu: Change kconfig around IOMMU_SVA
>=20
> Hi Tina,
>=20
> On Fri, Oct 27, 2023 at 08:05:20AM +0800, Tina Zhang wrote:
> > From: Jason Gunthorpe <jgg@nvidia.com>
> >
> > Linus suggested that the kconfig here is confusing:
>=20
> While this patch looks decent to me, you forgot to Cc Linus on it. In gen=
eral,
> given that it touches a couple of core files, I'd like to wait for some m=
ore
> people to have a look at it and not rushing anything in.
Make sense. I'll CC Linus. Comments are welcome.

> >
> > https://lore.kernel.org/all/CAHk-
> =3DwgUiAtiszwseM1p2fCJ+sC4XWQ+YN4TanFhU
> > gvUqjr9Xw@mail.gmail.com/
> >
> > Let's break it into three kconfigs controlling distinct things:
> >
> >  - CONFIG_IOMMU_MM_DATA controls if the mm_struct has the additional
> >    fields for the IOMMU. Currently only PASID, but later patches store
> >    a struct iommu_mm_data *
> >
> >  - CONFIG_ARCH_HAS_CPU_PASID controls if the arch needs the scheduling
> bit
> >    for keeping track of the ENQCMD instruction. x86 will select this if
> >    IOMMU_SVA is enabled
> >
> >  - IOMMU_SVA controls if the IOMMU core compiles in the SVA support
> code
> >    for iommu driver use and the IOMMU exported API
> >
> > This way ARM will not enable CONFIG_ARCH_HAS_CPU_PASID
> >
> > Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
>=20
> If you send it, you also need to add your Signed-off-by.
OK. I'll add my Signed-off-by.

Thanks,
-Tina

>=20
> Regards,
>=20
> 	Joerg