Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758441AbXKUHwn (ORCPT ); Wed, 21 Nov 2007 02:52:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752701AbXKUHwe (ORCPT ); Wed, 21 Nov 2007 02:52:34 -0500 Received: from hoboe2bl1.telenet-ops.be ([195.130.137.73]:36074 "EHLO hoboe2bl1.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752340AbXKUHwd (ORCPT ); Wed, 21 Nov 2007 02:52:33 -0500 Date: Wed, 21 Nov 2007 08:52:27 +0100 (CET) From: Geert Uytterhoeven To: Richard Knutsson Cc: Andrew Morton , Linux/m68k , Linux Kernel Development , Alejandro Martinez Ruiz Subject: Re: [patch 02/13] dio: ARRAY_SIZE() cleanup In-Reply-To: <474355BE.8030409@student.ltu.se> Message-ID: References: <20071118101336.330321764@mail.of.borg> <20071118101446.793269838@mail.of.borg> <474355BE.8030409@student.ltu.se> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1840 Lines: 63 On Tue, 20 Nov 2007, Richard Knutsson wrote: > Geert Uytterhoeven wrote: > > > -#define NUMNAMES (sizeof(names) / sizeof(struct dioname)) > > +#define NUMNAMES ARRAY_SIZE(names) > > Why not replace NUMNAMES? Good idea! Updated patch below. --- Subject: dio: ARRAY_SIZE() cleanup From: Alejandro Martinez Ruiz dio: ARRAY_SIZE() cleanup [Geert: eliminate NUMNAMES, as suggested by Richard Knutsson ] Signed-off-by: Alejandro Martinez Ruiz Signed-off-by: Geert Uytterhoeven --- drivers/dio/dio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/drivers/dio/dio.c +++ b/drivers/dio/dio.c @@ -88,8 +88,6 @@ static struct dioname names[] = #undef DIONAME #undef DIOFBNAME -#define NUMNAMES (sizeof(names) / sizeof(struct dioname)) - static const char *unknowndioname = "unknown DIO board -- please email !"; @@ -97,7 +95,7 @@ static const char *dio_getname(int id) { /* return pointer to a constant string describing the board with given ID */ unsigned int i; - for (i = 0; i < NUMNAMES; i++) + for (i = 0; i < ARRAY_SIZE(names); i++) if (names[i].id == id) return names[i].name; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/