Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp987375rdh; Fri, 27 Oct 2023 01:03:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHIkAXzIUB1rDmNfgfD+YjWve+mSHMNRyhlT+b3ppDosYE7eZ1YFA1Y0NvPyHcLWT7wovMd X-Received: by 2002:a05:6808:302:b0:3a6:f622:70f1 with SMTP id i2-20020a056808030200b003a6f62270f1mr1591152oie.57.1698393823339; Fri, 27 Oct 2023 01:03:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698393823; cv=none; d=google.com; s=arc-20160816; b=oXHwyd/qZ8J8cD0CAnlOusic9IchThtQWM1kSvEd8nASWnr7EX3E+B91sQWJ2ZDRVm J2w7LVfS7cn72Z02p7NvTgUupc/xBeCmpt2oIW6R0cfn53IKoXtFIouqg4avG01qBD/2 W3jK8wPqtWLivpBYKAtuq2zeK0kQwd2O7eydd2sF7tGvb9H/722d1EYgDdKjo7Hp64fI 384JY2E2oe324xTSsYHh56qtIRPWKOGutgj+FfxhOmvBoHnM+EFAhRAyZxNzhFFJ52c4 pB3H1bj021bg1xKWmf2if2LTH2qynR9eU4AJ254WX/B0RiQJRaGaUOiDlwat/ayCvtBL oLQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:content-language:references:cc:to:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=8Vj9QUgzkK5jxhA45WZNLqLAj0Cw47WkThAQBGLU9IA=; fh=70bvhjPEmv3tIMnKl7BapP4gDc106aRc0F7C2xkCmbA=; b=z0Zqb+a5Q4B2JXOrtiWd85B7AY1DXuoWPy0mBmOoG1NRGPuI2ycfvH67F14jg0gpsX mWbxFYWOcOTTlDCmyp0cKRF0aZLagQyI28UaVyDh1Gnmt+UWG2ZJKUZ7XvPLjqvH1Fhh Zz316yimCjgd012QU8N2KCap2OZ9FqSzuNJ6GihINgtjfOuznUaqVuk338roZepQQUCE 2IHl26RWQqoLQ2gWMw0dipbZAN29wrMzhaNsY4kHAj9VTJtSrh+qeHB65rkKKP8d9jZ6 IEqugqhsdLjv2iKynABtQXP4puMCrVV5F+L7jAZDtbD60eJQFXuVxMOU7T3vcLrZ2dv7 0w+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jlFL2DAL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id 68-20020a250247000000b00d9cd4de7cc6si1799959ybc.513.2023.10.27.01.03.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Oct 2023 01:03:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jlFL2DAL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 6A700809AFCB; Fri, 27 Oct 2023 01:03:20 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234981AbjJ0IC5 (ORCPT + 99 others); Fri, 27 Oct 2023 04:02:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbjJ0ICz (ORCPT ); Fri, 27 Oct 2023 04:02:55 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08170111; Fri, 27 Oct 2023 01:02:53 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4983C433C7; Fri, 27 Oct 2023 08:02:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698393772; bh=qBhixI295XZFLMlYuV4YMaMKUlDmM1jtasM2MlNqIrE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jlFL2DALS+gH82StTTMIG3nL4jljsvr4W0BkR7ULwLaZJhc9ucE0ALsTdfgTxM5rt 8MmnHtKQfuEprEYBmspyko//3x6ho2NOsAwI5uJE5I58mNHbw7Yq3xdd97x10HGQek JDas8jqdyBbn17qm4ZjszN/RSoQd+KHpp+jtk4MXC7S0Qm9H49hWY6eyPiEqvqkzfb gwFdKgVhKfL28U94E6aAS0NGNoRkjFOPEW67XWlxquTjdJ/FK8ylLeHloB2q4G+D3h V4rMqH1agxuWlvG8uPCkfk60FilCXUHamyRPu1yOTPs10+bxn163HYiiuV/ERGG7zt 8cjhjnQu14TPQ== Message-ID: <025c3d36-587e-480c-b913-2a3916674c54@kernel.org> Date: Fri, 27 Oct 2023 10:02:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] dt-bindings: hwmon: lm87: convert to YAML To: Li peiyu <579lpy@gmail.com>, jdelvare@suse.com, linux@roeck-us.net Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231026080226.52170-1-579lpy@gmail.com> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20231026080226.52170-1-579lpy@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 27 Oct 2023 01:03:20 -0700 (PDT) On 26/10/2023 10:02, Li peiyu wrote: > Convert the lm87 hwmon sensor bindings to DT schema > > Signed-off-by: Li peiyu <579lpy@gmail.com> > --- > Changes for v2: > - replace node name lm87 with sensor > - replace character '\t' with spaces > > .../devicetree/bindings/hwmon/lm87.txt | 30 ---------- > .../devicetree/bindings/hwmon/lm87.yaml | 59 +++++++++++++++++++ ... > -- vcc-supply: a Phandle for the regulator supplying power, can be > - configured to measure 5.0V power supply. Default is 3.3V. > - > -Example: > - > -lm87@2e { > - compatible = "ti,lm87"; > - reg = <0x2e>; > - has-temp3; > - vcc-supply = <®_5v0>; > -}; > diff --git a/Documentation/devicetree/bindings/hwmon/lm87.yaml b/Documentation/devicetree/bindings/hwmon/lm87.yaml > new file mode 100644 > index 000000000000..8f4f07845d95 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/lm87.yaml This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. > @@ -0,0 +1,59 @@ It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. Best regards, Krzysztof