Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Fri, 27 Oct 2023 10:22:37 +0200
From:   Boris Brezillon <boris.brezillon@collabora.com>
To:     Christian =?UTF-8?B?S8O2bmln?= <christian.koenig@amd.com>
Cc:     Danilo Krummrich <dakr@redhat.com>, airlied@gmail.com,
        daniel@ffwll.ch, matthew.brost@intel.com, faith@gfxstrand.net,
        luben.tuikov@amd.com, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH drm-misc-next v3] drm/sched: implement dynamic job-flow
 control
Message-ID: <20231027102237.0cdb85af@collabora.com>
In-Reply-To: <98988459-25a8-4ee0-89d4-cb816cbc5bef@amd.com>
References: <20231026161431.5934-1-dakr@redhat.com>
        <0bc79ae3-04fe-4e85-9fd0-e8b281148390@amd.com>
        <20231027093238.2ff8172e@collabora.com>
        <ff389793-1226-49fd-b599-07dbda0b97be@amd.com>
        <20231027093943.3f0ae992@collabora.com>
        <98988459-25a8-4ee0-89d4-cb816cbc5bef@amd.com>
Organization: Collabora
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, 27 Oct 2023 09:44:13 +0200
Christian K=C3=B6nig <christian.koenig@amd.com> wrote:

> Am 27.10.23 um 09:39 schrieb Boris Brezillon:
> > On Fri, 27 Oct 2023 09:35:01 +0200
> > Christian K=C3=B6nig<christian.koenig@amd.com>  wrote:
> > =20
> >> Am 27.10.23 um 09:32 schrieb Boris Brezillon: =20
> >>> On Fri, 27 Oct 2023 09:22:12 +0200
> >>> Christian K=C3=B6nig<christian.koenig@amd.com>  wrote:
> >>>    =20
> >>>>> +
> >>>>> +	/**
> >>>>> +	 * @update_job_credits: Called once the scheduler is considering =
this
> >>>>> +	 * job for execution.
> >>>>> +	 *
> >>>>> +	 * Drivers may use this to update the job's submission credits, w=
hich is
> >>>>> +	 * useful to e.g. deduct the number of native fences which have b=
een
> >>>>> +	 * signaled meanwhile.
> >>>>> +	 *
> >>>>> +	 * The callback must either return the new number of submission c=
redits
> >>>>> +	 * for the given job, or zero if no update is required.
> >>>>> +	 *
> >>>>> +	 * This callback is optional.
> >>>>> +	 */
> >>>>> +	u32 (*update_job_credits)(struct drm_sched_job *sched_job); =20
> >>>> Why do we need an extra callback for this?
> >>>>
> >>>> Just document that prepare_job() is allowed to reduce the number of
> >>>> credits the job might need.
> >>> ->prepare_job() is called only once if the returned fence is NULL, bu=
t =20
> >>> we need this credit-update to happen every time a job is considered f=
or
> >>> execution by the scheduler. =20
> >> But the job is only considered for execution once. How do you see that
> >> this is called multiple times? =20
> > Nope, it's not. If drm_sched_can_queue() returns false, the scheduler
> > will go look for another entity that has a job ready for execution, and
> > get back to this entity later, and test drm_sched_can_queue() again.
> > Basically, any time drm_sched_can_queue() is called, the job credits
> > update should happen, so we have an accurate view of how many credits
> > this job needs. =20
>=20
> Well, that is the handling which I already rejected because it creates=20
> unfairness between processes. When you consider the credits needed=20
> *before* scheduling jobs with a lower credit count are always preferred=20
> over jobs with a higher credit count.

My bad, it doesn't pick another entity when an entity with a
ready job that doesn't fit the queue is found, it just bails out from
drm_sched_rq_select_entity_rr() and returns NULL (AKA: no ready entity
found). But we still want to update the job credits before checking if
the job fits or not (next time this entity is tested).

> What you can do is to look at the credits of a job *after* it was picked=
=20
> up for scheduling so that you can scheduler more jobs.

Sure, but then you might further delay your job if something made it
smaller (ie. native fences got signaled) between ->prepare_job() and
drm_sched_can_queue(). And any new drm_sched_can_queue() test would
just see the old credits value.

Out of curiosity, what are you worried about with this optional
->update_job_credits() call in the drm_sched_can_queue() path? Is the
if (sched->update_job_credits) overhead considered too high for drivers
that don't need it?