Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <b29594464415af0ea56b6d5431744982fa1385ee.camel@gmail.com>
Subject: Re: [PATCH v2 2/2] iio: adc: adding support for pac193x
From:   Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To:     Marius.Cristea@microchip.com, jic23@kernel.org, lars@metafoo.de,
        robh+dt@kernel.org
Cc:     conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Fri, 27 Oct 2023 10:40:21 +0200
In-Reply-To: <02ea54ae3a2ab4f0a19232a4df494f71b1de3b00.camel@microchip.com>
References: <20231025134404.131485-1-marius.cristea@microchip.com>
         <20231025134404.131485-3-marius.cristea@microchip.com>
         <d914069815f76245ef91b6b7b0c6b382b054b562.camel@gmail.com>
         <02ea54ae3a2ab4f0a19232a4df494f71b1de3b00.camel@microchip.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-10-26 at 15:03 +0000, Marius.Cristea@microchip.com wrote:
> Hi Nuno S=C3=A1,
>=20
> =C2=A0 Thanks for looking over the patch.
>=20
> On Wed, 2023-10-25 at 16:38 +0200, Nuno S=C3=A1 wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you
> > know the content is safe
> >=20
> > On Wed, 2023-10-25 at 16:44 +0300,
> > marius.cristea@microchip.com=C2=A0wrote:
> > > From: Marius Cristea <marius.cristea@microchip.com>
> > >=20
> > > This is the iio driver for Microchip
> > > PAC193X series of Power Monitor with Accumulator chip family.
> > >=20
> > > Signed-off-by: Marius Cristea <marius.cristea@microchip.com>
> > > ---
> >=20
> > Hi Marius,
> >=20
> > I'll be honest and I just looked at this for 5min. But I'm seeing
> > things like
> > shunt resistors, vsense, power, energy... This seems to me that it
> > belong to
> > drivers/hwmon. Any special reason for IIO?
> >=20
>=20
> =C2=A0 Yes, this device is at the boundary between IIO and HWMON if you a=
re
> looking just at the "shunt resistors, vsense, power, energy". The
> device also has ADC internaly that can measure voltages (up to 4
> channels) and also currents (up to 4 channels). Current is measured as
> voltage across the shunt_resistor.
>=20

I think this alone is not justification but...

> =C2=A0 As I said before: I was thinking to start with a simple driver (th=
is
> one that is more apropiate to be a HWMON) and add more functionality
> later (like data buffering that is quite important for example if
> someone wants to profile power consumtion of the procesor itself, or a
> pheriperic, or a battery, this kind of functionality was requested by
> our customers).
>=20

having buffering support already makes a case for IIO, yes.

Hmm, I'm also just realizing this is v2 and indeed you already justified th=
e very
same question in v1. Sorry for noise!

- Nuno S=C3=A1
>=20