Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
MIME-Version: 1.0
References: <20231025104457.628109-1-robimarko@gmail.com> <20231025104457.628109-2-robimarko@gmail.com>
 <77314fe2-2936-4f89-a347-4eb288507c47@linaro.org> <1b99abed-6572-4550-98cc-56667a507883@linaro.org>
In-Reply-To: <1b99abed-6572-4550-98cc-56667a507883@linaro.org>
From:   Robert Marko <robimarko@gmail.com>
Date:   Fri, 27 Oct 2023 10:48:22 +0200
Message-ID: <CAOX2RU7gXAJM8xYOc2G__2HSQCQKuy5sUcXoyr_a8WKndD1yLg@mail.gmail.com>
Subject: Re: [PATCH 2/3] clk: qcom: ipq6018: add USB GDSCs
To:     Konrad Dybcio <konrad.dybcio@linaro.org>
Cc:     agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        mturquette@baylibre.com, sboyd@kernel.org,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 26 Oct 2023 at 20:45, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
>
>
> On 10/26/23 20:42, Konrad Dybcio wrote:
> >
> >
> > On 10/25/23 12:44, Robert Marko wrote:
> >> IPQ6018 has GDSC-s for each of the USB ports, so lets define them as such
> >> and drop the curent code that is de-asserting the USB GDSC-s as part of
> >> the GCC probe.
> >>
> >> Signed-off-by: Robert Marko <robimarko@gmail.com>
> >> ---
> > Applying patches 1 and 3 without this one breaks usb, no?
> Sorry, my hands don't keep up with my brain - that's almost another
> speculative execution vulnerability!
>
> What I meant to say is:
>
> applying patches 1 and 2 breaks USB
>
> but
>
> the solution here would be to apply patch 1 and patch 3, followed
> by patch 2 (unless it will make the USB defer, IDK, it's probably
> easier to just test than to dive deep into the code)
>
> with Bjorn taking both subsystems, we can make that work I think

Hi,
Applying patches 1 and 3 without patch 2 will make USB fail with:
# [   11.351681] dwc3-qcom 8af8800.usb: deferred probe timeout,
ignoring dependency
[   11.351729] dwc3-qcom: probe of 8af8800.usb failed with error -110

And yes, applying patches 1 and 2 without patch 3 will also break USB.
That is why I sent this as a series.

Regards,
Robert

>
> Konrad