Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp1010133rdh; Fri, 27 Oct 2023 01:56:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IELPReqmpNSsxgrAJyAZjWpDwQoqJL4AuMmmqLhxuhzj0wY5ZDwuEEH4SOb61ath4jaUEKu X-Received: by 2002:a25:d30a:0:b0:d9c:f811:eb6b with SMTP id e10-20020a25d30a000000b00d9cf811eb6bmr3591561ybf.0.1698397004037; Fri, 27 Oct 2023 01:56:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698397004; cv=none; d=google.com; s=arc-20160816; b=D2Gg0ueWVU5Mn1IGo2VSPL/Lb3dWUiwd7liQU5MCZc8da0J9ISQpRN/N2XJNJXI4uM S8uJIu0EkAWVruwNZIWIhvNeeqnz36kePMmzgQYKe70BzhfD5rv9pb8F86Eu/7QdRCyJ KQXRb5IitO1hunvljyLooepxx38QiJXexLbYy43Mm8x+kXnk8ZCyKNTFW8kQOhnHlVbp w4TpqGvSMGFi/j6dzlZ9wI97DmXGMogNMpeU54zJr8i+MZsaiox04cXPa0BKAWBcRPT/ rsfmNIZk7MMvhcDR6y0dUmuGuVZT5zQh0LciHQsMqhbvLVruFx5bpCDLcP/rdbbse2nF 2Lvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=Y7nivA7Y4G+DJle+MuF/UdLNZEk2svAAlFKkW3ePDro=; fh=K0sS3xXx69wdTuuzdvQU1ivOn5qGUPU4CCXxck2E4Uw=; b=s9kmLg2NR5/PcgPRSqJkEL4hPN1lZB3qU9ueo9lreFic/zfFf/+RTscFn0susRrE7n /0AUNsKthNM7s64l41gxA0KgGUt2hZgopXeaN31iFS5pbiiiyYAYfayOW6JyZVI6O4Fn cCmN0ri/3AUnG+90NosEQPh+PGTREAnrKLMc5NNzHMjUQQwMLnZnoo7I0NbGx+wtt4e6 C0crSTBh1CnywKwqsGI+bfVuuVcSuFfdzxFCEyVPn3isox9tghcPsNO0/ogxvwUHuxPt HHlH9C121Zch6IaJcp1CXkQkYpIJ89UUyvS+pO/GBs4ed6yCsUraoM4Y4BWMH5fnMkmF NMiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CDqkk7pm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id w130-20020a25df88000000b00da0514a0591si1922993ybg.235.2023.10.27.01.56.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Oct 2023 01:56:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CDqkk7pm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 1FDFE806D7DB; Fri, 27 Oct 2023 01:56:41 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345544AbjJ0I4e (ORCPT + 99 others); Fri, 27 Oct 2023 04:56:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345598AbjJ0I4b (ORCPT ); Fri, 27 Oct 2023 04:56:31 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B191EC4 for ; Fri, 27 Oct 2023 01:56:28 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-508126afb9bso2552656e87.0 for ; Fri, 27 Oct 2023 01:56:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698396987; x=1699001787; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Y7nivA7Y4G+DJle+MuF/UdLNZEk2svAAlFKkW3ePDro=; b=CDqkk7pmnlRuGYnnJs7zy9HYAvf5cc0OSHCstQSkR15zk1NNE6RjObrRavpLJ3uZe6 owVeLslPC/zl3zcjUUvecfBxXy5wpkZi1zGv49OgJpH8/6F3wKtqiS7QsScdB8tRQBE/ O/eYqlc6A5Fw1wT/A0thCUpQHZo76pDFsehnVXxQGo4q5avUdnx9o8meVtUv39dM861k MuOl7ueJYumQym+g+tOanJLCZUtTtrGqTw6aJWWrpAYpxrOWO+2Tfp/BQRTaguL0vmR9 9iWNOogff7+gYa+Pvl6DqXIgy6QF8Qm1reJ3SNnkzFF/6bzxXdKE5WQdTg51cP1iTifC zzQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698396987; x=1699001787; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y7nivA7Y4G+DJle+MuF/UdLNZEk2svAAlFKkW3ePDro=; b=wnvN9Z9g5WgDd/+esMU7zOQgt/Zayg+Rw/QKH+fklN33PmX2B72C0QtKNRpPVBnISY 9QbFIlEPhaEOJvVYDMiciAtZyJIuQ58sqcADzKG+5A+msa7hm0RmHyoTidYCK3tQqfRg w4cd/hrNwu4xcVgwWgee1/Ppu4D5K3QwFKIqdnM7pgrvKwgcwyvSECnoMER6EzVcPXEG viXGwBsiqR/HmJsxzI5zsClDesnJUJxc2firECy4l7e/3OJ2WgWC2T5Qky8jx70i05wc 2uOjZckc3+fInm75RmrQfos1bS+7IqP/GYMpRcbiM2edUAPl2MWLISWmBwJBaYxywM0H Preg== X-Gm-Message-State: AOJu0YxeXbkvF+j6UBuQZtIMYMRmcJLQ3XE/VdyLpSvFIZrLsthpjqQU BcN+6WhOZUgOiZUmVohT2VYCXg== X-Received: by 2002:a19:5517:0:b0:500:b7ed:1055 with SMTP id n23-20020a195517000000b00500b7ed1055mr1125542lfe.56.1698396986962; Fri, 27 Oct 2023 01:56:26 -0700 (PDT) Received: from [192.168.0.22] ([78.10.206.168]) by smtp.gmail.com with ESMTPSA id f24-20020ac251b8000000b005079ff16d9fsm193169lfk.138.2023.10.27.01.56.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Oct 2023 01:56:26 -0700 (PDT) Message-ID: <0ce0c283-3c1c-4dbe-8b0c-ff2e2d5420c9@linaro.org> Date: Fri, 27 Oct 2023 10:56:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v5 5/5] dt-bindings: firmware: arm,scmi: Add support for pinctrl protocol Content-Language: en-US To: Oleksii Moisieiev , "sudeep.holla@arm.com" Cc: Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" References: From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 27 Oct 2023 01:56:41 -0700 (PDT) On 27/10/2023 08:28, Oleksii Moisieiev wrote: > Add new SCMI v3.2 pinctrl protocol bindings definitions and example. > > Signed-off-by: Oleksii Moisieiev > > --- > Changes v3 -> v4 > - reworked protocol@19 format > --- > .../bindings/firmware/arm,scmi.yaml | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > > diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > index 5824c43e9893..5318fe72354e 100644 > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > @@ -233,6 +233,39 @@ properties: > reg: > const: 0x18 > > + protocol@19: > + type: object > + allOf: > + - $ref: "#/$defs/protocol-node" > + - $ref: "../pinctrl/pinctrl.yaml" This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. Best regards, Krzysztof