Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <641f90da-332a-4021-869e-fdbcff435d90@gmail.com>
Date:   Fri, 27 Oct 2023 14:49:41 +0530
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] iio/imu: inv_icm42600: Use max() helper macros
To:     Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com>,
        "jic23@kernel.org" <jic23@kernel.org>,
        "lars@metafoo.de" <lars@metafoo.de>
Cc:     "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20231025113544.4954-1-bragathemanick0908@gmail.com>
 <FR3P281MB1757821128DD28BD9F2742A6CEDCA@FR3P281MB1757.DEUP281.PROD.OUTLOOK.COM>
Content-Language: en-US
From:   Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
In-Reply-To: <FR3P281MB1757821128DD28BD9F2742A6CEDCA@FR3P281MB1757.DEUP281.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 27/10/23 14:24, Jean-Baptiste Maneyrol wrote:
> Hello,
>
> thanks for this patch.
>
> The same computation is also done inside inv_icm42600_gyro. Can you do a patch that is updating both files to use max?
>
> Thanks a lot,
> JB
Hi Jean,

Same computation can be included in both inv_icm42600_gyro and 
inv_icm42600_buffer.
Will make those changes and send a new patch.

Thanks,
Bragathe
>
> From: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
> Sent: Wednesday, October 25, 2023 13:35
> To: Jean-Baptiste Maneyrol <Jean-Baptiste.Maneyrol@tdk.com>; jic23@kernel.org <jic23@kernel.org>; lars@metafoo.de <lars@metafoo.de>
> Cc: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>; linux-iio@vger.kernel.org <linux-iio@vger.kernel.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>
> Subject: [PATCH] iio/imu: inv_icm42600: Use max() helper macros
>   
> Use the standard max() helper macros instead of direct variable comparison using if/else blocks or ternary operator. Change identified using minmax. cocci Coccinelle semantic patch. Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@ gmail. com>
> ZjQcmQRYFpfptBannerStart
> This Message Is From an Untrusted Sender
> You have not previously corresponded with this sender.
>   
> ZjQcmQRYFpfptBannerEnd
> Use the standard max() helper macros instead of direct
> variable comparison using if/else blocks or ternary
> operator. Change identified using minmax.cocci
> Coccinelle semantic patch.
>
> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
> ---
>   drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c
> index b1e4fde27d25..f67bd5a39beb 100644
> --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c
> +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c
> @@ -137,10 +137,7 @@ static int inv_icm42600_accel_update_scan_mode(struct iio_dev *indio_dev,
>   out_unlock:
>   	mutex_unlock(&st->lock);
>   	/* sleep maximum required time */
> -	if (sleep_accel > sleep_temp)
> -		sleep = sleep_accel;
> -	else
> -		sleep = sleep_temp;
> +	sleep = max(sleep_accel, sleep_temp);
>   	if (sleep)
>   		msleep(sleep);
>   	return ret;