Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <62ab75f8-0e15-441a-b6b3-0b8cc138419b@amlogic.com>
Date:   Fri, 27 Oct 2023 17:22:21 +0800
User-Agent: Mozilla Thunderbird
From:   Junyi Zhao <junyi.zhao@amlogic.com>
Subject: Re: [PATCH V3 RESEND] pwm: meson: add pwm support for S4
To:     George Stark <gnstark@salutedevices.com>,
        Yixun Lan <dlan@gentoo.org>
Cc:     thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de,
        neil.armstrong@linaro.org, khilman@baylibre.com,
        jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
        linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20231016052457.1191838-1-junyi.zhao@amlogic.com>
 <20231016223749.GA7647@ofsar>
 <07f978ec-2f18-4079-afb1-4d37827806a3@salutedevices.com>
Content-Language: en-GB
In-Reply-To: <07f978ec-2f18-4079-afb1-4d37827806a3@salutedevices.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WXNWRGZUS1lvdStGMFJsd1I2NzFORldrWWQvM0d0T1FneTh0ZldUcUtjU003?=
 =?utf-8?B?RjZNTlNMVFpyY0ozRXVKTlhjbVVWWmtUSHp3Nit4eEJHM1dBQ3dJQ3VDbHFK?=
 =?utf-8?B?WjRpOFVEOEhQL095VEZmV25QWkgyUFVnQXJYNHdqa2ZGaTd0Y3JVRjFNalhD?=
 =?utf-8?B?aTZtTm1qakpiOUpCYnJTYjNNQTRNUWhpRDVnRkhjekZFcjRHMTZYeE1Lckp0?=
 =?utf-8?B?RmQ1NTlnRXFGdS9KeVVMcnBvdFhZNTRhNDdYekZ3QjRpdzlOditCL2EwMkcx?=
 =?utf-8?B?K3NnZGErMHZTQ0IvUU5kNEFRaGlYb0tsYldMekI2cFlGREc2U2lhQjZINVhT?=
 =?utf-8?B?MlpUR3RNbFZzWTNzSHl3eVZtcXhqZFJBcTRZVnkzMk5sZWozdUZDODdMclow?=
 =?utf-8?B?N2ZKUGNFSHdKbUFBSHd3OTJkMmw2S2lKTEdZNXdOWGpvKzFaOGE2ZlI1MkF0?=
 =?utf-8?B?MHg0MTJUREphblFIa1pmRXJTcmhFUHRFN0Yrb2Q3djNvN0M1VkxMU3lPN0dT?=
 =?utf-8?B?bG5OdzZTbTlPQXpka2RiQkpTbnh5OFZxZnNPOXhvNVBhYko0OW9LUzFUYUdt?=
 =?utf-8?B?MnR6NmswWXdmVW9aYmdFOWFMcjFoVGNWb3hlSXl0Z0N1aGJXaHdqQ1hGdktj?=
 =?utf-8?B?MWMxSzdSYTJoZEZpQjNtZUhwb1NvdnlZQjNTMCt0bWl3a1dGK21nZFNscXIw?=
 =?utf-8?B?TFBNdmRsRGR5MTlJR1V3em5hUVpVOXB1VGtGMXFIK1pYWFF6bC9oeERtdXBo?=
 =?utf-8?B?QlkxT3pFa256TVB1VXdxYzlvaXp4QUFrU0ZHNElCZE5Kd2UvUCtSdDc5dzlW?=
 =?utf-8?B?ckFsTHoyUlJGbnlRNHBoY3BKWms2Vi9IZmZQclNLNk1UZWhzODEyYzlGSnow?=
 =?utf-8?B?K2dTb0VJenZsWW1pUFQvRHE3NHkvQnlkSTEzQTJpVHdVenlpamJjL0haU3pG?=
 =?utf-8?B?UXFmVXIwa1RvTkhtczVQOWxiL2VqV3lFS3NZUlBnQlVPcHJvaDdwNVdnUHMw?=
 =?utf-8?B?b29idGExZThvTVEvNitsdC9EWmthTGl5NmJOai9qQXBYRXVUZE45TkFpNEw0?=
 =?utf-8?B?aTd4OW5WR1J6akRyS3VlNWtpUGh1d1Z2RlA4WkpLS0hlcFROUHpFNXJWZUti?=
 =?utf-8?B?d3NIaWc3UjVwRjRJMGk5bVQwL2VVNVB5dWRWeWVsZGlQbWR1WXkzUnJZa2ZF?=
 =?utf-8?B?d2Y1UTV1ZlQwTmlaZGtHWEVPMzhodHBmVm9TTGVMaHRONDZ4UWJGeDBXcndR?=
 =?utf-8?B?MmJTUVhXY1V1K0UydWZteHNPSHlUZDBnZUF0YjZIdVNIYm1SYi9HSzVKSXo5?=
 =?utf-8?B?ME42bVh5MDRxWC93SnhSMUp0cTRvZm4yNGsvRFFpTGd0SmlkVTBpMHp4czJy?=
 =?utf-8?B?MUJLckEyc3E5OWFLajlwVmRtSXJDTTl3a1BvMmlHY3pqaFRNamFJcVE3c3lh?=
 =?utf-8?B?ZnNCVlpLb1cwWmdmaEN0Z2lJS29xQ0F1dG12YUV2REk2TE1JcDhWd0I4RDRx?=
 =?utf-8?B?S2UwRmhvMFR5bDV5WE1LbkVuWmttUjJYOGxNUGpZUWU5V3lCVGZBUFMydGtE?=
 =?utf-8?B?YWFXTk83cUR1R25vOTA3RVgvMjlXUW16b1ZlZXlpSmluSGtzbTlIaVVRZzM5?=
 =?utf-8?B?eHhKRld3MzBIdzJiR3cvYUpoaUE4cDNtSVNNRjBaOW1wTUphbjJqTHVIay9y?=
 =?utf-8?B?d0F5dUJUMW5sRTZ3YTFGeFEzVXBYaVQzQ3dOeFdIR1ladDQ4NUs4M0xHTE5q?=
 =?utf-8?B?RGFpOFJFTEdVeW9MQ3laTGd1cXN6RzVNdU1JYm1JV2dWODVQa0kyazhTU21Y?=
 =?utf-8?B?c2xJWXROY2EwTDVLSGlWNFZEcDQxNEFUcGMyVlcyeDVtMWozdGI0bEpLeHda?=
 =?utf-8?B?SFhYR3BlbHJEcHVNa09aWG1VYVVRSlBWMitEWDduci9lZ1UzTExBQVJHWTZW?=
 =?utf-8?B?andHNk9aV3pzeXNtZlhIRFQ5MHBPNERheDZVTlBQQVpWSkI5VnFsZHp1ZlVX?=
 =?utf-8?B?WEo0TEN4a2FPVGVCOG9aQU8vMnl5UmNTSmROa2RYZlMrUHg4eWwvYlN5NTN2?=
 =?utf-8?B?RVo5RUZVTVNvOTFCSTE1K09UUk9YMkhoV0pIM0xYa1Z5U1Nrdmw3U2tITW1P?=
 =?utf-8?Q?6LsjtV1EvatgYwFVRVsv5BZjp?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a9f20dc-b1bc-4b5d-73f4-08dbd6ce6579
X-MS-Exchange-CrossTenant-AuthSource: KL1PR03MB5732.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2023 09:23:37.2252
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2Hx0owUTVc5wyOqlu8WmXp4IDsRsB9NrNx9ezC+C+b+Wbab6t3/ve551Dwiie5nkMUshUQuby+gVBClRXJv6kg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR03MB5729
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 27 Oct 2023 02:24:11 -0700 (PDT)

Hello YiXun，
  CLK config has been separated on HW. No more in pwmchip.
And s4 datasheet about clk updated already.

On 2023/10/24 3:40, George Stark wrote:
> [你通常不会收到来自 gnstark@salutedevices.com 的电子邮件。请访问 
> https://aka.ms/LearnAboutSenderIdentification，以了解这一点为什么很重要]
> 
> [ EXTERNAL EMAIL ]
> 
> Hello Yixun Lan
> 
> On 10/17/23 01:37, Yixun Lan wrote:
>> Hi JunYi
>>
>> On 13:24 Mon 16 Oct     , JunYi Zhao wrote:
>>> From: "junyi.zhao" <junyi.zhao@amlogic.com>
>>>
>>> Support PWM for S4 soc.
>>> Now the PWM clock input is done in independent CLKCTRL registers.
>>> And no more in the PWM registers.
>>> PWM needs to obtain an external clock source.
>>>
>>> Signed-off-by: junyi.zhao <junyi.zhao@amlogic.com>
>>> ---
>>> V2 -> V3:
>>> Rebase and Review the latest upstream code again.
>>> After reconstruction, stick to the previous code as much as possible.
>>>   drivers/pwm/pwm-meson.c | 19 +++++++++++++++++++
>>>   1 file changed, 19 insertions(+)
>>>
>>> diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c
>>> index 25519cddc2a9..fe9fd75747c4 100644
>>> --- a/drivers/pwm/pwm-meson.c
>>> +++ b/drivers/pwm/pwm-meson.c
>>> @@ -99,6 +99,7 @@ struct meson_pwm_channel {
>>>   struct meson_pwm_data {
>>>      const char * const *parent_names;
>>>      unsigned int num_parents;
>>> +    unsigned int extern_clk;
>>>   };
>>>
>>>   struct meson_pwm {
>>> @@ -396,6 +397,10 @@ static const struct meson_pwm_data 
>>> pwm_g12a_ao_cd_data = {
>>>      .num_parents = ARRAY_SIZE(pwm_g12a_ao_cd_parent_names),
>>>   };
>>>
>>> +static const struct meson_pwm_data pwm_s4_data = {
>>> +    .extern_clk = true,
>>> +};
>>> +
>>>   static const struct of_device_id meson_pwm_matches[] = {
>>>      {
>>>              .compatible = "amlogic,meson8b-pwm",
>>> @@ -429,6 +434,10 @@ static const struct of_device_id 
>>> meson_pwm_matches[] = {
>>>              .compatible = "amlogic,meson-g12a-ao-pwm-cd",
>>>              .data = &pwm_g12a_ao_cd_data
>>>      },
>>> +    {
>>> +            .compatible = "amlogic,s4-pwm",
>>> +            .data = &pwm_s4_data,
>>> +    },
>>>      {},
>>>   };
>>>   MODULE_DEVICE_TABLE(of, meson_pwm_matches);
>>> @@ -451,6 +460,16 @@ static int meson_pwm_init_channels(struct 
>>> meson_pwm *meson)
>>>              struct clk_parent_data div_parent = {}, gate_parent = {};
>>>              struct clk_init_data init = {};
>>>
>>> +            if (meson->data->extern_clk) {
>>> +                    snprintf(name, sizeof(name), "clkin%u", i);
>>> +                    channel->clk = devm_clk_get(dev, name);
>> use devm_clk_get_optional() which would save you from introducing
>> the 'extern_clk' variable
> 
> On S4 and other recent chips PWM clock resides in separate IP and it
> must be provided to driver in order to control PWM frequency. So this
> clock is not optional.
> 
>>
>>> +                    if (IS_ERR(channel->clk)) {
>>> +                            dev_err(meson->chip.dev, "can't get 
>>> device clock\n");
>>> +                            return PTR_ERR(channel->clk);
>>> +                    }
>>> +                    continue;
>>> +            }
>>> +
>>>              snprintf(name, sizeof(name), "%s#mux%u", dev_name(dev), i);
>>>
>>>              init.name = name;
>>>
>>> base-commit: 4d2c646ac07cf4a35ef1c4a935a1a4fd6c6b1a36
>>> -- 
>>> 2.41.0
>>>
>>>
>>> _______________________________________________
>>> linux-amlogic mailing list
>>> linux-amlogic@lists.infradead.org
>>> http://lists.infradead.org/mailman/listinfo/linux-amlogic
>>
> 
> -- 
> Best regards
> George