Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp1025167rdh; Fri, 27 Oct 2023 02:29:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFH9bTSLdFrcq7G5BMMYhlQd5DAS7Gv2PQDLS8yNd3+0r0kXpxOVfrYZ0dBlS7ziUb1qpKo X-Received: by 2002:a05:6902:1083:b0:da0:5370:fdce with SMTP id v3-20020a056902108300b00da05370fdcemr2442590ybu.19.1698398994125; Fri, 27 Oct 2023 02:29:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698398994; cv=none; d=google.com; s=arc-20160816; b=FhXo89pQothVTbOwVJACWgNavZuTr+pgOwIYhmGK1E9KPlbCkXBy9Fa8Ou5L+rx/DK 4Zcomf9v8yGca5Qp5vqGek3lQZEmcfcWSnc7xlW3qzy+80hQ0MerF4xBgLOmVIucsrrq zksEjqqVAL1TKfWmuDGCrhzkF6eICCq8Xsn5k8OpPXUZ4hQnNthkAQTMO1MHtuRVrfZK MT3qe+w0qaHi/weKRcUrJM17mntukU1G2Ru+Q9b8KmfoN3Y9gPMlusoR6p0gnuM7x5FN oEbuqQPg+Tv/CGD4+ay/f/TtTrat2ghPN2tLGkyaQqTppVOB/R8Khn1GCuWFXXGubXY6 tjTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:date:to:content-transfer-encoding :message-id:from:cc:subject:dkim-signature; bh=TV5y0friYH6HbXqokPo9rMztc3feSByAfx6Q6GDDtx0=; fh=sH6KV+jaA7dtdurwqyurCBB9yOlYRIJldwvsciKpl8U=; b=TOkZvAi+4ytHSOPy5fPMmylRB2R1G3ibXn0PWnq8ExCzb2KCk23S9tyKe6M8JKI/8f qa4s2uwpOd+RpIIRqUf6YrwJwk/MnMprX0QhhPDoKJMdTb+P2hJc/5pydQrdhuS0pNRb G81WmqM7fCEwjEBKlmxmch0OD+KNJ8NxUbpz4thLOEX/4FXDqvbWDUJn8Tt67FWH2XZM DrTYRpdkXGVMIJVgS7XwZS7x4AuBE/+X5xNvWzZLJ+uBAxAuL8tK3kC9nAhuj/gzIbW9 Lgrm8hBtEpNqyAOAsPSNTxmvdUeFSAiyuLEvuLcqH+S/tbIl+gf4hrJlSjTqa4ib6qP0 i9Tg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@dingdao-com.20200927.dkim.feishu.cn header.s=s1 header.b=t8dCWO16; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id 2-20020a251502000000b00d9acbe274fbsi1828861ybv.538.2023.10.27.02.29.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Oct 2023 02:29:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@dingdao-com.20200927.dkim.feishu.cn header.s=s1 header.b=t8dCWO16; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id D0ED482DD0A5; Fri, 27 Oct 2023 02:29:52 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231386AbjJ0J3r (ORCPT + 99 others); Fri, 27 Oct 2023 05:29:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbjJ0J3n (ORCPT ); Fri, 27 Oct 2023 05:29:43 -0400 X-Greylist: delayed 606 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 27 Oct 2023 02:29:40 PDT Received: from s01.bc.larksuite.com (s01.bc.larksuite.com [209.127.230.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCD9AAF for ; Fri, 27 Oct 2023 02:29:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=s1; d=dingdao-com.20200927.dkim.feishu.cn; t=1698398370; h=from:subject:mime-version:from:date:message-id:subject:to:cc: reply-to:content-type:mime-version:in-reply-to:message-id; bh=TV5y0friYH6HbXqokPo9rMztc3feSByAfx6Q6GDDtx0=; b=t8dCWO16iW+U4zgIxZbRsNc/FJKvjfXlglhcPPOsNMmWwH1gt92vhnMrmx34M/dG+/aQkc 24UXLNZrFCAkNDYN8HztMQNONHPwsqrakm7Iw7tKi5bqM8fctfNFreexE/RkiBoMVNmsSJ 2byTCFfaqiuttwn5j2bUE3o4L22Pf/1sFRwswyizetMu7/7Gjqnqb06jpk4JakaBXMzAVu e546m8lmJHJ225+JJTuQXX2UOvEo72wzLP0x2NmZfOOVfvhl1vEgHYjKWSEN4Sndo0B4yn upf0PdrYPmJtVg9BWYGJbRf+bZdha888lY/bbdSiXqj5z9yiE6x5Ok4YjZXCpg== Subject: [PATCH] gpu/drm/drm_framebuffer.c: Add judgement for return value of drm_get_format_info(). X-Original-From: Peng Hao Cc: , , From: "Peng Hao" X-Lms-Return-Path: Message-Id: <20231027091912.1244107-1-penghao@dingdao.com> Content-Transfer-Encoding: 7bit To: , , , , Content-Type: text/plain; charset=UTF-8 X-Mailer: git-send-email 2.37.1 Date: Fri, 27 Oct 2023 17:19:12 +0800 Mime-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 27 Oct 2023 02:29:53 -0700 (PDT) Since drm_get_format_info() may return NULL, so a judgement of return value is needed to add. Signed-off-by: Peng Hao --- drivers/gpu/drm/drm_framebuffer.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/drm_framebuffer.c b/drivers/gpu/drm/drm_framebuffer.c index aff3746dedfb..be7dd1998c04 100644 --- a/drivers/gpu/drm/drm_framebuffer.c +++ b/drivers/gpu/drm/drm_framebuffer.c @@ -194,6 +194,10 @@ static int framebuffer_check(struct drm_device *dev, /* now let the driver pick its own format info */ info = drm_get_format_info(dev, r); + if (!info) { + drm_dbg_kms(dev, "no matched format info\n"); + return -EFAULT; + } for (i = 0; i < info->num_planes; i++) { unsigned int width = fb_plane_width(r->width, info, i); -- 2.37.1