Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <46cbc7d8-7d1b-4307-95b2-d8f62dd57824@intel.com>
Date:   Fri, 27 Oct 2023 12:09:35 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net v1 2/2] octeontx2-pf: Fix holes in error code
Content-Language: en-US
To:     Ratheesh Kannoth <rkannoth@marvell.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     <sgoutham@marvell.com>, <gakula@marvell.com>,
        <sbhatta@marvell.com>, <hkelam@marvell.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>
References: <20231027021953.1819959-1-rkannoth@marvell.com>
 <20231027021953.1819959-2-rkannoth@marvell.com>
From:   Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <20231027021953.1819959-2-rkannoth@marvell.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ako0L3JWODVMNUFYS0R4Z0FWREdTaERqbUpZdUtWNDBVNCs5K2lXMUhEYUZH?=
 =?utf-8?B?TnZkOHdzWk11QncvSEUrUE1qWVJqVXNoeWdYWXRRaTNlcHhxQ21FeWxmWkNB?=
 =?utf-8?B?NDBnOUtDaEcyL3VEaEFxVWNrNHBlVXpnY3BaMC81VzluMS9FOWF2SEs2cDdC?=
 =?utf-8?B?OXZha0Fsb3FlSVFzd0FHMEFzTTR5ZU5JMklzRWVxcTNnVFRZZWhkZlRnZHkz?=
 =?utf-8?B?aGlqTlppYXdjaTBvOCtVa2Mxam1vQjIwSnAyU0pHOXV2Q2d2UFMxalJFNjc1?=
 =?utf-8?B?RFlobkJoSkF0UGM3UkpYMFhiQzE0SWxqSDdwMTF3S0RLY3ZRT0VUdEYyQk9M?=
 =?utf-8?B?blZyVndBd3c0ZHRoZWdqSjNyWHVxRTc4Mlc3OVdaa3o0Tm5yRTNmeEs5S1Fs?=
 =?utf-8?B?ck1kNnNGaUFpZ3ZQTXFlYnQrWSt2NGp0YklNbTNYTmNZOEZaQ3BVMFRHNUZM?=
 =?utf-8?B?Ym5CRUVvcC8yS3hqVXBOWVNWczd3ZklwUUVXQmlhdzJaQkk0dGtYRVJBZlFF?=
 =?utf-8?B?blpRaEZRT0lBQWJJNzFqeDloM1B6MnVNVHJLZ1d1dnBCY1ZhbzlOMlcyTDJh?=
 =?utf-8?B?V1l5OVA5VTUyTVVqMlpBcldZOEc3VHNoVERQbjdnUm0wSDBDaE5jdUY3NmlO?=
 =?utf-8?B?ZSs2Y0VxQWFxUWlTcmUydmxsZTdyc0o1eC8vMEIvMnEvVjZ4eCtTUHd4cFhI?=
 =?utf-8?B?N1JyQW1FN05MR2IwTE9veng0TmF2b01jZGJBQ1pMNHZoRlhmellUeHNiQjNr?=
 =?utf-8?B?SDBMRkZJeFAyN1lYRGlUY2oxeUdEbkVISnpieGViTGZSSzcyWmpxTTBIM0tq?=
 =?utf-8?B?SGg3ZnN1R1VHZkV5QjYvb3d1b2pqWlpqZGNBdTFNMkU5OEVpcGovekpUMk9w?=
 =?utf-8?B?VitIUEhPd1M0Nzl6SnczNGl3MGFLVVhhczk4M2wwd3ZnQWRqek5WVmF2djJp?=
 =?utf-8?B?bmdua1hycDZheXNKUXJRYTc4cEF4aXpZUnZiRFZVRVh0ZlJ0MVBjUHhBSURx?=
 =?utf-8?B?cWU5WkdlSnpHcEh5ODBXZGYya3NKeG5OK3gvbjBreERUQlVNNTdFRkpEc0NT?=
 =?utf-8?B?YVc2blNDcTZpcEd3dC9HdVNxVlVEeENoZzZ2dzBBcHRRK0JOMi9yZTFGL3pk?=
 =?utf-8?B?elUrS0xZUHBUMEwyRWRmNmxKcXRQNDQxQWlObzYzM3pKc04yQzdXRThXaC81?=
 =?utf-8?B?RzRlcUx4R1V6WkRuemVKRitBbWpYNzFRSUtRdUVuRUF6SVpLNE9wMTJaVlZa?=
 =?utf-8?B?djNlZmtWT0Q2Sjgxa2t2akM4V21Oc3JZVWd5c3g0ODJDOTFqOVhVbkI0a2Zn?=
 =?utf-8?B?emhJQU1aL2hqd0N4R1V5elZXR2dlTmt6TlRMSUFVUWRJdUJTRHFTVzNLcmtE?=
 =?utf-8?B?bG80VnE2aGRHMjI2cmRYK0R0VndGUDFZVFVJZzhDck1Wb2YyZUJhUUorVk45?=
 =?utf-8?B?ZVFrWG1nU050RTZ3WmVWMXBsSG9IL3l4dHBXeURPUlNwSFVJYzg2N0h0MUF6?=
 =?utf-8?B?OTViSWJGTTdoYVRvamRBZW16d3A5cFJrUkk3YVJWeUMwSjFOeUw0SDg0WEZY?=
 =?utf-8?B?U0RYWkJQSzVGQ0QrN2prT21EeERRSjhzMk9DMEpUbVFFeWRicWNmVk9Oc3lm?=
 =?utf-8?B?YS91ejl0Y0UvN2FtbDExbUtWMG5yUFdNemhoT2xYUEpZRmhJd0ZoNTZFMC9I?=
 =?utf-8?B?ZlNwVnViVEhudUVhVmY3c3JEQlZ2YW1jdEdWTFZLMlRqcjI1V2haRU5NMVBF?=
 =?utf-8?B?aGo3SnhkWWVpMUozQ3RtUG1vQTR4MDZzRWJxSUJRMnNBOVJLL3d2ZHJiQzR6?=
 =?utf-8?B?djJ6dGt4U0szTmVWaDgvSlY3Y0c3b3hvT2ZHb3MvWW9xWDZLamJ0cUdYTGVI?=
 =?utf-8?B?WEE3VWFsSDUzNTJGSEJqV0hWckpqdFpEZVVpVXpRZElLUWNhU0hXeGdoalNP?=
 =?utf-8?B?dFVvcUxtOWxxREswU3dRbDlBZXFCL3p5Y3VQSW1MN0Y3LzBQQ0ZvZ0RmYmFT?=
 =?utf-8?B?Uk9MMmpFRlJ4MmowQVRBdmNSbzFGNkJ4OS9qOHlCTWp6TjVmVTdENExDWGlo?=
 =?utf-8?B?TlY3WkZTbEdlbXJQRzhwV1orUkVFeE9iM2JsdzUvN1R4RHJqNjNLK2RNeCto?=
 =?utf-8?B?dG5KZldnVDZ1T21zaHBNeHVGSEEyUklvWmNQUVY4a2dUZXpoTGd0dFcvUmVP?=
 =?utf-8?B?Mnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 435d1a40-fc53-4076-f32d-08dbd6d4d673
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2023 10:09:42.4861
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FWzKHMQ7d0a9bfgEjLzlc5nN5cPdo85JwBih6BcERiDJaSpqfAmWnRO/J6vo//LXG4N6Gy6UbZ+VyP+s/xHs0WZWSKsFHzjWJpkpA/OqmU0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6667
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UPPERCASE_50_75,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 27 Oct 2023 03:10:06 -0700 (PDT)


On 27.10.2023 04:19, Ratheesh Kannoth wrote:
> Error code strings are not getting printed properly
> due to holes. Print error code as well.
> 
> Fixes: 51afe9026d0c ("octeontx2-pf: NIX TX overwrites SQ_CTX_HW_S[SQ_INT]")
> Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>

Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>

> 
> ---
> ChangeLog:
> 
> v0 -> v1: Splitted patch into two
> ---
>  .../ethernet/marvell/octeontx2/nic/otx2_pf.c  | 80 +++++++++++--------
>  1 file changed, 46 insertions(+), 34 deletions(-)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> index 6daf4d58c25d..125fe231702a 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> @@ -1193,31 +1193,32 @@ static char *nix_mnqerr_e_str[NIX_MNQERR_MAX] = {
>  };
>  
>  static char *nix_snd_status_e_str[NIX_SND_STATUS_MAX] =  {
> -	"NIX_SND_STATUS_GOOD",
> -	"NIX_SND_STATUS_SQ_CTX_FAULT",
> -	"NIX_SND_STATUS_SQ_CTX_POISON",
> -	"NIX_SND_STATUS_SQB_FAULT",
> -	"NIX_SND_STATUS_SQB_POISON",
> -	"NIX_SND_STATUS_HDR_ERR",
> -	"NIX_SND_STATUS_EXT_ERR",
> -	"NIX_SND_STATUS_JUMP_FAULT",
> -	"NIX_SND_STATUS_JUMP_POISON",
> -	"NIX_SND_STATUS_CRC_ERR",
> -	"NIX_SND_STATUS_IMM_ERR",
> -	"NIX_SND_STATUS_SG_ERR",
> -	"NIX_SND_STATUS_MEM_ERR",
> -	"NIX_SND_STATUS_INVALID_SUBDC",
> -	"NIX_SND_STATUS_SUBDC_ORDER_ERR",
> -	"NIX_SND_STATUS_DATA_FAULT",
> -	"NIX_SND_STATUS_DATA_POISON",
> -	"NIX_SND_STATUS_NPC_DROP_ACTION",
> -	"NIX_SND_STATUS_LOCK_VIOL",
> -	"NIX_SND_STATUS_NPC_UCAST_CHAN_ERR",
> -	"NIX_SND_STATUS_NPC_MCAST_CHAN_ERR",
> -	"NIX_SND_STATUS_NPC_MCAST_ABORT",
> -	"NIX_SND_STATUS_NPC_VTAG_PTR_ERR",
> -	"NIX_SND_STATUS_NPC_VTAG_SIZE_ERR",
> -	"NIX_SND_STATUS_SEND_STATS_ERR",
> +	[NIX_SND_STATUS_GOOD] = "NIX_SND_STATUS_GOOD",
> +	[NIX_SND_STATUS_SQ_CTX_FAULT] = "NIX_SND_STATUS_SQ_CTX_FAULT",
> +	[NIX_SND_STATUS_SQ_CTX_POISON] = "NIX_SND_STATUS_SQ_CTX_POISON",
> +	[NIX_SND_STATUS_SQB_FAULT] = "NIX_SND_STATUS_SQB_FAULT",
> +	[NIX_SND_STATUS_SQB_POISON] = "NIX_SND_STATUS_SQB_POISON",
> +	[NIX_SND_STATUS_HDR_ERR] = "NIX_SND_STATUS_HDR_ERR",
> +	[NIX_SND_STATUS_EXT_ERR] = "NIX_SND_STATUS_EXT_ERR",
> +	[NIX_SND_STATUS_JUMP_FAULT] = "NIX_SND_STATUS_JUMP_FAULT",
> +	[NIX_SND_STATUS_JUMP_POISON] = "NIX_SND_STATUS_JUMP_POISON",
> +	[NIX_SND_STATUS_CRC_ERR] = "NIX_SND_STATUS_CRC_ERR",
> +	[NIX_SND_STATUS_IMM_ERR] = "NIX_SND_STATUS_IMM_ERR",
> +	[NIX_SND_STATUS_SG_ERR] = "NIX_SND_STATUS_SG_ERR",
> +	[NIX_SND_STATUS_MEM_ERR] = "NIX_SND_STATUS_MEM_ERR",
> +	[NIX_SND_STATUS_INVALID_SUBDC] = "NIX_SND_STATUS_INVALID_SUBDC",
> +	[NIX_SND_STATUS_SUBDC_ORDER_ERR] = "NIX_SND_STATUS_SUBDC_ORDER_ERR",
> +	[NIX_SND_STATUS_DATA_FAULT] = "NIX_SND_STATUS_DATA_FAULT",
> +	[NIX_SND_STATUS_DATA_POISON] = "NIX_SND_STATUS_DATA_POISON",
> +	[NIX_SND_STATUS_NPC_DROP_ACTION] = "NIX_SND_STATUS_NPC_DROP_ACTION",
> +	[NIX_SND_STATUS_LOCK_VIOL] = "NIX_SND_STATUS_LOCK_VIOL",
> +	[NIX_SND_STATUS_NPC_UCAST_CHAN_ERR] = "NIX_SND_STAT_NPC_UCAST_CHAN_ERR",
> +	[NIX_SND_STATUS_NPC_MCAST_CHAN_ERR] = "NIX_SND_STAT_NPC_MCAST_CHAN_ERR",
> +	[NIX_SND_STATUS_NPC_MCAST_ABORT] = "NIX_SND_STATUS_NPC_MCAST_ABORT",
> +	[NIX_SND_STATUS_NPC_VTAG_PTR_ERR] = "NIX_SND_STATUS_NPC_VTAG_PTR_ERR",
> +	[NIX_SND_STATUS_NPC_VTAG_SIZE_ERR] = "NIX_SND_STATUS_NPC_VTAG_SIZE_ERR",
> +	[NIX_SND_STATUS_SEND_MEM_FAULT] = "NIX_SND_STATUS_SEND_MEM_FAULT",
> +	[NIX_SND_STATUS_SEND_STATS_ERR] = "NIX_SND_STATUS_SEND_STATS_ERR",
>  };
>  
>  static irqreturn_t otx2_q_intr_handler(int irq, void *data)
> @@ -1238,14 +1239,16 @@ static irqreturn_t otx2_q_intr_handler(int irq, void *data)
>  			continue;
>  
>  		if (val & BIT_ULL(42)) {
> -			netdev_err(pf->netdev, "CQ%lld: error reading NIX_LF_CQ_OP_INT, NIX_LF_ERR_INT 0x%llx\n",
> +			netdev_err(pf->netdev,
> +				   "CQ%lld: error reading NIX_LF_CQ_OP_INT, NIX_LF_ERR_INT 0x%llx\n",
>  				   qidx, otx2_read64(pf, NIX_LF_ERR_INT));
>  		} else {
>  			if (val & BIT_ULL(NIX_CQERRINT_DOOR_ERR))
>  				netdev_err(pf->netdev, "CQ%lld: Doorbell error",
>  					   qidx);
>  			if (val & BIT_ULL(NIX_CQERRINT_CQE_FAULT))
> -				netdev_err(pf->netdev, "CQ%lld: Memory fault on CQE write to LLC/DRAM",
> +				netdev_err(pf->netdev,
> +					   "CQ%lld: Memory fault on CQE write to LLC/DRAM",
>  					   qidx);
>  		}
>  
> @@ -1272,7 +1275,8 @@ static irqreturn_t otx2_q_intr_handler(int irq, void *data)
>  			     (val & NIX_SQINT_BITS));
>  
>  		if (val & BIT_ULL(42)) {
> -			netdev_err(pf->netdev, "SQ%lld: error reading NIX_LF_SQ_OP_INT, NIX_LF_ERR_INT 0x%llx\n",
> +			netdev_err(pf->netdev,
> +				   "SQ%lld: error reading NIX_LF_SQ_OP_INT, NIX_LF_ERR_INT 0x%llx\n",
>  				   qidx, otx2_read64(pf, NIX_LF_ERR_INT));
>  			goto done;
>  		}
> @@ -1282,8 +1286,11 @@ static irqreturn_t otx2_q_intr_handler(int irq, void *data)
>  			goto chk_mnq_err_dbg;
>  
>  		sq_op_err_code = FIELD_GET(GENMASK(7, 0), sq_op_err_dbg);
> -		netdev_err(pf->netdev, "SQ%lld: NIX_LF_SQ_OP_ERR_DBG(%llx)  err=%s\n",
> -			   qidx, sq_op_err_dbg, nix_sqoperr_e_str[sq_op_err_code]);
> +		netdev_err(pf->netdev,
> +			   "SQ%lld: NIX_LF_SQ_OP_ERR_DBG(0x%llx)  err=%s(%#x)\n",
> +			   qidx, sq_op_err_dbg,
> +			   nix_sqoperr_e_str[sq_op_err_code],
> +			   sq_op_err_code);
>  
>  		otx2_write64(pf, NIX_LF_SQ_OP_ERR_DBG, BIT_ULL(44));
>  
> @@ -1300,16 +1307,21 @@ static irqreturn_t otx2_q_intr_handler(int irq, void *data)
>  			goto chk_snd_err_dbg;
>  
>  		mnq_err_code = FIELD_GET(GENMASK(7, 0), mnq_err_dbg);
> -		netdev_err(pf->netdev, "SQ%lld: NIX_LF_MNQ_ERR_DBG(%llx)  err=%s\n",
> -			   qidx, mnq_err_dbg,  nix_mnqerr_e_str[mnq_err_code]);
> +		netdev_err(pf->netdev,
> +			   "SQ%lld: NIX_LF_MNQ_ERR_DBG(0x%llx)  err=%s(%#x)\n",
> +			   qidx, mnq_err_dbg,  nix_mnqerr_e_str[mnq_err_code],
> +			   mnq_err_code);
>  		otx2_write64(pf, NIX_LF_MNQ_ERR_DBG, BIT_ULL(44));
>  
>  chk_snd_err_dbg:
>  		snd_err_dbg = otx2_read64(pf, NIX_LF_SEND_ERR_DBG);
>  		if (snd_err_dbg & BIT(44)) {
>  			snd_err_code = FIELD_GET(GENMASK(7, 0), snd_err_dbg);
> -			netdev_err(pf->netdev, "SQ%lld: NIX_LF_SND_ERR_DBG:0x%llx err=%s\n",
> -				   qidx, snd_err_dbg, nix_snd_status_e_str[snd_err_code]);
> +			netdev_err(pf->netdev,
> +				   "SQ%lld: NIX_LF_SND_ERR_DBG:0x%llx err=%s(%#x)\n",
> +				   qidx, snd_err_dbg,
> +				   nix_snd_status_e_str[snd_err_code],
> +				   snd_err_code);
>  			otx2_write64(pf, NIX_LF_SEND_ERR_DBG, BIT_ULL(44));
>  		}
>