Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Fri, 27 Oct 2023 18:10:47 +0800
From:   Crescent CY Hsieh <crescentcy.hsieh@moxa.com>
To:     Jiri Slaby <jirislaby@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 2/2] tty: serial: 8250: Add support for MOXA PCIe boards
 to switch interface
Message-ID: <ZTuMp/S0uQ9I6lGp@moxa-ThinkCentre-M90t>
References: <20231027062440.7749-1-crescentcy.hsieh@moxa.com>
 <20231027062440.7749-3-crescentcy.hsieh@moxa.com>
 <37a5e055-93b5-4f05-bcca-4caa5ed6f97f@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <37a5e055-93b5-4f05-bcca-4caa5ed6f97f@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?d+FRd9yHKvgNJgXb5VQD+Z79e/NEfev7B/2S4DKYBBEhuuWdXxgQ2d7g0+qm?=
 =?us-ascii?Q?ZDZCVU+C6KIG2WDuMSPZvrsmcluD100gUsQnJvUC7rY2n+p2nQFX22Ad7E6g?=
 =?us-ascii?Q?SebphxKIrJ/STEgceVB6IvlKgCJqoZJVUYwanfSAtA6fF1mC135CJ0Hu/YT2?=
 =?us-ascii?Q?2z1AO7orqmYrpJNSBKO+3gHuaq8TbaGD8TatHA9STvXDbtGvY0O82HzJ/o+N?=
 =?us-ascii?Q?Jhfw9488gXnP+UxOfobYGI19cMEsgrolEfIRXE8yWw/nyFIVPlwYwpoGiUeX?=
 =?us-ascii?Q?L0HI/EIPUSkZS8dMmfx/1P8RJKQB7ZhsxgI3xkVCGoalVn8ovDzmSUhLhktH?=
 =?us-ascii?Q?hnNy4ABxollXivnfCJcIywtG3qcdPqnsVNH7EiMqBOrsphwHKGB17k56/Nzh?=
 =?us-ascii?Q?BDj8v7Tfuaqg+ZjJc3UOgI2CHbL6bLpgiZsvn6tA5sDotqcN6hUW9G6cJVnp?=
 =?us-ascii?Q?3wwrcEy4mM8ZMIhahwWrIiDZxImPrce9Bx9bk9FOkvDAHT7tpvV83MGGDER1?=
 =?us-ascii?Q?ys2fetIa6AxjOy/sEsoeKqt+9TYzCMtp6dt3IHnq8UtqkYR9ba6eWYSFgHFK?=
 =?us-ascii?Q?I/cMoEuEXH0RK+B5YmKdnCidIu30B+meGb1ouwXD7IP5tY44079TS6C0AGYX?=
 =?us-ascii?Q?FjgwFvp9XvgiDBOpYN3CHJVNsmKr3ARlkBpNdrwBl4KHjLmHh4ta9goKD6Lm?=
 =?us-ascii?Q?6sV8ZG2YQbVvoZ0DbAzn3+hG5tBWJYobfTgs8E25qCURFWp5HuKg6oozHFfA?=
 =?us-ascii?Q?S5fhZ68Raiz2QKKqzfmDrA358KmtDqlXMpP2/Lx1KPqNqSA7VdWNUlfvNR2n?=
 =?us-ascii?Q?80GpjHJ7q8oheUptb7kkzbqbd4DvpcZg7XLW/4cW+Mob6f+lAn1I4Y19MUcN?=
 =?us-ascii?Q?rzVH1NhqqM8PybfXxeTgd1nZieEGdmTZotLMJCHPuWoDWNzlYvkpIxYD3jfH?=
 =?us-ascii?Q?oG1IhRqAXMULSK5E7+nJWIcKdmTOibNerSHYr8kRJ8vBKm8OI+KXrGxRVfn2?=
 =?us-ascii?Q?yoGztMm+/hkCRcNCsVR7ekVk9O7W6amiATrvZuZWx6zKp/5bKUQBNqIbNEr6?=
 =?us-ascii?Q?bkMwb1DiLzyOGy4uN8XBcC0cwIj79TZzCRGom9ZduPFRzUy0y/MCT5mPK+LG?=
 =?us-ascii?Q?4BshIBmSA7M4gTOcm7Vi4b4y2neAe1iCs68fYIJCv7RS0Mhi7sQoYKAtD6do?=
 =?us-ascii?Q?Vf3MWt+N/PINcRY+wxjDq69QXlkdKfh9pjgBcYMjYsjOBAHkvcej+VexO9OT?=
 =?us-ascii?Q?Sm58ghY8ikVfbWKLwQeCt2ZMjpivtVlZRAcN1YOFKTxTZY6OTskbtOVpn5H2?=
 =?us-ascii?Q?FEUyB9NgQk9HBkzEcmNQheO5366AmGaoQWP/s915yoapJMnqEv+gEIJaUEC5?=
 =?us-ascii?Q?SSaautedToHeJs+0rHdoyWAaJlDsWoBmu9DtsspnJdjX7Em3+rrzLWZb1lcq?=
 =?us-ascii?Q?/2KgOy8hiHlIhdzUyELrlvTt1vOkmzPXvrng1Q05XAOtupoP6leQgucObeQh?=
 =?us-ascii?Q?UBWYhCGhazQhBoh0ofYk6WyvJmX4xIwveCrjjXX6EQdc63yhJJgjCiIhL6aN?=
 =?us-ascii?Q?+GL+Txdn+aWIQVDuHY7lqMgxJxzKLmXYKpWD+PH2yLam2cGhVvmfEDSnItL1?=
 =?us-ascii?Q?yg=3D=3D?=
X-OriginatorOrg: moxa.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2229a05c-2fa7-455f-96bd-08dbd6d4fee9
X-MS-Exchange-CrossTenant-AuthSource: PUZPR01MB5405.apcprd01.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2023 10:10:50.3432
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5571c7d4-286b-47f6-9dd5-0aa688773c8e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qNai+Or7/LqW1qldeGn0YCjdnVELUgLfDgB6nHm/nr19N0goeax/Z6459UnOawKKvwSEsFAS3LbdQwZugApjmDFg27MackIyQLJxfbdTm2M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR01MB4599
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 27 Oct 2023 03:11:14 -0700 (PDT)

On Fri, Oct 27, 2023 at 10:29:38AM +0200, Jiri Slaby wrote:
> On 27. 10. 23, 8:24, Crescent CY Hsieh wrote:
> > MOXA PCIe boards have 4 serial interfaces and don't require additional
> > stuff to switch between interfaces:
> > 
> > - RS232
> > - RS422
> > - RS485_2W (half-duplex)
> > - RS485_4W (full-duplex)
> > 
> > By using ioctl command "TIOCRS485", it can switch between default
> > interface and RS485 if supported.
> > 
> > That means, for RS422/RS485 board, it can switch between RS422 and
> > RS485 by setting the flags within struct serial_rs485.
> > 
> > However, for the RS232/RS422/RS485 board, it can only switch between
> > RS232 and RS485, there's no flag for switching interface into RS422.
> > 
> > This patch adds a flag call "SER_RS422_ENALBED" in serial.h and modifies
> 
> It's not "ENALBED".
> 
> Anyway, I am afraid you have to split the patch into two:
> 1) add the flag and core support (but wait a bit for others if they agree
> with this approach)
> 2) add the support for moxa.

Agree, I will split this patch into two separate patches and only send
the patch for adding the flag and core support first.

---
Sincerely,
Crescent CY Hsieh