Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Fri, 27 Oct 2023 08:20:13 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     "Zhang, Tina" <tina.zhang@intel.com>
Cc:     Joerg Roedel <joro@8bytes.org>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        David Woodhouse <dwmw2@infradead.org>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        "Tian, Kevin" <kevin.tian@intel.com>,
        Nicolin Chen <nicolinc@nvidia.com>,
        Michael Shavit <mshavit@google.com>,
        Vasant Hegde <vasant.hegde@amd.com>
Subject: Re: [PATCH v10 1/6] iommu: Change kconfig around IOMMU_SVA
Message-ID: <20231027112013.GT3952@nvidia.com>
References: <20231027000525.1278806-1-tina.zhang@intel.com>
 <20231027000525.1278806-2-tina.zhang@intel.com>
 <ZTtixEgSkBI-TRro@8bytes.org>
 <MW5PR11MB5881E07803D25E3588FFABB789DCA@MW5PR11MB5881.namprd11.prod.outlook.com>
 <MW5PR11MB5881463F11D86198291EB52989DCA@MW5PR11MB5881.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <MW5PR11MB5881463F11D86198291EB52989DCA@MW5PR11MB5881.namprd11.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jWh/aNs+OSWDAlNHzSJ8OpKQtPR5RMu8N/SehMntYsSR2i264WMxuAVpdrqJ?=
 =?us-ascii?Q?zq1BY/6OEJFZRbu8QEVnRSwR4/b/TyDrKkz8MuDF0ohn7cwgDhLUtxpQJeCG?=
 =?us-ascii?Q?kQTeEWLTSC8BTXiMdIp9wC9d6V2Kji0jm9L413iF9AgnD3/Uzidy+WmVZewc?=
 =?us-ascii?Q?YDBwlSJ6z9hIhBy1me3ct/o04yIHc8FqwxBli+tPVGMVfdzOzj+lfNSNow7p?=
 =?us-ascii?Q?SgscmIzN5FPB16TnvuE9+qkKHnMYBXkkquf/M4qir8YAmIhKFxLu45bCPOLn?=
 =?us-ascii?Q?3Pjey3xt3DXWuIs6pto5grO5hzFH0GvpKvvjvrUqhNLVOVT7nku+ZHO/Td6f?=
 =?us-ascii?Q?+sYKoOxSmjE5ijYqMGb9ZR1nIZ1DU+qeipc3yT2CUdBbI8txQuY5CFG0NpOq?=
 =?us-ascii?Q?k8whuluXUNyF+DyDOpQuehEAAmIiK5qKTicVUINROnaMw6tzli1p4Ra+YhQ3?=
 =?us-ascii?Q?wsTbPaD5FQ1HYc/7ZNMCO5TKNMQ6SlDP6G36BJjLFLJ80XYHlhFxAiKdBzHL?=
 =?us-ascii?Q?Odnb3CCCYbM5jqKIby8IoAD9Gcy9YLjI0LbBe4C/vEejHmEHxARGbyDtdabX?=
 =?us-ascii?Q?vxU1ipawPowAAUmw9IqvQG+7sekNVQaytUHVmh5St4rh9ASZGCpRjXYUjjYt?=
 =?us-ascii?Q?/O75zZ9M/Lc9pI8uiEhAk2cUaRxNmSU+yiVvD+kHm4zhJwQm3sLEw7g7UHsr?=
 =?us-ascii?Q?RJBFikBi7KmXm8JlYm3z30tFedftQrK3/B81WAq6T3Ng9QECWjfaeoEM1ca6?=
 =?us-ascii?Q?zFIb/0skRYUwyzNdsWbrOrMo2eccauV++c0QcU75m8g+EUxP0ofES1fOlju6?=
 =?us-ascii?Q?2umPMGx5zbbakA8KOo9sRdektH1SkPBJ74/+TwQKyukM82aUuDKmI9e++32T?=
 =?us-ascii?Q?P+MHRJ3BzC+zorxBHgpUpJ44xSGvTx1IIGk4itX1J3xc3L7QC0OfYKGd7LTH?=
 =?us-ascii?Q?UNA3Z99O2HH+SrLl8xU35CaheD9KG4JmOHZQa0nv3Dyu8cuZuMbInShnv/BT?=
 =?us-ascii?Q?+ZHSr5uiRKayO7+0PsTGsgZsRUKpsmtsBhLzBTLsdi584Upazf/gz6RS7ZCw?=
 =?us-ascii?Q?4Ogx4MzIqZdIHGsn/HOTK68MbwKfTc2741qR2s/O1qN9sqB/WE8BxTUiTtbn?=
 =?us-ascii?Q?/ZgNWMY6DLqb7oeTM38iqH9TsmlC0wseFS25Y4HjEnQ1gXUlN6MHh8nolaf5?=
 =?us-ascii?Q?gu+6YlZe7lvOXqGk38wMneOB+Y3+pqt+SrEuv9xsB+sPUVua2A5AszugDPhh?=
 =?us-ascii?Q?FrwncVI/j8ZsddzRFDg4SA2iJbdgbXMOGocjubkVQPEQnL78i6JqOMjzXVvj?=
 =?us-ascii?Q?vilRQl8438t0vQXjWe5/jwwocVd7Ou6SvnEgMXvIKVsDod6KSz7cIQ+gpX6U?=
 =?us-ascii?Q?fFu1CVtVmHnU0kXaPm+1K2RXjVbZGmOxW8gA0ZliOAaXXssw12lF2LpdZ7iz?=
 =?us-ascii?Q?l2spU0zRPLoB4w30cDJC3Y93qqgRApoFSTBAgEfzazZxa2B6TSHbsFX89qbL?=
 =?us-ascii?Q?1i1yrN26nXtOlBsI3oIL/FhcL99Raqnzks2jlQe5e2MP7sibhvDiZ2w79JXV?=
 =?us-ascii?Q?2/+uFUwij3YPN2qHXG66Qj9MBE/1rz8Fk+LnauGV?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f59af3e8-bcf3-4b47-8389-08dbd6deb190
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2023 11:20:15.4371
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G2o5X7x3waHD72R/mdJCAmvLTswTTNZ7vjRB/Xf6UOXEdpJaHbBtdj4bjPV/ZeUP
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7722
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 27 Oct 2023 04:20:30 -0700 (PDT)

On Fri, Oct 27, 2023 at 09:14:17AM +0000, Zhang, Tina wrote:
> > > On Fri, Oct 27, 2023 at 08:05:20AM +0800, Tina Zhang wrote:
> > > > From: Jason Gunthorpe <jgg@nvidia.com>
> > > >
> > > > Linus suggested that the kconfig here is confusing:
> > >
> > > While this patch looks decent to me, you forgot to Cc Linus on it. In
> > > general, given that it touches a couple of core files, I'd like to
> > > wait for some more people to have a look at it and not rushing anything in.
> > Make sense. I'll CC Linus. Comments are welcome.

> Can we separate this patch? I'm thinking about CC more people for
> review. At least, we need to CC all the reviewers of
> https://lore.kernel.org/all/20230506133134.1492395-1-jacob.jun.pan@linux.intel.com/
> to this patch. So, it seems more reasonable to separate this
> patch. What do you think?

I think that makes sense, let's go ahead with the rest of the SVA
series and we can do this next cycle. Bikeshedding config names isn't
really critical.

Jason