Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Fri, 27 Oct 2023 13:24:37 +0200
From:   Maciej =?utf-8?Q?Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>
To:     Ilpo =?utf-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>
CC:     <linux-kselftest@vger.kernel.org>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Shuah Khan <shuah@kernel.org>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 01/24] selftests/resctrl: Split fill_buf to allow tests
 finer-grained control
Message-ID: <uoy7hy42xmx6ptsczpaaexkghtnscnwn5ho2jvjy7trgn4y7dw@mkcluknnxr7n>
References: <20231024092634.7122-1-ilpo.jarvinen@linux.intel.com>
 <20231024092634.7122-2-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231024092634.7122-2-ilpo.jarvinen@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?JdkF/KkumbNQ9WzS7WpgEhKrC6+HrKguyRAFYJ2Hj+NpL0kbDWK+CVpvGS?=
 =?iso-8859-1?Q?hdpglycRYJI98l2rWXksXGFP/QpFEqttG0TXfyq2vx3R4Cxm0GEuiy/mov?=
 =?iso-8859-1?Q?IHDeuocTBtM3+TTMPW58OYfBjWUgQS8A23LkYpDyf18qhBt7YHb9jlHn2g?=
 =?iso-8859-1?Q?9y086VrPhsGqh+iqSLs7Ydq7S2FbzCE+A+5M/NDH5/ZDRJLOY1a0K/TFwJ?=
 =?iso-8859-1?Q?idtfBDBeSaYccU/d3mEc4aMSR2xDhXPusGm/sFf3t2seapjgIrff/6UYNU?=
 =?iso-8859-1?Q?PEiypqCcGfn7lEKoUNabXnUl88lTMz2M8sIdEB+dA0WLqUpO8HQMQjSFsb?=
 =?iso-8859-1?Q?yICoKfD09eqqy8SsnmP8EuGmaFajwjVwKX0fGjMgP5TVDFPwf6WosZ+JPI?=
 =?iso-8859-1?Q?RZ6M+afWzr1dpD/IGwyY2FDyNTA9NUNiYWQ3sebj22DCRi9yK7Z9dD25Iw?=
 =?iso-8859-1?Q?ksTBhwCbjRjiMXwEfDis9zQ5ryUVq4pwv8VFVA8ZRw5lWgkDPy/dsfQR9Z?=
 =?iso-8859-1?Q?gg4qYHCAPsplBTTmC8/uBYh7Emek9BHSkrTv4/IZlP69Xo15ot+KdQdEfu?=
 =?iso-8859-1?Q?ODuV4h1qwSubTxNVn5pfik8HTyBksDTveCgvpvmSG57HCrqPnb9pItZk4Z?=
 =?iso-8859-1?Q?XAiAv12RQiaRWN8HAobGOQiG0MIpCbS/aDszlu1Ah1nGp7aP+I12sYNqlK?=
 =?iso-8859-1?Q?YUtbzBhiiMAWSHIzSfxKFbGmoMA9mCQas181KXGKC/DTwhpbbf1H5kTz3h?=
 =?iso-8859-1?Q?OZyD0cbuDbCyDDbB3cAwTgo6b+fSuWeVR6RSrM7WgbpKhM/CV2TEzYNJZB?=
 =?iso-8859-1?Q?B0Q+joaJkfaDnUMaOQO54uImym5Z2HCLrk/zJJCKJT8q895a+aTSTgfHtP?=
 =?iso-8859-1?Q?zCrjm95nHVAmjQUGvB7fdv74MOvb3P7JuohRrSjBfyUKw2E71EiiJcEiaK?=
 =?iso-8859-1?Q?fZ2WdlGp65yCoI2iMAHVScfWw9L7wiXI6CO7/PsP7aWamxVzKPgGSFsfsy?=
 =?iso-8859-1?Q?DeX5PihiIOJtKi4RrlSU2CcSr6mFBvl0/PQqkmrncUat3ODpfW74fCyzlY?=
 =?iso-8859-1?Q?s5vZTlz0drtDoqkhita5QB/r1lg4qLUTF4HL05A6LCf2qzkwfBwzGStaR8?=
 =?iso-8859-1?Q?Nz9d5M25dhDvOUCitiQJuFItt5PCdby/B/R4may2jftMOwO3p8L63mWKqi?=
 =?iso-8859-1?Q?kgIhoYoUU2nt+VjxHLvpb0bpHTfYKerSYNUv3Oj65wyPrpGeoevfvlpDYZ?=
 =?iso-8859-1?Q?xTX/EgKcYK7NsTE6DMBv+iYusu28OU24r+KjuM5A3kvgUmFAG4h0wYCqnN?=
 =?iso-8859-1?Q?7/fpzjuTxuvTx77RLWR8uxmgP4wg7d0mm6TK//Y8T9tSsVCOyLBjKPSUAr?=
 =?iso-8859-1?Q?frP6DHgqZODiP6I6naKKq0b+86eSUX+9cWE1Fqf5hX6Kk16zw9SpfUYRxB?=
 =?iso-8859-1?Q?Ne5zvQlIHCTgPzp7/oQN3P4ILZzV1zuPuRQKrxSJj2qHnz4/73dzP/8EEt?=
 =?iso-8859-1?Q?t7hMuFQ3luW4AhSNIOOr4XJKC6lQbzE/wXQpasgjOA7sbWiNiBHQBLqTG+?=
 =?iso-8859-1?Q?WEXKNW20tJqEsY3Pcxk/KFNVI/5FV+ypmOsum6jcvv5p+z2rlxVSktbQ52?=
 =?iso-8859-1?Q?Ujp2UktT7g3E1Syjj2c67HuF1hjaXyDbz221z58i2umoGxWFPdjbVHYRCa?=
 =?iso-8859-1?Q?V7McuAXM01U/Egwm4D8=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 052330e7-9db0-4efb-f274-08dbd6df50a1
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2023 11:24:43.2149
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IrrCOuU8nC40hYQEY8aRWlPvcVgMOgP77TRg/lAi2hBUbmBqCL4pfXQJ7dpK263QRBsjAJf0+Eo1b65lk16F4iIaW6VGW2q5q8s+URTBOho=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6608
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 27 Oct 2023 04:24:59 -0700 (PDT)

On 2023-10-24 at 12:26:11 +0300, Ilpo J?rvinen wrote:
>MBM, MBA and CMT test cases use run_fill_buf() to loop indefinitely
>around the buffer. CAT test case is different and doesn't want to loop
>around the buffer continuously.
>
>Split fill_cache() so that both the use cases are easier to control by
>creating separate functions for buffer allocation and looping around
>the buffer. Make those functions available for tests. The new interface
>is based on returning/passing pointers instead of the startptr global
>pointer variable that can now be removed. The deallocation can use
>free() directly.
>
>This change is part of preparation for new CAT test which allocates a
>buffer and does multiple passes over the same buffer (but not in an
>infinite loop).
>
>Co-developed-by: Fenghua Yu <fenghua.yu@intel.com>
>Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
>Signed-off-by: Ilpo J?rvinen <ilpo.jarvinen@linux.intel.com>
>---
> tools/testing/selftests/resctrl/fill_buf.c | 26 +++++++++++++---------
> 1 file changed, 15 insertions(+), 11 deletions(-)
>
>diff --git a/tools/testing/selftests/resctrl/fill_buf.c b/tools/testing/selftests/resctrl/fill_buf.c
>index 0d425f26583a..f9893edda869 100644
>--- a/tools/testing/selftests/resctrl/fill_buf.c
>+++ b/tools/testing/selftests/resctrl/fill_buf.c
>@@ -135,33 +135,37 @@ static int fill_cache_write(unsigned char *buf, size_t buf_size, bool once)
> 	return 0;
> }
> 
>-static int fill_cache(size_t buf_size, int memflush, int op, bool once)
>+static unsigned char *alloc_buffer(size_t buf_size, int memflush)
> {
> 	unsigned char *buf;
>-	int ret;
> 
> 	buf = malloc_and_init_memory(buf_size);
> 	if (!buf)
>-		return -1;
>+		return NULL;
> 
> 	/* Flush the memory before using to avoid "cache hot pages" effect */
> 	if (memflush)
> 		mem_flush(buf, buf_size);
> 
>+	return buf;
>+}
>+
>+static int fill_cache(size_t buf_size, int memflush, int op, bool once)
>+{
>+	unsigned char *buf;
>+	int ret;
>+
>+	buf = alloc_buffer(buf_size, memflush);
>+	if (buf == NULL)

Maybe just do:
	if (!buf)?

Checkpatch also seems to suggest this approach:

CHECK: Comparison to NULL could be written "!buf"
#65: FILE: tools/testing/selftests/resctrl/fill_buf.c:159:
+       if (buf == NULL)

>+		return -1;
>+

-- 
Kind regards
Maciej Wiecz?r-Retman