Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757504AbXKUJ7k (ORCPT ); Wed, 21 Nov 2007 04:59:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752252AbXKUJ7b (ORCPT ); Wed, 21 Nov 2007 04:59:31 -0500 Received: from il.qumranet.com ([82.166.9.18]:50006 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751275AbXKUJ7a (ORCPT ); Wed, 21 Nov 2007 04:59:30 -0500 Message-ID: <474401BB.2020204@qumranet.com> Date: Wed, 21 Nov 2007 12:00:27 +0200 From: Avi Kivity User-Agent: Thunderbird 2.0.0.6 (X11/20070926) MIME-Version: 1.0 To: Sam Ravnborg CC: Kamalesh Babulal , Andrew Morton , linux-kernel@vger.kernel.org, Andy Whitcroft Subject: Re: 2.6.24-rc3-mm1 make headers_check fails References: <20071120204525.ff27ac98.akpm@linux-foundation.org> <4743EB52.1040205@linux.vnet.ibm.com> <20071120163240.e54beed6.akpm@linux-foundation.org> <4743EF47.5000203@linux.vnet.ibm.com> <4743EFF8.9010307@qumranet.com> <20071121095821.GB1070@uranus.ravnborg.org> In-Reply-To: <20071121095821.GB1070@uranus.ravnborg.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1534 Lines: 56 Sam Ravnborg wrote: > On Wed, Nov 21, 2007 at 10:44:40AM +0200, Avi Kivity wrote: > >> Kamalesh Babulal wrote: >> >>> Andrew Morton wrote: >>> >>> >>>> On Wed, 21 Nov 2007 13:54:50 +0530 Kamalesh Babulal >>>> wrote: >>>> >>>> >>>> >>>>> The make headers_check fails, >>>>> >>>>> CHECK include/linux/usb/gadgetfs.h >>>>> CHECK include/linux/usb/ch9.h >>>>> CHECK include/linux/usb/cdc.h >>>>> CHECK include/linux/usb/audio.h >>>>> CHECK include/linux/kvm.h >>>>> /root/kernels/linux-2.6.24-rc3/usr/include/linux/kvm.h requires >>>>> asm/kvm.h, which does not exist in exported headers >>>>> >>>>> >>>> hm, works for me, on i386 and x86_64. What's different over there? >>>> >>>> >>> Hi Andrew, >>> >>> It fails on the powerpc box, with allyesconfig option. >>> >>> >>> >> How do we fix this? Export linux/kvm.h only on x86? Seems ugly. >> > > Is kvm x86 specific? Then move the .h file to asm-x86. > Otherwise no good idea... > > kvm.h is x86 specific today, but will be s390, ppc, ia64, and x86 specific tomorrow. What about having a asm-generic/kvm.h with a nice #error? would that suit? -- error compiling committee.c: too many arguments to function - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/