Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Fri, 27 Oct 2023 13:39:31 +0200
From:   Maciej =?utf-8?Q?Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>
To:     Ilpo =?utf-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>
CC:     <linux-kselftest@vger.kernel.org>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Shuah Khan <shuah@kernel.org>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 03/24] selftests/resctrl: Refactor get_cbm_mask()
Message-ID: <wlemodlvfokzfdswamwmdqeg5av7ylrj2w6i6orif6vf6jd7hc@zqmdopz64keb>
References: <20231024092634.7122-1-ilpo.jarvinen@linux.intel.com>
 <20231024092634.7122-4-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231024092634.7122-4-ilpo.jarvinen@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?43AdKGhTHbudhtdoyQfljrcIBfFXhkosXQkrp3RtCMrbtOsl9mLvXqYUvJ?=
 =?iso-8859-1?Q?O8vKPS9tel+dWAQBzor6oxqAwDLb+/rGxuivBMZb+z2eesyEG1YMRyatme?=
 =?iso-8859-1?Q?qw1LujSfQe0Cbo5JHk8gewt4ud9Tgqy+/Kb2Du1X+PymJGvpL9VajDhb1Z?=
 =?iso-8859-1?Q?f35ezVx6rGV34W+SEVTM1yBFzHGpGfiayR1P1yYlVkok2aLtv9zjH67Oq9?=
 =?iso-8859-1?Q?NArd+Ojyhmo0W5xeksWMW1lZTrqyxiGsmPXf3pFGBEyITQ39quUlOgzaNg?=
 =?iso-8859-1?Q?Q+YKEgZ6L0AMie1MOfpXrjtkj0EZX8T7NBWARUZZgN4RZIdX/zCyiqRXzh?=
 =?iso-8859-1?Q?sHw5k9vdk31P/r/d4jPJtXnkMp01p3R5JxPj9pzWs80PMERr2tC9NpB4Nn?=
 =?iso-8859-1?Q?0mCM6Hl8mxSbqFUBysvd3gb/qCFHZ/ENwZUY7B2TprqrdL5efz3KaEfSY9?=
 =?iso-8859-1?Q?8SjidPUYkdyAGa0HdkXkCXPabVeV3cs4k+O6k3a3ruP6V454st6QQf6ELS?=
 =?iso-8859-1?Q?u037meoHI91dnLnBeAzQ1tAGnm3BFshfiEkNgoKOm3tnG+X49xYww/tmIr?=
 =?iso-8859-1?Q?yDmkm7SvOwL0UHWkX56AdsdfigmYbQru/l1uymPYuwV6DCSnSUOEX05dbM?=
 =?iso-8859-1?Q?R0XdVkmVR1qKZX9Ur1ox+6ePeOOzcIESOxz6Hth+4WoGP1I+udd3J+l02T?=
 =?iso-8859-1?Q?TBo5JSNWGZjwOmKA8IksWXgv9JY8xMeaF0990WVcg/saSNB6G101Mkd18Y?=
 =?iso-8859-1?Q?jjubs3vqkxJzClXCW76dkxmhkatPZ10Bu0f10tnxzU/3fPFLYD9FIxzrCh?=
 =?iso-8859-1?Q?+xJbtaQERjxAurQenkp/cC4/UD9LcAldRQsUKLZp8DprRv8NYRsOSHRUWI?=
 =?iso-8859-1?Q?9nCvK3HG9V2bZ7+RfCvRbuzOkWJfUQSzYD0AwIK51vSTRfzFToxK1z532J?=
 =?iso-8859-1?Q?zJRg6ZDRXOug1eXB30+gLtoBjiSTSGJr9nkbTLkNM5ITZISvPqt+v/xByG?=
 =?iso-8859-1?Q?x4AK7PfaPp/OoH4i9joZYn/a3xNMVab9Uo8GYuXqHXxqsRs1zccNWO4Ifv?=
 =?iso-8859-1?Q?SNxizdbUtufXaCYrEsLqBbtWkLdmlcXNrSDlthpok75eZ9kio0DouD5042?=
 =?iso-8859-1?Q?DR6xFaMRi6QGfIAoraMW4LtNCNyuorcqx756kkhJa7wN1/JOgTZZZ6yAhZ?=
 =?iso-8859-1?Q?9IlEYDfvZ++xvpyLmKmYVzhXs2JjZxsLeiQ7a6EsItVtTOYaENFuBI0nxh?=
 =?iso-8859-1?Q?13yQbR1FriPO4mZ5KWFnix60PPbUcgFZtvnkF/E/K4XZnN2gt0dC0CkDSN?=
 =?iso-8859-1?Q?G9sGED6yZYirBWvIkG+j7LKfqmegTdweOEsZFyorqXsDXShQmUyFIVLF9z?=
 =?iso-8859-1?Q?o7Bn80cWxjaylQ8SUrUjqc2UWDMMTX9dLA0slao/XYawcJ1uYHR/xmBjBi?=
 =?iso-8859-1?Q?S0O16nbnUY9CIbR3w2ffpD0xY8Ono/FSCJvrCSlb3c442c6H9Ju16RK2lV?=
 =?iso-8859-1?Q?2jvqJKrIYOa9pYW44EUYwex5PZihvbaKXFdPNhUsxNkuQgUpPvp9CKBXVa?=
 =?iso-8859-1?Q?7GYma5HqhPnPTK8x64TdonuTy/jFdU/F8cBmTFrWBmP1VcLSRQH/79w656?=
 =?iso-8859-1?Q?Yv7xeE2N9l9lA9kU1yU++jYyRLQO7LbLCsuJszb8Ask/oil262+9CkBic2?=
 =?iso-8859-1?Q?6k36ru0PAsodhfPhVZM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7fb9fbc8-2ebe-49e3-ff82-08dbd6e165e9
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2023 11:39:37.0242
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hY6D2HiAFjcBZMYZuAA7V+zHSqhoAiDreEJJsdLdvEFyQTEwnqIyxElHFPMN7j7s2kC2GTxjajzXL9lB5OPAlVQboFzSNv0uRy0e85+MqVY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6348
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 27 Oct 2023 04:39:54 -0700 (PDT)

On 2023-10-24 at 12:26:13 +0300, Ilpo J?rvinen wrote:
>Callers of get_cbm_mask() are required to pass a string into which the
>CBM bit mask is read. Neither CAT nor CMT tests need the mask as string

"CBM bit mask" -> "CBM" / "capacity bitmask (CBM)"?

Generally isn't cbm_mask an odd name because of the repetition (capacity bitmask
mask)? After looking at x86/resctrl files putting "mask" after "cbm" only
happens there. Maybe a better naming scheme here would be get_cbm_bits()?

>but just convert it into an unsigned long value.
>
>The bit mask reader can only read .../cbm_mask files.
>
>Generalize the bit mask reading function into get_bit_mask() such that
>it can be used to handle other files besides the .../cbm_mask and
>handle the unsigned long conversion within get_bit_mask() using
>fscanf(). Alter get_cbm_mask() to construct the filename for
>get_bit_mask().
>
>Also mark cache_type const while at it.
>
>Co-developed-by: Fenghua Yu <fenghua.yu@intel.com>
>Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
>Signed-off-by: Ilpo J?rvinen <ilpo.jarvinen@linux.intel.com>
>---

-- 
Kind regards
Maciej Wiecz?r-Retman