Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Fri, 27 Oct 2023 13:47:58 +0200
From:   Maciej =?utf-8?Q?Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>
To:     Ilpo =?utf-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>
CC:     <linux-kselftest@vger.kernel.org>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Shuah Khan <shuah@kernel.org>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 13/24] selftests/resctrl: Convert perf related globals to
 locals
Message-ID: <f6b5e7eqjxyt2fcpeub2iusxdpnfkmvaiudgthwmowmgdmc6gt@uaxdzdwj3fg7>
References: <20231024092634.7122-1-ilpo.jarvinen@linux.intel.com>
 <20231024092634.7122-14-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231024092634.7122-14-ilpo.jarvinen@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?gK1y/Tig3AtylfvB961+skxlIR9IAzre10EEK+LGDf5d9hn+Yaps/XZ30D?=
 =?iso-8859-1?Q?q9eEU9dNoqbaXiibVi6Akr6UeoY3c48W0pUbhMBruCGeWNKGc7oecZzVWV?=
 =?iso-8859-1?Q?ODB3VEN+JSj+MDK6ISTPJH6UP8qYewQLAZIlP4jpycybTzTTVdN77t0MmZ?=
 =?iso-8859-1?Q?JjBEBESlwvqHYWfUCBKKqOR/Kt2Gks7mEL1TnxWNbpJ0eQd8PyLZ+CwyG0?=
 =?iso-8859-1?Q?F8EFblvFYoKJxcZNTjRbIMim2sXLFbWQE8WSW1FAVE9Gb4fePCiXCI4mI2?=
 =?iso-8859-1?Q?e61ZZ8hqb7SzjC89p5D1+znhZhDllW7+Ay+2TvoYY/PPYC1ihoT4pnqh8e?=
 =?iso-8859-1?Q?bHsui3wVOPYySW2336w+XJOn0P0wFI3nwh5ujVlWPhl/+GtMPYlLRFKg03?=
 =?iso-8859-1?Q?zfMmAVjlr+19SFtuS+eBSycj621WYpW4A3U5cmivtkxkGMKFtpEWEm0aRT?=
 =?iso-8859-1?Q?GADuSK/wfOEDW8dr6otl05QLnQxBec70rx2USZDpS3XJ0SUK3PxfUaQf5T?=
 =?iso-8859-1?Q?rhlU1wyZiCcmPQBSt+0fHFd6uaXMoUbyP1naQuRG2KsXUnPrhsyvOZgHkT?=
 =?iso-8859-1?Q?d0H/FolJ5kxZwNuWPjB5K6pwTXnUvqp/IbCsycSognsJqVZPGnOK1mnvfu?=
 =?iso-8859-1?Q?LEB/CUW6hNLpZyv1L8S21wHErPuqct3vP7EcKmwOrmZI/HC3+xdv1+AQE3?=
 =?iso-8859-1?Q?M9gmtVlHCnTn+i9oGQ3p5KBPd3iKH6hPQHLewFaNI0DpcNAGWOLqfR2C1W?=
 =?iso-8859-1?Q?FvYhWXpdbWc63aSv06co70Ln4bkShurP2j7kfoBt2yV+PKJfYCXClx6QyX?=
 =?iso-8859-1?Q?pl9nwFCPZGES3UodY6V58at1GfQSlzxR3sv71exLfT64W9oA551E/PvLqo?=
 =?iso-8859-1?Q?hixbzxC+7CRpbOKoyJJkw08zvvp6LfrPYmEXij5CODpP11vsqvSH4C7E31?=
 =?iso-8859-1?Q?0Vh84OWqMgVAqb8uUtKNtkFwqCB8nee3rExysXYAVjqjkZ0L+bw17ewAOQ?=
 =?iso-8859-1?Q?1FtvHudpTIKMh0tBazrxNKfyZ8qN6p1GO7SR2wVdovrfyIr0K/WlgorMmA?=
 =?iso-8859-1?Q?AQnT67ODZqHTTC++oYNxrKvj71mKGfrmisdauOWZ+WBeegDRwngKmTWdqJ?=
 =?iso-8859-1?Q?DbXghT6FGii0wshIAl/emzTU3BQz/sA6mZCxUm+mUxqB8dGs9gusMZenLq?=
 =?iso-8859-1?Q?gfmY3coEhmVYhUotNqUOBqa4Si87u48rizSui7bs0G8FR5AUI75kR0jNRc?=
 =?iso-8859-1?Q?6SMyK20oyaT6uI5LhbKXohsMZWYN4G0nS0cM1xpxNC9reqaRsJb4Q8z4KW?=
 =?iso-8859-1?Q?PTjMLVYylHh8By7qC3w1Rn6A6YTViKC57820jSpUSqWas6ElZ4yB1FzdUJ?=
 =?iso-8859-1?Q?1SVckWksUwd4lDfqPwjGjjSruy4eI0ebErTbGoWECEkjCV4qROkRBahDAJ?=
 =?iso-8859-1?Q?Q6bAaSp7nIkxiJh1cWsyjsH/KFPBgCf9SkuL0K79wkOcghlYoPHHHg/Qsy?=
 =?iso-8859-1?Q?vUjzROkAEJh1alALzp6f3IvRyvEGNWB9wPsiHSZZaQztuXOhUGrcd9OFyD?=
 =?iso-8859-1?Q?PkL26Zz0JGRBb9WWdPqyBDwYM0FyBPydqF7cCVlTujn8uDSI+274CNKi39?=
 =?iso-8859-1?Q?L5H74JoH2PLsEtPURfXmQBhYgdFWINlsARccSglHkbM8nAtFEej46DN43Q?=
 =?iso-8859-1?Q?u6xKcaP5pvTvx9l/hOU=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b3ccc402-9a0f-47e1-0160-08dbd6e29374
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2023 11:48:02.9802
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mZyG0+SH+3uTNr2Lj7GODgl/ztkK6yCcMjnhj2IQGqRGMZDja9sIbkxZnglc5XDFrlAQtW1eD96rOTzhdiDYR4QnBlAywLDP/BTA2Dmn7YY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6905
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 27 Oct 2023 04:48:26 -0700 (PDT)

On 2023-10-24 at 12:26:23 +0300, Ilpo J?rvinen wrote:
>Perf related variables pea_llc_miss, pe_read, and pe_fd are globals in
>cache.c.
>
>Convert them to locals for better scoping and make pea_llc_miss simpler
>by renaming it to pea. Make close(pe_fd) handling easier to understand
>by doing it inside cat_val().
>
>Make also sizeof()s use safer way determine the right struct.

"use safer way determine" -> "use safer way to determine"?

>
>Signed-off-by: Ilpo J?rvinen <ilpo.jarvinen@linux.intel.com>

-- 
Kind regards
Maciej Wiecz?r-Retman