Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Fri, 27 Oct 2023 13:51:24 +0200
From:   Maciej =?utf-8?Q?Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>
To:     Ilpo =?utf-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>
CC:     <linux-kselftest@vger.kernel.org>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Shuah Khan <shuah@kernel.org>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 14/24] selftests/resctrl: Move cat_val() to cat_test.c
 and rename to cat_test()
Message-ID: <5x3wlnejagee5hbigjo6dpvbc5453gnaab4ue6doplneumfgzd@q7yo3j3prh2h>
References: <20231024092634.7122-1-ilpo.jarvinen@linux.intel.com>
 <20231024092634.7122-15-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231024092634.7122-15-ilpo.jarvinen@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?EE1sVpVPBNmlRvmjQuZL+MkdyXqz0m2ZwxeGr5LiVanuyxMYYK4wsSXSI8?=
 =?iso-8859-1?Q?o9TvkWf4w1YKSM+bvXCSPD6WkWCtcWks4uMpwMgVW/VwotAvSBEjwY6/F2?=
 =?iso-8859-1?Q?o8jQ2vRWYdGeHjGzzrhIg/sqfaLX/1mM8O5NXlcBDp5a5GSERU5fM2ekFa?=
 =?iso-8859-1?Q?Cf3DURS6KOShQjrclmfp5Kuygt34R4ATQDM1zfizdKFI77ro0k3cfFshm8?=
 =?iso-8859-1?Q?EbJi/3JcMcjsMID70uoyCt8ta1tbuZwfWgSzQMTyUg+v17j6DZM+XnJuqR?=
 =?iso-8859-1?Q?2hj5awIEkZy51qMTHu2bE+reveafxv2xDiXk3g5vDrHqitzygNSe5umP1N?=
 =?iso-8859-1?Q?6tHeIfSf0z5/0qG9jtg4LG4FHVXsGWsG9KEfBn4LNduIHJ7iI0aDv8YE3V?=
 =?iso-8859-1?Q?pDVCojipuaR90ldmJyIc0BHH/k+dXqwXVr48aQJZ2cy3QxCdRv9Nr2GLpw?=
 =?iso-8859-1?Q?ZUWqG1GwtLbp320SeMqZ80K5zX0DOTpUDzzKDhAPE8wVY0Arq+BbLMGoqa?=
 =?iso-8859-1?Q?+2fZlwrmfriUlSNemJtgSuRlvhuoNQVyGyZ0d7vfViICigzCTWSyiiR7oS?=
 =?iso-8859-1?Q?WSg131G7/1bOix8FVTFqmr5wEg5LVu8XpWd0qqNSw3uXvAhe8R48pHlQNY?=
 =?iso-8859-1?Q?Mjj8u/tZVnVQmnNlG7EK7F04re2tG/SsXyZNMfa4KwtKcgra+A3JPjyjn5?=
 =?iso-8859-1?Q?3VP7+1h9S1wMWTI9stSkr8NUa9ygW0xCOCdsYrhLJdjiIm3VCozu7tpTOH?=
 =?iso-8859-1?Q?ruGYoiMe+b+Q5tsAMywq07NgW0TIz0QNNG8BgXjqmcp33SrfADQkAluk1Q?=
 =?iso-8859-1?Q?JI2DBWVRIktn1oJQQGyqJtc6cGxwDClZXK4l8zGKrS0w9Hnt8/NobH+SzN?=
 =?iso-8859-1?Q?HNe7kOq/zUKA+76zqCYjsAZrtKC35fTUfAQ+Y0r9DpIVmuqmTFvHvwzvyT?=
 =?iso-8859-1?Q?3bUQIyWWiyZsh+0hAOVIbIyFF0KTePIePJOOQfYouF9nQ/ZadAH5Jt2I4z?=
 =?iso-8859-1?Q?aUNDlbSIKa02Hxj4+Q5OVzRM6V2loVqHkiPqXOlPS6XQauNTBE+9nGkHik?=
 =?iso-8859-1?Q?hg515GuKGgJglVgEQmqNWccC2AZJjtgQtQAQHMlWeaN/ATuB8MIHvfSBqT?=
 =?iso-8859-1?Q?3R2B6yV8PH6lR3yhWxnrZFjCNGhSsSLhBMhIj8OV9h/ZoKYrPxuXeRyApg?=
 =?iso-8859-1?Q?4uxJEX3R/Uy06IrlAGyzFtCOVhJcffgVAD7aG6rUErEZBmLBMZLXBEf1zF?=
 =?iso-8859-1?Q?u37vOAhvP0zqU9gsd2DezUnF+eBzODHkpgookJ+FAznCkFLD2mErj1lxX0?=
 =?iso-8859-1?Q?6xnZyoCGGe4mYTpoygwU8S0JAAyJnxz2tRVZjHegpHZ+VamULWOoJQ2YnR?=
 =?iso-8859-1?Q?B3UqtulTfnJ+P7zopoP9Llv4hSMM1ubDgNiffLks/4MW4sP5q3l+6f1fc6?=
 =?iso-8859-1?Q?Nx6FHQe8FVabIcVEvZhB+rMpqAE6jx1hXGDCHiZ88WRigmyO8cfXORZSGW?=
 =?iso-8859-1?Q?TZsP+jxzE/FAa1u4PI2JK1ce6FZX5jjYJHc2nbP1XoQX6gF4wp9tvWhZbI?=
 =?iso-8859-1?Q?BY5JpRtfpyyoJAp+es9vogIDAjeR/xbwEe29PGZz5jG11EjorSA1HRZjFB?=
 =?iso-8859-1?Q?CVVWXCzVVWcW/66OeDCDs+y6B9M5PtZWtquf/ASIQmg4cali/qxsz1vjwi?=
 =?iso-8859-1?Q?3YKd9DLfIVPCKYSYqPg=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c402dda6-dfd5-45e9-8539-08dbd6e30e06
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2023 11:51:28.5133
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RVcwJvG6VoBBsCDlQxGNsgrGDb1lEw9Nleq/rxWOhBtwRmmyDsTfGMWWNvJhmnr8L6+mY0bSLj3/Y/UymQ+nGRtRTb/CIgC2BOgHTEjkiv8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6905
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 27 Oct 2023 04:51:45 -0700 (PDT)

On 2023-10-24 at 12:26:24 +0300, Ilpo J?rvinen wrote:
>diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c
>index 2106cc3601d9..e71690a9bbb3 100644
>--- a/tools/testing/selftests/resctrl/cat_test.c
>+++ b/tools/testing/selftests/resctrl/cat_test.c
>@@ -111,6 +111,77 @@ void cat_test_cleanup(void)
> 	remove(RESULT_FILE_NAME2);
> }
> 
>+/*
>+ * cat_test:	execute CAT benchmark and measure LLC cache misses
>+ * @param:	parameters passed to cat_test()
>+ * @span:	buffer size for the benchmark
>+ *
>+ * Return:	0 on success. non-zero on failure.
>+ */
>+static int cat_test(struct resctrl_val_param *param, size_t span)
>+{
>+	int memflush = 1, operation = 0, ret = 0;
>+	char *resctrl_val = param->resctrl_val;
>+	static struct perf_event_read pe_read;

Is there a reason why this struct is declared as static?

>+	struct perf_event_attr pea;
>+	pid_t bm_pid;
>+	int pe_fd;
>+
>+	if (strcmp(param->filename, "") == 0)
>+		sprintf(param->filename, "stdio");
>+
>+	bm_pid = getpid();
>+
>+	/* Taskset benchmark to specified cpu */
>+	ret = taskset_benchmark(bm_pid, param->cpu_no);
>+	if (ret)
>+		return ret;
>+
>+	/* Write benchmark to specified con_mon grp, mon_grp in resctrl FS*/
>+	ret = write_bm_pid_to_resctrl(bm_pid, param->ctrlgrp, param->mongrp,
>+				      resctrl_val);
>+	if (ret)
>+		return ret;
>+
>+	perf_event_attr_initialize(&pea, PERF_COUNT_HW_CACHE_MISSES);
>+	perf_event_initialize_read_format(&pe_read);
>+
>+	/* Test runs until the callback setup() tells the test to stop. */
>+	while (1) {
>+		ret = param->setup(param);
>+		if (ret == END_OF_TESTS) {
>+			ret = 0;
>+			break;
>+		}
>+		if (ret < 0)
>+			break;
>+		pe_fd = perf_event_reset_enable(&pea, bm_pid, param->cpu_no);
>+		if (pe_fd < 0) {
>+			ret = -1;
>+			break;
>+		}
>+
>+		if (run_fill_buf(span, memflush, operation, true)) {
>+			fprintf(stderr, "Error-running fill buffer\n");
>+			ret = -1;
>+			goto pe_close;
>+		}
>+
>+		sleep(1);
>+		ret = perf_event_measure(pe_fd, &pe_read, param, bm_pid);
>+		if (ret)
>+			goto pe_close;
>+
>+		close(pe_fd);
>+	}
>+
>+	return ret;
>+
>+pe_close:
>+	close(pe_fd);
>+	return ret;
>+}
>+
> int cat_perf_miss_val(int cpu_no, int n, char *cache_type)
> {
> 	unsigned long l_mask, l_mask_1;

-- 
Kind regards
Maciej Wiecz?r-Retman