Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
MIME-Version: 1.0
References: <20231023-imx214-v1-0-b33f1bbd1fcf@apitzsch.eu> <20231023-imx214-v1-2-b33f1bbd1fcf@apitzsch.eu>
In-Reply-To: <20231023-imx214-v1-2-b33f1bbd1fcf@apitzsch.eu>
From:   Ricardo Ribalda Delgado <ribalda@kernel.org>
Date:   Fri, 27 Oct 2023 14:25:48 +0200
Message-ID: <CAPybu_2gya-XP2-JH8roYgyROUAeTbVBaY1ypMKyVp+ujb=t6A@mail.gmail.com>
Subject: Re: [PATCH 2/4] media: i2c: imx214: Move controls init to separate function
To:     git@apitzsch.eu
Cc:     Sakari Ailus <sakari.ailus@linux.intel.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Andre
On Mon, Oct 23, 2023 at 11:49=E2=80=AFPM Andr=C3=A9 Apitzsch <git@apitzsch.=
eu> wrote:
>
> Code refinement, no functional changes.
>
> Signed-off-by: Andr=C3=A9 Apitzsch <git@apitzsch.eu>

With Jacopos comments (don't use de_err_probe())
Reviewed-by: Ricardo Ribalda <ribalda@chromium.org>

> +       ret =3D imx214_ctrls_init(imx214);
> +       if (ret < 0)
>                 goto free_ctrl;

It seems like we can mutex_destroy a non inited mutex. Could you send
a follow-up patch to fix that?

Thanks!