Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp1121711rdh; Fri, 27 Oct 2023 05:33:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEh2RAyXKITs+5bM108+d8wK+ng5LGxm8U2JeXt+ppcpO/p/I1FjRiSLelEW7scDQmQmnPc X-Received: by 2002:a25:aa0d:0:b0:da0:cc9e:392f with SMTP id s13-20020a25aa0d000000b00da0cc9e392fmr2276278ybi.36.1698409992960; Fri, 27 Oct 2023 05:33:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698409992; cv=none; d=google.com; s=arc-20160816; b=B3SUcWYrhZO8K7ugKKWES+tiRxSQInAVArNoS0dsmnqRA8MpdZXJi9txGXSxB6YzGa s8yppmAwP+jOwbiTx/2ShI1MzA07sJGaApyukaHl2h7biG7c2tv8/9F+IX4m4Q6+8b1o JQ88cAte+yUQOtul0uxV96PArKzZZp4rvNFJf9wqiKVhLldWBvQXHN6kixvn+gi2pKiT NfC/Qosy0noBc/iedlitelofCUAOUoNj4B1UuI4at/PdCAKmmw6yf/fw1PP0u2s6sMY9 4B3nSJX2r+XQSqFhOnXPHG38DQadzLFIdDAdxqUbVheTaGRiWyh3ONr9Dea402tWHBxJ 89SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=DE+NrCk1jJ4KuRpOkz78J50aa3VZmIqIYeTRoPP9IPI=; fh=aSKCxClAvhM2V/aRtW+DW8lmf5FW0YyiXv5wL7CcCNU=; b=qPXuNUzzoYFibw0weBzfDW+ESY+E5QG9KQjR0KQTeeOC1mRlp0H8EB5Zw5q1WaUbLW tbFGKc4YXvNhZhEupmO69Hcew0JV5kXmXJZRapmxLvsRXRyNJ/cFLwDadUvY9hDit3td h9MLGvMySJrZo37qfwcF03sylZxD4dEapLCwpXL07jP6o2ZpXkfLf9zBOaFJ6NWZ3m2P mm7IuWjL6otoLZL0NPbcw7+iqGqojR1m+dvA7lLTnJey06vGnsIrOMklodasTuqm4L9V gfoWfmt2BJWWg7f/htmmsN12dQIp265aaDGGsUqTzFl++gy3Blpy8qtLd8bMf0BmRevS k8eQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=V1fedcgA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id v63-20020a25abc5000000b00da0f6bd6391si2556987ybi.608.2023.10.27.05.33.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Oct 2023 05:33:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=V1fedcgA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 048DB84AB801; Fri, 27 Oct 2023 05:33:10 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345815AbjJ0Mcs (ORCPT + 99 others); Fri, 27 Oct 2023 08:32:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbjJ0Mcr (ORCPT ); Fri, 27 Oct 2023 08:32:47 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8438C0 for ; Fri, 27 Oct 2023 05:32:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698409965; x=1729945965; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=2WFc0xktwdPr3K6DLDyFQydg5aZGQ7HEhIRKjX8dajE=; b=V1fedcgAV0oD4Zyv6Kk6ZquHbeNdbdrTMHzdeA+E59GTYpjJnSehlNGE 2LxSxChgLagMCt3yc9Jy7ztgW8FYxCUi50YAxA1cwsr40BHcb1SZF7i4j 5IOkqDDmgR0ehZPvB2i8ctWOnt0xEPewi+yeNeSigJLRGqCAIAUCKIOjH sKAnG7nIw1NO4D3aimK9y54F8MQVhKO715aWvRFYewzhNO8cV0hEbyhkh Y+EqGZumOmmn4aXBbOI+5DcUNiqwZXdO/E1tj+0BiIs/QuhMlg723S2dR w7mn+KZkVqsNPTXrVZVwKOo3kAuDUacd9xV22yr1hBJeNFHY0wA/ZVUPg w==; X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="418877268" X-IronPort-AV: E=Sophos;i="6.03,256,1694761200"; d="scan'208";a="418877268" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2023 05:32:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="709398360" X-IronPort-AV: E=Sophos;i="6.03,256,1694761200"; d="scan'208";a="709398360" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.74]) by orsmga003.jf.intel.com with SMTP; 27 Oct 2023 05:32:20 -0700 Received: by stinkbox (sSMTP sendmail emulation); Fri, 27 Oct 2023 15:32:19 +0300 Date: Fri, 27 Oct 2023 15:32:19 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Peng Hao Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] gpu/drm/drm_framebuffer.c: Add judgement for return value of drm_get_format_info(). Message-ID: References: <20231027091912.1244107-1-penghao@dingdao.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231027091912.1244107-1-penghao@dingdao.com> X-Patchwork-Hint: comment X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 27 Oct 2023 05:33:10 -0700 (PDT) On Fri, Oct 27, 2023 at 05:19:12PM +0800, Peng Hao wrote: > Since drm_get_format_info() may return NULL, Not in this case since we already checked it earlier. > so a judgement of return > value is needed to add. > > Signed-off-by: Peng Hao > --- > drivers/gpu/drm/drm_framebuffer.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/drm_framebuffer.c b/drivers/gpu/drm/drm_framebuffer.c > index aff3746dedfb..be7dd1998c04 100644 > --- a/drivers/gpu/drm/drm_framebuffer.c > +++ b/drivers/gpu/drm/drm_framebuffer.c > @@ -194,6 +194,10 @@ static int framebuffer_check(struct drm_device *dev, > > /* now let the driver pick its own format info */ > info = drm_get_format_info(dev, r); > + if (!info) { > + drm_dbg_kms(dev, "no matched format info\n"); > + return -EFAULT; > + } > > for (i = 0; i < info->num_planes; i++) { > unsigned int width = fb_plane_width(r->width, info, i); > -- > 2.37.1 -- Ville Syrj?l? Intel