Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp1125618rdh; Fri, 27 Oct 2023 05:40:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHIQJERwbTi7Izq1TW5yahwAQpMuJ4pw1Ky9v1vun7h616fooeUiPHK+r7S6NfeShZrpvzr X-Received: by 2002:a05:6871:2b24:b0:1ba:466d:5f9e with SMTP id dr36-20020a0568712b2400b001ba466d5f9emr2759337oac.49.1698410403615; Fri, 27 Oct 2023 05:40:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698410403; cv=none; d=google.com; s=arc-20160816; b=iwEPixGpYUrpx/sq58ragTzVtQJfL7HJ1CurrQ22hRbrIt0k5o7H9xIVFlvnKgDxky C9eqaQILP54SU0S+Q4+11RjSnQEYQLwphNcuDXjjkrNQDybz4bVhaWvH5OZOyqXra7v0 FScVqtMrTxTd1jZxoPbncR5wZkGbh+k2W36L0KkVrdHf5XlnWohCsXcdCE78eSsVR85Z zfYM60p1tqkTeNgNPVLG4u63pvjblYNzYuAx4T1ZOJz6o3PmKrgrkCDbkkIRDHcxoikj pzc9/p0pbD6toGD+zLlCE0OuHD5gyeCy++E0pvjkogp93fQk/jNMcsiFIRR2VazPH+2C K9VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=IovyunwHZtc5K1K5/M7+kEZqtyWpYNEV1NveW7UEohI=; fh=GfVp5Rek0jIWt0TcxTD+SeIbIP+bU9X6uxYGC7fOj6w=; b=yzVQ6YLY6bQRV9scW15YEWbRkbdorrwLZUvPAhqsAmCwLCvGasl+Ihg9Z4u7ZAZ7BI /cyskRuV6IK8uwO9Ph5sj1xtf7BLYtV0PfsNkLRBc5OJzTd9LcHk1nN96eAmHUSvmjZB OvkAtSHFkkokvXAPPE5+ZVU9pgPTJzhy5zs9X4jsq1BGXmGZU1MFJ5uJ1vD1X5wawR1Z daOanLPKf8Z28AJ0TH1qPVTmpRA+PryiViCAAqspe99i1x0YqNN7JVxGb+7lDkvmlZwg gUzSZWqKEUFW6yF8QlS6igWG/uYOXL0AYECwrxkQqWAb+MS4ZW5x1N55cC4Ej3Bldhqm 8MTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=iLoUdaWK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id j145-20020a25d297000000b00da07ec3f394si2325681ybg.635.2023.10.27.05.40.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Oct 2023 05:40:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=iLoUdaWK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id E5CB78212D34; Fri, 27 Oct 2023 05:40:00 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345823AbjJ0Mju (ORCPT + 99 others); Fri, 27 Oct 2023 08:39:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345539AbjJ0Mjt (ORCPT ); Fri, 27 Oct 2023 08:39:49 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D757BF for ; Fri, 27 Oct 2023 05:39:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698410386; x=1729946386; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=aHwDiflggT8QAz05/hvgP4SAkEJ7S7lNpOkSMXYalfI=; b=iLoUdaWKPJ1RyoG3cItpz8cgO01UzKGbywIfEeijwQaP+99Ltq/mKuxM 4Jh2nHczLv5spFQStwa6eAX12dn+SSdQ/ZykaDdltFCcpGgKuS17cwfOc 1LM/Z2YqrLYkhsmM2OBNDRSVSXqNbA1mrNCSJ41INAbO+581tNOGVVenL fc+kJOpDHqSCOBBEE2SoOBQ2CkTnDy23pmjSQkWhfAGlJIQhfpjrvC3Q3 8y/8hAE7cKazMOSW9YJhzhj1UnOxk08rE234yeHkzWfTd8c34ZzN+J+kb 5NS/lH9l/yveSC5ob8gg8SDrQ1JluIv+dfpMvkWEb7Ubi3g89pUS2yO0g Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="387582307" X-IronPort-AV: E=Sophos;i="6.03,256,1694761200"; d="scan'208";a="387582307" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2023 05:39:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="903264203" X-IronPort-AV: E=Sophos;i="6.03,256,1694761200"; d="scan'208";a="903264203" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2023 05:37:17 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC3) (envelope-from ) id 1qwM7q-000000098v6-45IR; Fri, 27 Oct 2023 15:39:42 +0300 Date: Fri, 27 Oct 2023 15:39:42 +0300 From: Andy Shevchenko To: Dipen Patel Cc: timestamp@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/1] hte: Use kasprintf() instead of fixed buffer formatting Message-ID: References: <20231010141123.3909596-1-andriy.shevchenko@linux.intel.com> <59939570-3779-ef90-2a72-7be32a30e368@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <59939570-3779-ef90-2a72-7be32a30e368@nvidia.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 27 Oct 2023 05:40:01 -0700 (PDT) On Tue, Oct 10, 2023 at 09:12:09AM -0700, Dipen Patel wrote: > On 10/10/23 7:11 AM, Andy Shevchenko wrote: > > Improve readability and maintainability by replacing a hardcoded string > > allocation and formatting by the use of the kasprintf() helper. ... > > hte_ts_dbgfs_init(desc->attr.name == NULL ? > > ei->line_name : desc->attr.name, ei); > Reviewed-by: Dipen Patel Thanks! Who is the maintainer of this code? If not you, shouldn't MAINTAINERS to be updated to reflect that? -- With Best Regards, Andy Shevchenko