Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Fri, 27 Oct 2023 14:42:18 +0200
From:   Maciej =?utf-8?Q?Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>
To:     Ilpo =?utf-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>
CC:     <linux-kselftest@vger.kernel.org>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Shuah Khan <shuah@kernel.org>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 21/24] selftests/resctrl: Get resource id from cache id
Message-ID: <cb2ctfignowlom7lb2t5zhdgtm4s2jlzlvtumlnvxecwwtjk34@ysgepmgkv6bb>
References: <20231024092634.7122-1-ilpo.jarvinen@linux.intel.com>
 <20231024092634.7122-22-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231024092634.7122-22-ilpo.jarvinen@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?uRgJ3fh9SN/Wr6v1t/tPJUuhupDHfud7riBooNQ3/PV8GTYlD9k2PqN0Nf?=
 =?iso-8859-1?Q?QzrvTcBNykAz0fM3jR+ZcjjuBhHqwbwhdU1IxF3SeTmpqYzD6r6Z9bWIKz?=
 =?iso-8859-1?Q?TW7gih9JCn/eXCDKRJy+uN3KE96VF0MRekHL4Qlhhnjfc20t7XD2vvJn3p?=
 =?iso-8859-1?Q?tPtnCx7qV9BPfDYrwZ08gWVIqb+4ZMoWMQS/79PMyjtKQIjeE9jzEMPapc?=
 =?iso-8859-1?Q?HlCulAnHsPqxJD5kQUWtiGB6hLOty/sSnux7/lI829jc1rrJMwbJmxY/VM?=
 =?iso-8859-1?Q?TOhsZ/U7JIF2PbnrkVxy6NQuRey5RWsvR46QooPkf+DmYymbBEnYz3Rsu6?=
 =?iso-8859-1?Q?5k3QxeugEdL4b3SRRqWzLH2hKGeYlwYsRa9uDJ2b8RnFi/SoBb/w09W2vz?=
 =?iso-8859-1?Q?QZ3zmDjXd44VtJ4yhV+U1W5gELtfofKVp0CuoR1UxchJy+qP0VRdoERQRk?=
 =?iso-8859-1?Q?/C0Sz0NtmbDPGJ5idNzYZ4rbZiDgcAOIOSzdB+Zj2rjDUDfUdhzDBVtvYH?=
 =?iso-8859-1?Q?50dW1uMXBu2bHKJJcv3ejwqKfINmfgn5eum2qoIXMah5jlsHayI5OhNUWt?=
 =?iso-8859-1?Q?lgsjnKrA31shExF+Pz05hFr4eHzH7SYndkU7KXS7w6lIOOO1wCEglnke3u?=
 =?iso-8859-1?Q?MKvxJvppqTNyBbeZX4YKJT1b0/NYaC/QpygvvEO8yyCGZeLe/zATg1JbDO?=
 =?iso-8859-1?Q?sISaus82r0EmVrLsdOZ3ef+6V4VN+lipbXgQuY9y7fUmdWTvh2Po6CE04d?=
 =?iso-8859-1?Q?xmTWZoRTs8asXyLMymtrY4NJhLg86o9fFWBH+gfD/BP8lK19ta7DAus5Hy?=
 =?iso-8859-1?Q?9V5x91EHmGC/BaXOjAXEh77tYSjJvQ/ns5Bo/5aiYszKKtQxNs/NisrNky?=
 =?iso-8859-1?Q?vybu56B6OAhQCjyKH6TyCpDMaLUmziuorKHrOPDiMEFQZPe3U1zdYWYsTQ?=
 =?iso-8859-1?Q?EYSvkK75bv6UJrrJhQpIAR+TFRgVx5ijVPUiMrG2CEy22rlDGj3EcPu6Wj?=
 =?iso-8859-1?Q?W6F2cS/RJYpwj4NPb1C1qGT1ZvQjL4kJWVHoAITH+uKPXGmlnbDTJBMg01?=
 =?iso-8859-1?Q?LIQ9d/OeRP6ccyfloDavZ0v+oPXz3UuV5P63pcPVViNkI+8xDayXrfMTgd?=
 =?iso-8859-1?Q?tc0Ko9yknX8UboXsAZ43mT9tEruc8NUwVv61DHH7qEeuNGYV8DMtRW2BxA?=
 =?iso-8859-1?Q?VYA1qbgdNrxd9nwyjxZ1XIQj+eKckGmbV+d5xfrScpB3OicXZV8XJs2aJm?=
 =?iso-8859-1?Q?86SBvTR01H3fyXn/eTf0lUgyOBRLDO9Cd605gXxGVquNEVxtb5Gc4NrF2Y?=
 =?iso-8859-1?Q?kODVscmWJ38mN90vjdKkbgSj5EO7qVUeqKSmoAc0GkqjEokM3GMuCO/j2B?=
 =?iso-8859-1?Q?OzQMOJOT28ZeLme7k+RrwOSXZSXfsll/C9zv6NZAd9o2R8zYvpZZqgJhhG?=
 =?iso-8859-1?Q?MOSdyuPHOfumNjKMgPtZCjyEzEW1wd8grE6vS4feYKxhwMi982GskoI1cv?=
 =?iso-8859-1?Q?7KajFZEBzaya1u0ySCI0KgDiy7BmzHqtMOCv5KGiIPwPBygz5ybbiNXFWM?=
 =?iso-8859-1?Q?YSpMUwTUd2WQsVkw/ez9WZZQZH5aLLb2pEyNs8WWZQgrIHe4FA6WufuE6k?=
 =?iso-8859-1?Q?LGwiRivgmjZAWU7SP6BKXiTCedwYsCEiPJ+6E4s41T+MDbayPyuJiT8VfJ?=
 =?iso-8859-1?Q?Aez8y83JDFBhyoziB6g=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ef9e9d68-3287-4ff0-9dba-08dbd6ea2aef
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6239.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2023 12:42:24.4669
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kKyVZuqLR5k7PH1YhdJ7nVxox18Nmg9QufaDh9Q4q+BTMuPVosgSgXCPhBj5LNGlEtBtMoM/VdXP74amewA40gpM6PZ8yrwORqSmWDZBkbw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5769
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 27 Oct 2023 05:42:52 -0700 (PDT)

On 2023-10-24 at 12:26:31 +0300, Ilpo J?rvinen wrote:
>Resource id is acquired differently depending on CPU. AMD tests use id
>from L3 cache, whereas CPUs from other vendors base the id on topology
>package id. In order to support L2 CAT test, this has to be
>generalized.
>
>The driver side code seems to get the resource ids from cache ids so
>the approach used by the AMD branch seems to match the kernel-side
>code. It will also work with L2 resource IDs as long as the cache level
>is generalized.
>
>Using the topology id was always fragile due to mismatch with the
>kernel-side way to acquire the resource id. It got incorrect resource
>id, e.g., when Cluster-on-Die (CoD) is enabled for CPU (but CoD is not
>well suited for resctrl in the first place so it has not been a big
>issues if test don't work correctly with it).

"not been a big issues" -> "not been a big issue"?

"if test don't work correctly" -> "if test doesn't work correctly" / "if tests
don't work correctly"?

>
>Taking all the above into account, generalize the resource id
>calculation by taking it from the cache id and do not hard-code the
>cache level.

In x86/resctrl files group of CPUs sharing a resctrl resource is called a
domain. Because of that I think "resource id" terms should be substituted with
"domain id" to match core resctrl code.

>
>Signed-off-by: Ilpo J?rvinen <ilpo.jarvinen@linux.intel.com>
>---
> tools/testing/selftests/resctrl/resctrl.h     |  2 +-
> tools/testing/selftests/resctrl/resctrl_val.c |  4 +--
> tools/testing/selftests/resctrl/resctrlfs.c   | 31 ++++++++++++-------
> 3 files changed, 23 insertions(+), 14 deletions(-)
>

-- 
Kind regards
Maciej Wiecz?r-Retman