Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <84e1b40e-8001-4ab1-a883-679fdf01d586@intel.com>
Date:   Fri, 27 Oct 2023 15:08:43 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next] iavf: use iavf_schedule_aq_request() helper
Content-Language: en-US
To:     Petr Oros <poros@redhat.com>, <netdev@vger.kernel.org>
CC:     <jesse.brandeburg@intel.com>, <anthony.l.nguyen@intel.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <intel-wired-lan@lists.osuosl.org>,
        <linux-kernel@vger.kernel.org>
References: <20231027095102.499914-1-poros@redhat.com>
From:   Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <20231027095102.499914-1-poros@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3djekV3Wk9TbndXMFdlS1htOURQaWVWS1g1T1dEaHV1RUZaY21jTWUxL1ha?=
 =?utf-8?B?WndmekZhTGVkYktkRVJ0QVczRktWdFZqZWhTS1FhNSs2SWNOS1ZMVkkzdlNS?=
 =?utf-8?B?QWI1VldSdVd2VDliSFNGN1lNL0d4ZlM3REJFamtYTXE1Zm5ML2NVWE5sdTVw?=
 =?utf-8?B?S0xlRDRMVEtsV0phTVo2dzhmSjFndjMwb3hZS0Q5dEhmWFVSMWRNYXVLU0dZ?=
 =?utf-8?B?WUJMOHp5RUJtL1RMNDNZR1VWRDdWM1ZRb25seFZvUjVpbk96dGM0cXZacWY5?=
 =?utf-8?B?N1FzSm85eU81aGNFUGc5K3MzN1RLVlJwVXFlQ01aNWRxS3pNLzRyZ3BsWVJw?=
 =?utf-8?B?YkFJVEpYSmg3a3hsOVZyUFAyY09uVGVURDlQR0QyN0swVjYyanJDVVA4MmE0?=
 =?utf-8?B?UGtFamR6ZFg1REZxdzdwUGNYQWF2VXlFVTBOSlI1S2dPS0hrQkRPcmh0RURZ?=
 =?utf-8?B?MHVsS2R4MUMyYmdaN2R5VmxZT1g5M0xqTng2ai9UYTJhWXRIVDJrQ0ovYncz?=
 =?utf-8?B?dHdPWWZCbStHUmIvVWxFZTFoWDc0M3Y4Q1RvZDNLYzQxLzZsQXVSOThqZjF6?=
 =?utf-8?B?cE56UFpkUDZDMzAwMllnWHY4NmF3MkVRODNIMEhBS2xudjBFUFdyS01EV3Jx?=
 =?utf-8?B?cExGYWkvUmJuRUlxa25nSys0bjdSWHErOUhzZjIvQXdKM2ppd0wzMm1Fb2xu?=
 =?utf-8?B?WG9JdnY1UU4yRVFseTFQUjVSMXhWdHhQMWFNMjVodDljV3JvaVZ2MDQyKzVu?=
 =?utf-8?B?Y0lhSWF6a0Y1ZmNkUFRiQkYzL1FUanhkbS9RNTJ4NlhZRnBmUWFhSnM4UGVI?=
 =?utf-8?B?WEVNdm1LdVc2NThIWGcxRnhmRU1KUjRFRFRPZENCTnVOWkpmNXZpbFBENlpi?=
 =?utf-8?B?alZDUU9BY3A3b0lKM2tPNUpjOFVGeXdRSVNTQ052bTdhdHVTdjgzcjEyTUtK?=
 =?utf-8?B?ZnpPWjJ5cnl4eVZCaitYYmZ5UlN6QkhJMmJoc0twdFJEbk5FMG13bXZmMVZt?=
 =?utf-8?B?dTd0NkdNam5kcEdMZTJYcmtQb0Y4T0hVTnZzVzUzaEdvMDZyTmdwY0N4SHhC?=
 =?utf-8?B?WTRwbHMySlhTKzl5b2w5UVJ6YmJ6S0owZ2NnSmo0aFBBSGxjeE1wdG02RWFW?=
 =?utf-8?B?bWo5djNrZkhTZ2NRcVdNaklyeFRlVmhYbytEejZLMVRYdUg5TUhrcE1uOEhj?=
 =?utf-8?B?NFNUcEQyOE53UHFQMUxOa05aeUNseDVDS0Evb1UxSjdNL1g1VWtNVmNIN0pi?=
 =?utf-8?B?WVp1RHNZQTRnRWMybGlyc2tPYW5qNmc5NG9vejN3S3ZmeFBFVkNSQ2VMR3Zh?=
 =?utf-8?B?OFRLcEFhcVFsZEptRXEvcnB0RWg3cndrSktXdFExTkdkWWh5UzMrL3IwYVh4?=
 =?utf-8?B?dW9MMmdVQ2Y3UC9aa0dOUktwWjJtcnNFWFV0MDhXWmRCeU1hM0dGbEdRMW9m?=
 =?utf-8?B?a1I4blIyRzFsYVVuUjltb3ZLSytwditibHM2aVp4em1BSVQvRjY1bzJ6U2t4?=
 =?utf-8?B?STl5RnlndEl0bkFpeXRpUmhZWXdtd2kzbGFpelVHZGxZcEc4ODV4bGo0RUhO?=
 =?utf-8?B?VVBrNWlJZk1peXN1cGVLZkZvaWZIbHBvakxFL1dCT2Y5VkpSN0ZXZTV3bnli?=
 =?utf-8?B?c2gwcXlZWFJMem82MmJCTWIvbmpXdjlKOVJMN2xVM2FZSWNTUE02MjRwdysw?=
 =?utf-8?B?Y1BTU0xRUHdJZzUvUHBkVUFCbVJqUGFjMWdKcTZtUGlRQzhGRFJRUlRmMTE2?=
 =?utf-8?B?aEE0aWt3L2NUenlncFU4TFMzd0c3MjYxdEhxeXN5Unk3WklSdjJDQk1wYmJ1?=
 =?utf-8?B?RG5ZVU9DcmNPZVhVQXNBUnFEOFlVNkViTkdUNjFuRExmTWVpL3gzZjlXc3Jl?=
 =?utf-8?B?dC9BNmdBUXIyK3RTY01ReFE3aWJ1YkJWTEVtKzI3d09XQzVYY1poUGI0UEtY?=
 =?utf-8?B?Y2tFdzhkQ0JDdG84ZWpZR1lBUEJSR21SSXhnbXUyeVpMMlJjbnFSODhoWHRp?=
 =?utf-8?B?UFRZcEpJc2lYSmhIOWNXZ1FtVm9rNzJvTmJjdzUwWWFXTHJuMXFPZW1oK0pi?=
 =?utf-8?B?Z2NCcHN5bVFrT09GYnN5Wm92OW1KbXRva2VFV0ozbkE0SjhOcXhxUk0rOXFP?=
 =?utf-8?B?TmZuNUtIbVAxQkRlQVU5RjY0bmE4WDZyclpleENNRzYxZ3UwUVN3d3FxeXNk?=
 =?utf-8?B?VkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a0979b05-faed-4b5d-3911-08dbd6eddc45
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2023 13:08:49.6698
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Kr/puzpSyFoYOZT0ar+Xr+rM5oK9K2tF0OyGzo0l0Zcy385KkfHAhzJ/UP/9M7YVNc3vZM2m40VPOozyGzk28f1WQXzoUo+YSZcIeLbYqEc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5396
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 27 Oct 2023 06:09:11 -0700 (PDT)


On 27.10.2023 11:51, Petr Oros wrote:
> Use the iavf_schedule_aq_request() helper when we need to
> schedule a watchdog task immediately. No functional change.
> 
> Signed-off-by: Petr Oros <poros@redhat.com>
> ---

Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>

>  drivers/net/ethernet/intel/iavf/iavf_ethtool.c | 10 +++-------
>  drivers/net/ethernet/intel/iavf/iavf_main.c    | 15 +++++----------
>  2 files changed, 8 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_ethtool.c b/drivers/net/ethernet/intel/iavf/iavf_ethtool.c
> index 90397293525f71..fc8d75a30602cd 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_ethtool.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_ethtool.c
> @@ -1447,10 +1447,9 @@ static int iavf_add_fdir_ethtool(struct iavf_adapter *adapter, struct ethtool_rx
>  	iavf_fdir_list_add_fltr(adapter, fltr);
>  	adapter->fdir_active_fltr++;
>  	fltr->state = IAVF_FDIR_FLTR_ADD_REQUEST;
> -	adapter->aq_required |= IAVF_FLAG_AQ_ADD_FDIR_FILTER;
>  	spin_unlock_bh(&adapter->fdir_fltr_lock);
>  
> -	mod_delayed_work(adapter->wq, &adapter->watchdog_task, 0);
> +	iavf_schedule_aq_request(adapter, IAVF_FLAG_AQ_ADD_FDIR_FILTER);
>  
>  ret:
>  	if (err && fltr)
> @@ -1481,7 +1480,6 @@ static int iavf_del_fdir_ethtool(struct iavf_adapter *adapter, struct ethtool_rx
>  	if (fltr) {
>  		if (fltr->state == IAVF_FDIR_FLTR_ACTIVE) {
>  			fltr->state = IAVF_FDIR_FLTR_DEL_REQUEST;
> -			adapter->aq_required |= IAVF_FLAG_AQ_DEL_FDIR_FILTER;
>  		} else {
>  			err = -EBUSY;
>  		}
> @@ -1491,7 +1489,7 @@ static int iavf_del_fdir_ethtool(struct iavf_adapter *adapter, struct ethtool_rx
>  	spin_unlock_bh(&adapter->fdir_fltr_lock);
>  
>  	if (fltr && fltr->state == IAVF_FDIR_FLTR_DEL_REQUEST)
> -		mod_delayed_work(adapter->wq, &adapter->watchdog_task, 0);
> +		iavf_schedule_aq_request(adapter, IAVF_FLAG_AQ_DEL_FDIR_FILTER);
>  
>  	return err;
>  }
> @@ -1660,7 +1658,6 @@ iavf_set_adv_rss_hash_opt(struct iavf_adapter *adapter,
>  			rss_old->hash_flds = hash_flds;
>  			memcpy(&rss_old->cfg_msg, &rss_new->cfg_msg,
>  			       sizeof(rss_new->cfg_msg));
> -			adapter->aq_required |= IAVF_FLAG_AQ_ADD_ADV_RSS_CFG;
>  		} else {
>  			err = -EEXIST;
>  		}
> @@ -1670,12 +1667,11 @@ iavf_set_adv_rss_hash_opt(struct iavf_adapter *adapter,
>  		rss_new->packet_hdrs = hdrs;
>  		rss_new->hash_flds = hash_flds;
>  		list_add_tail(&rss_new->list, &adapter->adv_rss_list_head);
> -		adapter->aq_required |= IAVF_FLAG_AQ_ADD_ADV_RSS_CFG;
>  	}
>  	spin_unlock_bh(&adapter->adv_rss_lock);
>  
>  	if (!err)
> -		mod_delayed_work(adapter->wq, &adapter->watchdog_task, 0);
> +		iavf_schedule_aq_request(adapter, IAVF_FLAG_AQ_ADD_ADV_RSS_CFG);
>  
>  	mutex_unlock(&adapter->crit_lock);
>  
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index b3434dbc90d6fe..7217ba018f6bbf 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> @@ -1060,13 +1060,12 @@ static int iavf_replace_primary_mac(struct iavf_adapter *adapter,
>  	 */
>  	new_f->is_primary = true;
>  	new_f->add = true;
> -	adapter->aq_required |= IAVF_FLAG_AQ_ADD_MAC_FILTER;
>  	ether_addr_copy(hw->mac.addr, new_mac);
>  
>  	spin_unlock_bh(&adapter->mac_vlan_list_lock);
>  
>  	/* schedule the watchdog task to immediately process the request */
> -	mod_delayed_work(adapter->wq, &adapter->watchdog_task, 0);
> +	iavf_schedule_aq_request(adapter, IAVF_FLAG_AQ_ADD_MAC_FILTER);
>  	return 0;
>  }
>  
> @@ -1284,10 +1283,9 @@ static void iavf_up_complete(struct iavf_adapter *adapter)
>  
>  	iavf_napi_enable_all(adapter);
>  
> -	adapter->aq_required |= IAVF_FLAG_AQ_ENABLE_QUEUES;
>  	if (CLIENT_ENABLED(adapter))
>  		adapter->flags |= IAVF_FLAG_CLIENT_NEEDS_OPEN;
> -	mod_delayed_work(adapter->wq, &adapter->watchdog_task, 0);
> +	iavf_schedule_aq_request(adapter, IAVF_FLAG_AQ_ENABLE_QUEUES);
>  }
>  
>  /**
> @@ -1439,8 +1437,7 @@ void iavf_down(struct iavf_adapter *adapter)
>  			adapter->aq_required |= IAVF_FLAG_AQ_DEL_ADV_RSS_CFG;
>  	}
>  
> -	adapter->aq_required |= IAVF_FLAG_AQ_DISABLE_QUEUES;
> -	mod_delayed_work(adapter->wq, &adapter->watchdog_task, 0);
> +	iavf_schedule_aq_request(adapter, IAVF_FLAG_AQ_DISABLE_QUEUES);
>  }
>  
>  /**
> @@ -2340,10 +2337,8 @@ iavf_set_vlan_offload_features(struct iavf_adapter *adapter,
>  		}
>  	}
>  
> -	if (aq_required) {
> -		adapter->aq_required |= aq_required;
> -		mod_delayed_work(adapter->wq, &adapter->watchdog_task, 0);
> -	}
> +	if (aq_required)
> +		iavf_schedule_aq_request(adapter, aq_required);
>  }
>  
>  /**