Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Fri, 27 Oct 2023 14:36:00 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Su Hui <suhui@nfschina.com>
Cc:     Jonathan Cameron <Jonathan.Cameron@Huawei.com>, lars@metafoo.de,
        jean-baptiste.maneyrol@tdk.com, chenhuiz@axis.com,
        andy.shevchenko@gmail.com, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] phy: mapphone-mdm6600: fix an error code problem in
 inv_mpu6050_read_raw
Message-ID: <20231027143600.2dd74f78@jic23-huawei>
In-Reply-To: <bccca54f-5eb8-83ba-17ad-6cb312aa6ea5@nfschina.com>
References: <7f81d365-0440-de01-8be4-9c8d3ab9d69c@nfschina.com>
        <bccca54f-5eb8-83ba-17ad-6cb312aa6ea5@nfschina.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 23 Oct 2023 11:29:30 +0800
Su Hui <suhui@nfschina.com> wrote:

> On 2023/10/23 09:33, Su Hui wrote:
> > On 2023/10/20 23:55, Jonathan Cameron wrote: =20
> >> I'm not sure why inv_mpu6050_sensor_show() doesn't return
> >> the actual error code from the regmap_bulk_read() and instead=20
> >> replaces it
> >> with -EINVAL.=C2=A0 Given you are tidying up this related issues perha=
ps=20
> >> change
> >> that as well?
> >>
> >> static int inv_mpu6050_sensor_show(struct inv_mpu6050_state *st, int=20
> >> reg,
> >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int axis, int *val)
> >> {
> >> =C2=A0=C2=A0=C2=A0=C2=A0int ind, result;
> >> =C2=A0=C2=A0=C2=A0=C2=A0__be16 d;
> >>
> >> =C2=A0=C2=A0=C2=A0=C2=A0ind =3D (axis - IIO_MOD_X) * 2;
> >> =C2=A0=C2=A0=C2=A0=C2=A0result =3D regmap_bulk_read(st->map, reg + ind=
, &d, sizeof(d));
> >> =C2=A0=C2=A0=C2=A0=C2=A0if (result)
> >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return -EINVAL;
> >> //Make this return result; =20
> >
> > Sure, I will tidy up this, Thanks for your suggestion! =20
>=20
> I'm not sure=C2=A0 whether the caller could handler this=C2=A0 when retur=
n=20
> 'result' rather than '-EINVAL'.
>=20
> This is not a big problem, maybe we shouldn't modify this code.

If the ultimate caller (userspace in this case) doesn't handle other
error codes it won't work with lots of other devices and is broken.

So I doubt any code is that fragile. If we get a report of a regression
we can look into whether it's sensible to resolve it.

So fine to change this, but could be a separate patch.

J
>=20
> Su Hui
>=20