Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Fri, 27 Oct 2023 10:35:55 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Yang Jihong <yangjihong1@huawei.com>
Cc:     Namhyung Kim <namhyung@kernel.org>, peterz@infradead.org,
        mingo@redhat.com, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, jolsa@kernel.org,
        irogers@google.com, adrian.hunter@intel.com,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf evsel: Rename evsel__increase_rlimit to
 rlimit__increase_nofile
Message-ID: <ZTu8u3bgNCOhTx8U@kernel.org>
References: <20231023033144.1011896-1-yangjihong1@huawei.com>
 <ZTrCS5Z3PZAmfPdV@kernel.org>
 <CAM9d7cjhSSV+18ZCHLdTFpMM+MmpoDkYSGjUa5JKZp02Kx9XRw@mail.gmail.com>
 <3458c302-8c43-51e5-f45b-c18657fa7015@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3458c302-8c43-51e5-f45b-c18657fa7015@huawei.com>
Precedence: bulk

Em Fri, Oct 27, 2023 at 10:43:32AM +0800, Yang Jihong escreveu:
> Sorry, only rename helper and no function change.
> I didn't consider the scenario that might affect test python.
 
> I've submitted a fix that can be used if needed:
 
> https://lore.kernel.org/lkml/20231027023028.1106441-1-yangjihong1@huawei.com/
 
> Also, can we consider identifying this problem at the stage of compiling the
> perf tool?

Yes, I have:

$ alias m='rm -rf ~/libexec/perf-core/ ; make -k CORESIGHT=1 O=/tmp/build/$(basename $PWD) -C tools/perf install-bin && perf test python'
 
And use the 'm' alias to build perf.

I also run 'perf test' before sending patches upstream, in addition to:

make -C tools/perf build-test

I encourage everybody to do the same.

Additionally I run a long list of container tests on dozens of distros,
but those should really be running on some CI system :-\

- Arnaldo