Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <4151ab3e-ee0d-44d0-adc6-e811b7d3c60a@intel.com>
Date:   Fri, 27 Oct 2023 15:36:16 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] cxgb4: Fix missing error code in
 cxgb4_port_mirror_alloc()
Content-Language: en-US
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        <rajur@chelsio.com>
CC:     <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        Abaci Robot <abaci@linux.alibaba.com>
References: <20231027040057.67810-1-jiapeng.chong@linux.alibaba.com>
From:   Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <20231027040057.67810-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WHluWWRyUVpLd2xnU3lRQ3pyZDE4T3U3WGlGSXE4WUc2YVhqbURiYi92SWhz?=
 =?utf-8?B?Qm5TMnhjVThhOWlYc1RyUHhmN0RsNFV0Y3BwSFN4ZnBLYndCcUpiVWdxYlN2?=
 =?utf-8?B?Y2ROVDBhZVNWdXJpVGZWYVRXWjlUN1I3YlZxZWJPTE01OVN5VVR3ZnE0NEts?=
 =?utf-8?B?VjJMS0tpQWYvTWNmcXQ2SUk4eXhrZG0xSlF1NFFmYS9odEVsOTEwdkN5eElu?=
 =?utf-8?B?UjFXTGdnUktJWGFwajNZYnJsMWU4eld5Z29OQ0dpZGtlQUVVbmVFUCs1S0VF?=
 =?utf-8?B?U0syVnBydXpwcGZ2ak5sYVlTanF5ZXFubHRMdFdZeGVZN09pZFBpZEZqcEQ2?=
 =?utf-8?B?VU0yS2hlRDhVM3ZuZTNMc0plNUVQNEgraTIvckpLZWNXSUJtN1VKODVZTzlP?=
 =?utf-8?B?YzNFd1hqT3pDRjExZFhRK0tnNEVyN01tVjNZNi9UcWs2aFJUUVgzV2dzWmlB?=
 =?utf-8?B?ZjR2VmdjSVMrMEdhU0t2M1E5b2tFRzZWMEFKbVJrSEc0S2NzL0JHck9qSEdG?=
 =?utf-8?B?VExEMDNnNzJLbGtOem1ONEsxV0d1cDZuODZpYzlBZ1pVVjFmY09TTXIxdllj?=
 =?utf-8?B?MzVnTDg4UkFBT0c3RDVMd2xTY1B2TEYwWkV1RjhNQzU0THp0NW13WU00K3hY?=
 =?utf-8?B?SlNpT01NOU92MEN6WjBqUXJxbG1SUkZpSWpUcHkwR0V0ZEFQVzZIZ2Uzdm9y?=
 =?utf-8?B?WnhSV2h0RHg2TExHeUQ4dUVjbmwzcDZKajNiNTQzZWR3aEhWMENpU3RJNHQz?=
 =?utf-8?B?aUdMNFZoaWFDTVQ3dDVSdklkUG5qWnFSZUZ1dWY1UGErbVBVMmFVMGw3cHhQ?=
 =?utf-8?B?QXlPZ0htUDNiY21hWW1oRHhwVkcwVHFXa2dvYm1Sd24wNUpSRDJuVEEvdGFN?=
 =?utf-8?B?YXphNWJjS3F4a1ZJdExsQ0EzMTdXUWdNTVc0c2FtSXdmQjFia3Q5YWNTQXoy?=
 =?utf-8?B?RG1XZm04N29SOWJ2RU00SlFrL3krUHFEZFFZdEg4TU9lOG5tRjRzMzFPSUdy?=
 =?utf-8?B?TEYrSVRtTXhNQm5YY2lhRjR0OTNMOHpZWWpjVHh3dzdMSjNGWmxCZXRqWEYw?=
 =?utf-8?B?cGpmTU45c252R2JReUZSNk9jSGZZZW1EdEpWd2R3bURvWDdpZCtJTk1hOUwy?=
 =?utf-8?B?bnpjTlM2Y0ovaWkvMktJRVFzbVA1UXpwd0RKeEp2dFZRQTlwd25YN21pOUxH?=
 =?utf-8?B?MUNBdytzL0hNTEl4RFNGNEpLSGgxbWtmeWlJd0JSL1V0cDJGT2hrUFhrNHdl?=
 =?utf-8?B?WmdtWDJtNDgrR0lqMkY4OS9mdm90d2pXekZGUWgvd2t4SXFnRGtxYTlpcFlm?=
 =?utf-8?B?SWoycENPQXcybEhsWWpsQlZRQkhYcXN5bm41QnpqMWorQ0s1dTF3UzMxTTFJ?=
 =?utf-8?B?L1FGdkFMYkxaVm44Nnl0akwvR2VvSnB2YkNDY0pSdXBYT0FzYmdwY2Zaczkx?=
 =?utf-8?B?WnZZWVo4eFJXWE5TZFppZW96cXRFMWdyNlJ0SlJaU2ZMeGZmcERUSzdDUng5?=
 =?utf-8?B?NzRsOFEweCsvaWYveDFKMEFDQUVSSkl3eGpuekFKSTBPV2EybldaV0c1OG9r?=
 =?utf-8?B?RFVWcUMrSWUwL2pOOUVOYjhEYkRqcnlia01WTkthVmxQYUM4Y0VIL2c1MXVu?=
 =?utf-8?B?UnMzTElGb3kvbmNzWGlqUHJvSWpFUDJ3Tmt4c2dJNk9iRmNVaFNMU2NEYXNr?=
 =?utf-8?B?YVNoYTcvVU1adVlzQ1VtVG80eVlxditqSUNtQTV6QkZJVnFmb1hJVWhlNXBq?=
 =?utf-8?B?VElHbzNlNjBVTkx2Z0o4ZnZrVFBiK0Q2OC9WaDVCeVI0Uit0R3VCNm0weFZK?=
 =?utf-8?B?UTNXT3lKQjc2QXczWDVRS3NnaWJOUCtEWmVaNkhXNGhOWEw4QlIrRHpjR00v?=
 =?utf-8?B?MVcxT2Q0TmF0UWRTYnpaTEdoQ0xqL2QvSEt3dFhYWU5RUndxZ1JMMzhhMmFU?=
 =?utf-8?B?eGt3WDFvY0dvd3U4KzVMM0lFbXJRMFBjZUdUSTNnaW9nWUd5V0ZacEx3bExG?=
 =?utf-8?B?cm5zTzM5dDRVblQ4bjRrV1Z5OFc5Rm5lbThTcjFJK0JaYStlSWQ0alpmNmRp?=
 =?utf-8?B?QWFaYlBIb1liTXlYaUNJUWJpSHJLazg2K09rZjFER3ozQVFRSmhVbDRBcVB5?=
 =?utf-8?B?blByWnhaaWpNVjR3WDZPa3hWc0I3K2UyNW16aHZHVnA3V1JnMXVCc0IvRHZz?=
 =?utf-8?B?MGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bd894489-453d-4fdc-ea48-08dbd6f1b4d0
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2023 13:36:21.5046
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Y1Nw+PhbB+Em6mvu3NMXdBaGsC7I6jxFFx18cLJ27rgWGAGhJPAMKKgtNtY50/OiFKgMasUfvYqXid+NScwFCQl0VLbR+oNrwxjLKrM+Gmc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6472
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 27 Oct 2023 06:37:24 -0700 (PDT)


On 27.10.2023 06:00, Jiapeng Chong wrote:
> The error code is missing in this code scenario, add the error code
> '-EINVAL' to the return value 'ret'.
> 
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:1525 cxgb4_port_mirror_alloc() warn: missing error code 'ret'.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7063
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
> index 2eb33a727bba..e59e199184f4 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
> @@ -1522,6 +1522,7 @@ int cxgb4_port_mirror_alloc(struct net_device *dev)
>  	mutex_lock(&pi->vi_mirror_mutex);
>  	if (pi->viid_mirror) {
>  		pi->vi_mirror_count++;
> +		ret = -EINVAL;

I'm not sure we should return error here. This looks like we're adding a new subscriber to
the mirror action so the function should return 0 (ret is initialized to 0). viid_mirror exists,
we're just incrementing the count of its users.

>  		goto out_unlock;
>  	}
>