Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Fri, 27 Oct 2023 15:38:18 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Sean Young <sean@mess.org>
Cc:     linux-media@vger.kernel.org, linux-pwm@vger.kernel.org,
        Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Florian Fainelli <florian.fainelli@broadcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/4] pwm: bcm2835: allow pwm driver to be used in
 atomic context
Message-ID: <20231027133818.f5zpeqxfw7ghs7sk@pengutronix.de>
References: <cover.1698398004.git.sean@mess.org>
 <0b35ca65d6f4d53d3beb1411a64970ea5f969060.1698398004.git.sean@mess.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="2iiuhlc2f5sp65et"
Content-Disposition: inline
In-Reply-To: <0b35ca65d6f4d53d3beb1411a64970ea5f969060.1698398004.git.sean@mess.org>
Precedence: bulk


--2iiuhlc2f5sp65et
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Sean,

On Fri, Oct 27, 2023 at 10:20:46AM +0100, Sean Young wrote:
> +	pc->rate =3D clk_get_rate(pc->clk);
> +	if (!pc->rate) {
> +		dev_err(pc->dev, "failed to get clock rate\n");
> +		ret =3D -EINVAL;

Other error paths in this driver use dev_err_probe(). The most compact
way here would be:

	ret =3D dev_err_probe(pc->dev, -EINVAL, "....");

but maybe

	ret =3D -EINVAL;
	dev_err_probe(pc->dev, ret, "...");

is a bit easier to parse for a human?!

Otherwise looks reasonable.

Thanks,
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--2iiuhlc2f5sp65et
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmU7vUoACgkQj4D7WH0S
/k47IAgApc4G3nyl4kSKMOLLW/jy5u3nlGR3Cbn/NFdCUikfU5kiiAfpFpgsLz8C
BMmJCw3XmK78YqMX+1v3Zg1MiCCkTfuLFWIFtZWe3BUunh2fVkKtzNuFpZBq7nrd
D7YHl08Ph2teuVbMYQbGEzpTzQFgHMTJmHZIGDj7VTSkv/TV2nmrX02kzSh6rYnJ
iAyqRTGH2HTeMDj4vpbqmki2rEJT+lIOR3bMAyoMiWVlcvv4nZdFKZOWPl8OAZ11
Ci+Uh66I/G+crBuxNBmpISvc0xTP3v0ab5nei1rcl5cNJZRRAk5TlPiUvooKhnTX
aNZkwf1ewQ17Khp1W4V4XTnI1+nv5Q==
=oHUW
-----END PGP SIGNATURE-----

--2iiuhlc2f5sp65et--