Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Fri, 27 Oct 2023 14:42:34 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Angel Iglesias <ang.iglesiasg@gmail.com>,
        linux-iio@vger.kernel.org, Biju Das <biju.das.jz@bp.renesas.com>,
        linux-kernel@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
        Phil Elwell <phil@raspberrypi.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Uwe =?UTF-8?B?S2xlaW5lLUvDtm5p?= =?UTF-8?B?Zw==?= 
        <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH v2 4/5] iio: pressure: bmp280: Allow multiple chips id
 per family of devices
Message-ID: <20231027144234.0ad6c7b6@jic23-huawei>
In-Reply-To: <ZTZYNjq/1X95ijXh@smile.fi.intel.com>
References: <cover.1697994521.git.ang.iglesiasg@gmail.com>
        <eade22d11e9de4405ea19fdaa5a8249143ae94df.1697994521.git.ang.iglesiasg@gmail.com>
        <ZTZYNjq/1X95ijXh@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 23 Oct 2023 14:25:42 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Sun, Oct 22, 2023 at 07:22:20PM +0200, Angel Iglesias wrote:
> > Improve device detection in certain chip families known to have various
> > chip ids.
> > When no known ids match, gives a warning but follows along what device
> > said on the firmware and tries to configure it.  
> 
> I would rephrase it a bit:
> 
> "Improve device detection in certain chip families known to have
> various chip IDs. When no ID matches, give a warning but follow
> along what device said on the firmware side and try to configure
> it."
> 
> ...
> 
> > +	for (i = 0; i < data->chip_info->num_chip_id; i++) {
> > +		if (chip_id == data->chip_info->chip_id[i]) {
> > +			dev_info(dev, "0x%x is a known chip id for %s\n", chip_id, name);
> > +			break;
> > +		}  
> 
> > +		dev_warn(dev, "chip id 0x%x does not match known id 0x%x\n",
> > +			 chip_id, data->chip_info->chip_id[i]);  
> 
> If the matching ID is not the first one, user will have an unneeded warning here.

Could be a dev_dbg() but I'd just drop it entirely.


> 
> >  	}  
>