Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Fri, 27 Oct 2023 14:57:53 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Ramona Gradinariu <ramona.gradinariu@analog.com>,
        <nuno.sa@analog.com>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>
Subject: Re: [PATCH 3/3] dt-bindings: adis16460: Add
 'spi-cs-inactive-delay-ns' property
Message-ID: <20231027145753.528b6308@jic23-huawei>
In-Reply-To: <20231024132705.00003cf4@Huawei.com>
References: <20231023123542.582392-1-ramona.gradinariu@analog.com>
        <20231023123542.582392-4-ramona.gradinariu@analog.com>
        <b7011f02-a412-4642-862d-c2df88ae316b@linaro.org>
        <20231024132705.00003cf4@Huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 24 Oct 2023 13:27:05 +0100
Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote:

> On Mon, 23 Oct 2023 15:22:30 +0200
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> 
> > On 23/10/2023 14:35, Ramona Gradinariu wrote:  
> > > Add 'spi-cs-inactive-delay-ns' property.    
> > 
> > This we see from the diff. Commit should explain: Why?
> >   
> > > 
> > > Signed-off-by: Ramona Gradinariu <ramona.gradinariu@analog.com>
> > > ---
> > >  Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> > > index 4e43c80e5119..3691c0be4f9d 100644
> > > --- a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml
> > > @@ -25,6 +25,11 @@ properties:
> > >  
> > >    spi-cpol: true
> > >  
> > > +  spi-cs-inactive-delay-ns:
> > > +    minimum: 16000
> > > +    description:
> > > +      If not explicitly set in the device tree, the driver will set it to 16us.    
> > 
> > Why do you even need it here?  
> 
> Along side that, if you have a default
> default: xxxx
> rather than in the description.

ah. I didn't get Krzysztof's reply to patch 1 for some reason where he already
said this... 

Anyhow, I've nothing to add to comments on v2.  Will aim to pick up v3.

> 
> 
> > 
> > Best regards,
> > Krzysztof
> > 
> >   
>