Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Fri, 27 Oct 2023 15:19:40 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Elad Nachman <enachman@marvell.com>, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        andrew@lunn.ch, gregory.clement@bootlin.com,
        sebastian.hesselbarth@gmail.com, pali@kernel.org,
        mrkiko.rs@gmail.com, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        cyuval@marvell.com
Subject: Re: [PATCH v3 2/3] dt-bindings: arm64: dts: add dt-bindings for ac5x
 rd carrier
Message-ID: <20231027-opposite-frostily-b41eb861c8a1@spud>
References: <20231026084735.3595944-1-enachman@marvell.com>
 <20231026084735.3595944-3-enachman@marvell.com>
 <1075eedc-3e7e-4070-8cf2-ae63513fd764@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="9sK3/vJ3qUaD1UFK"
Content-Disposition: inline
In-Reply-To: <1075eedc-3e7e-4070-8cf2-ae63513fd764@linaro.org>
Precedence: bulk


--9sK3/vJ3qUaD1UFK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 27, 2023 at 01:09:58PM +0200, Krzysztof Kozlowski wrote:
> On 26/10/2023 10:47, Elad Nachman wrote:
> > From: Elad Nachman <enachman@marvell.com>
> >=20
> > Add dt bindings for AC5X RD COM Express Type 7 carrier board.
> > This board will Accept a CN9131 COM Express Type 7 CPU module.
> >=20
> > Signed-off-by: Elad Nachman <enachman@marvell.com>
> > ---
> >  .../devicetree/bindings/arm/marvell/armada-7k-8k.yaml     | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >=20
> > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k=
=2Eyaml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> > index 52d78521e412..71bc94047d1b 100644
> > --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> > @@ -60,4 +60,12 @@ properties:
> >            - const: marvell,armada-ap807-quad
> >            - const: marvell,armada-ap807
> > =20
> > +      - description: AC5X RD COM Express Carrier for Armada CN9131 SoC=
 with one external CP
> > +        items:
> > +          - const: marvell,ac5x_rd_carrier
>=20
> No underscores in compatibles.

Oh shit, I didn't notice that somehow. Un-acked until that's removed.

> Do you see them anywhere? Please use
> existing, recent code as start of your contributions, not something
> buggy 5 years old.
>=20
> Best regards,
> Krzysztof
>=20

--9sK3/vJ3qUaD1UFK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZTvG/AAKCRB4tDGHoIJi
0u6iAQCPzo2UK8Sm6+yYf/oKferrIQShLCKKh7+EHiYs9GOmYQEAsZGuIcYaRi6s
bctUdaidhLu5pLyx5AAQHHJlBxtZGgU=
=RpIb
-----END PGP SIGNATURE-----

--9sK3/vJ3qUaD1UFK--