Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760912AbXKULeT (ORCPT ); Wed, 21 Nov 2007 06:34:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755965AbXKULeL (ORCPT ); Wed, 21 Nov 2007 06:34:11 -0500 Received: from moutng.kundenserver.de ([212.227.126.187]:59657 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755841AbXKULeJ (ORCPT ); Wed, 21 Nov 2007 06:34:09 -0500 From: Andre Haupt To: linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, drzeus-mmc@drzeus.cx, nico@cam.org, Andre Haupt Subject: [PATCH] sdio_uart: fix sign of paramter status in sdio_uart_receive_chars() Date: Wed, 21 Nov 2007 12:33:45 +0100 Message-Id: <11956448251191-git-send-email-andre@bitwigglers.org> X-Mailer: git-send-email 1.4.4.4 In-Reply-To: n References: n X-Provags-ID: V01U2FsdGVkX18iCmhP+aHckBtVjUhjyIbqigKQcsPBIkruluM KFVGBEyOXS6xfKGWNWf2OE9gQ7dV8IpUIbUs2GqwXxS5FhNoJh TBg5l8IkwVmBT6ms72I2/7nxl2csEiPIRqh0HWJtLQ= Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1159 Lines: 31 I think, the status paramter should be unsigned. Is this correct? This also fixes a sparse warning about different signedness. Only compile tested, because i do not have the hardware. From: Andre Haupt Signed-off-by: Andre Haupt --- drivers/mmc/card/sdio_uart.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/card/sdio_uart.c b/drivers/mmc/card/sdio_uart.c index d552de6..eeea84c 100644 --- a/drivers/mmc/card/sdio_uart.c +++ b/drivers/mmc/card/sdio_uart.c @@ -386,7 +386,7 @@ static void sdio_uart_stop_rx(struct sdio_uart_port *port) sdio_out(port, UART_IER, port->ier); } -static void sdio_uart_receive_chars(struct sdio_uart_port *port, int *status) +static void sdio_uart_receive_chars(struct sdio_uart_port *port, unsigned int *status) { struct tty_struct *tty = port->tty; unsigned int ch, flag; -- 1.4.4.4 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/