Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <26b07823-a560-4bb1-b37b-70752ceff469@wolfvision.net>
Date:   Fri, 27 Oct 2023 17:24:23 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] iio: tmag5273: fix temperature offset
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     Gerald Loacker <gerald.loacker@wolfvision.net>,
        Lars-Peter Clausen <lars@metafoo.de>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20231023-topic-tmag5273x1_temp_offset-v1-1-983dca43292c@wolfvision.net>
 <20231027151507.2eac395c@jic23-huawei>
Content-Language: en-US
From:   Javier Carrasco <javier.carrasco@wolfvision.net>
In-Reply-To: <20231027151507.2eac395c@jic23-huawei>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWRkU1J0NXg4Q21wOWRaQmV2OGhBQUc3REhtN0g1RzV4aWhuVXArVHFjaWM3?=
 =?utf-8?B?ODdjSDNmenZhRUJ0L3haaTNKa1dXczlieXQrOERadWk2WWhPZlFkTUpybkdo?=
 =?utf-8?B?Zm5FanpEN3N0cHptZStzTGhjYVpma1pjdTBsNFJvYjV0b0YveHl6REVxdWFq?=
 =?utf-8?B?b0pHeTRzUUluNGFITmRSemEvRStaTmJVd04zN2x3bzVoZE0wTnVhRG9PTjJs?=
 =?utf-8?B?citSeVF4bGRzZmU5ZUxhVDd5Y21XckNGNTVOSmpGc3g2Ly9BOTZhSFBzbmJS?=
 =?utf-8?B?Qm9OTWRHZzBwVWt5VXk5OVJIcjJGcG13NnNQcGE1NEpqT01EaWRYNTZmL1pz?=
 =?utf-8?B?N1liM0VHQXBJR200eFdqcGgxbVcwT0pwVmZoakNBc0ZKbjRaU09FNkFzYTNS?=
 =?utf-8?B?SGZTbTBkdm1QQmljRnRJc3NvV3hHdUFqcnJWYzRnRXRtTCtQY1lzeGpURDYw?=
 =?utf-8?B?THJVaGpjRHc1TlZocDNsS1Q1cmVIV1pqRngwcC9HTEpNWVJXRXpML08zWngr?=
 =?utf-8?B?TVFsbTk4VEVpeGZreWZUb2Y0NXRYU0pBOSsrOWVVVFRYM0hxN0h4VE9WZ29C?=
 =?utf-8?B?WUZlUmVNdWtFdXdHelhjRHpTc1AxTEwrclBscmt5QjlodDdKR2dNRDc3bkYz?=
 =?utf-8?B?VVVZeDV2bW01M01LaSt2WndNbjNmNlczVzh5YnE1Sm5NUFkxekg1SFRvb1Zw?=
 =?utf-8?B?eDdyVm1rZnFXK2R3eVNPK1poeVJtUTAydG1PNFc1VWoxTW9hajR1b21RazMv?=
 =?utf-8?B?OWtkRzlXQzYxY251Wm90Qzh4Vk4zMVg3OGVjNk4vUjQrOGxoVWVZKy9qbUh0?=
 =?utf-8?B?SVV0UkMwckhzZkVNOEdBeFJUUmppSllDQkxMZ0ZTQzhVUWo0RmxQdjdESWV2?=
 =?utf-8?B?dW1nTGprNjEvZ3Ntcy9pYUdWb3FOdERMOHJoU2gxRW1BTDlnSzhta3lBSTcy?=
 =?utf-8?B?QlFVTUNlSWpWNUpTYitiRk5laWc0YUFBSGxGS2VqZFBRVlBhSlJjVzF0cVdT?=
 =?utf-8?B?d1p5cC95RGhUSjNUOHVYRndaQlV6MmZPSmxKTFNnRGQwSkVya2VyT2txTjdV?=
 =?utf-8?B?Q3cwUTNTVlgyUEZYZDZkU3dRdjNjK1FTRlhERldvTVNINkFnZ3BKbmYvUmFF?=
 =?utf-8?B?anRUbzBiZlN5YlNsOW9qZElzSk04aEpBRzNmNlV1RlZjeGdkZTVScDlCUTNo?=
 =?utf-8?B?RktJR0xHcWMwQjk4NlI4YnlrRUVJM05vUzZXbjMzQitZaWM3WUwyazBBWmFr?=
 =?utf-8?B?TWV6Y3VwYkdMaStZZkMvNzdLZ0xiY1lDQ2JRdWdaVDZnVVZZa3BYeFRianVw?=
 =?utf-8?B?V0xNOFlqb3JtOFJiSVAxUVYyRFV0ZXM5dkJxY2FRQ2VaUnpjTjhuajY5U2Iw?=
 =?utf-8?B?ZENWK1FiRFR5VzVlS2NjWVcxUFZhNU54a3hxZzdIaWJDbHZJQ3V3eTRoMWdr?=
 =?utf-8?B?RFYvTmJYWEVad0tRQlgydVJ1NTZFOXVoV0krWVJabm9BVzN2R0V0RG1vTkNt?=
 =?utf-8?B?TEhoZ1ZZQXdvKzFFdGl0Q1BOS3RuWDg3bzAwSm01TnlkV3pCRllJL1BuV3RY?=
 =?utf-8?B?NytMSVN4bmhkNHV2dUxYUlBTNFM0V1FMdk94L2gvM2VGeHZOSkU3M3Y5OUM0?=
 =?utf-8?B?ellzVmRZYlg4UERGSkllRzhnZHkyV1l1aXp4SCsrV0NVZzlrY2pvZ3FYcUlJ?=
 =?utf-8?B?SnhZMGR1dzFlMkhMN0RHL0xHcTF1bFJjSkNWZElobno4azQ5SFFyY09aeFFD?=
 =?utf-8?B?M3RpODFkZjhudVNteUFRNldaTUlsclArUE1PbHdVcVVuU1RjWHNPL3hqUzU1?=
 =?utf-8?B?dHRNbStQU0tsSkE0eDMrS08yYzJDZ0g3b3Q0aXdUQXFiWGNHbnZja3lzVkUv?=
 =?utf-8?B?d2duTkFMNjFjZ1NObnJNaExsZ0hkVDhzV0h1aXhGOHN2L0hwcEJjTTBNSWE0?=
 =?utf-8?B?QzFjclRtYUZGTmdFMFRPRXdhVEJkUy9ROWhSZDhyUUtUZjdqbURLbkRpdVRF?=
 =?utf-8?B?OVU5NXVVSERid045RUw2SnBxWm9FQitoOGNaTnFDeEZSOHlZZzlMeGNkY0Np?=
 =?utf-8?B?YjRMRGJKNzNqWTl6cG9GdE1DMWRFQ25IdlFLakxxL21HWEVZRno4Z1JpZkxK?=
 =?utf-8?B?dS82NTR1dTYzZllBVkxNS1M3MzAxdXkwTlpFeVN5c3FnZ0ZNTUNRVUh3c0gv?=
 =?utf-8?B?TERUVXFOc0Vsd2lqUTk2VTcyQk9jTTNvZjlpeFAzTEFnOUNXS1JwUkdIbHdr?=
 =?utf-8?Q?TLqaPZWpzv1nvxHfHIL4rPHC1m5BTU8W5/F16r5y2o=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 9cde2d55-2979-4fef-839d-08dbd700ce5e
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2023 15:24:27.0158
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1a4levzTqCbCxmtZgzBcnAg36Bck/V6/AxoU089cMqOnZkDGgWMMAyQFohZGA/NLAv8zbou6ypyizFk/uf6sPTv+ikwW8m3w1iT6ugxwb0w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB10772
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 27 Oct 2023 08:24:47 -0700 (PDT)


On 27.10.23 16:15, Jonathan Cameron wrote:
> On Mon, 23 Oct 2023 11:50:02 +0200
> Javier Carrasco <javier.carrasco@wolfvision.net> wrote:
> 
>> The current offset has the scale already applied to it. The ABI
>> documentation defines the offset parameter as "offset to be added
>> to <type>[Y]_raw prior to scaling by <type>[Y]_scale in order to
>> obtain value in the <type> units as specified in <type>[Y]_raw
>> documentation"
>>
>> The right value is obtained at 0 degrees Celsius by the formula provided
>> in the datasheet:
>>
>> T = Tsens_t0 + (Tadc_t - Tadc_t0) / Tadc_res
> 
> So base units for temperature are milli degrees celsius. 
> T = 1000 * (25 + (adc - 17508) / 60.1)
> 
> T =  1000/60.1 * (25 * 60.1 + adc - 17508)
> T = 10000/601 * (-16005.5 + adc)  
> So I think the maths is a little off..
>>
>> where:
>> T = 0 degrees Celsius
>> Tsens_t0 (reference temperature) = 25 degrees Celsius
>> Tadc_t0 (16-bit format for Tsens_t0) = 17508
>> Tadc_res = 60.1 LSB/degree Celsius
>>
>> The resulting offset is 16605.5, which has been truncated to 16005 to
> Interesting - the truncated value you have looks good to be but that's
> not matching with the resulting offset or the value below...
> 
You are right, there is a typo in the resulting offset and value below.

The right value is the truncated one I mentioned, which is the one
obtained with the formula.
In the case of milli degrees Celsius for T = 0 (milli or not does not
matter then):

0 = 1000 * (25 + (adc - 17508) / 60.1) =>
=> adc = -25*60.1 + 17508 = 16005.5

I will fix the value to use the one I actually obtained (16005)

Thank you.
>> provide an integer value with a precision loss smaller than the 1-LSB
>> measurement precision.
>>
>> Fix the offset to apply its value prior to scaling.
>>
>> Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net>
>> ---
>>  drivers/iio/magnetometer/tmag5273.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/magnetometer/tmag5273.c b/drivers/iio/magnetometer/tmag5273.c
>> index c5e5c4ad681e..d22ca39007b6 100644
>> --- a/drivers/iio/magnetometer/tmag5273.c
>> +++ b/drivers/iio/magnetometer/tmag5273.c
>> @@ -356,7 +356,7 @@ static int tmag5273_read_raw(struct iio_dev *indio_dev,
>>  	case IIO_CHAN_INFO_OFFSET:
>>  		switch (chan->type) {
>>  		case IIO_TEMP:
>> -			*val = -266314;
>> +			*val = -16605;
>>  			return IIO_VAL_INT;
>>  		default:
>>  			return -EINVAL;
>>
>> ---
>> base-commit: 05d3ef8bba77c1b5f98d941d8b2d4aeab8118ef1
>> change-id: 20231023-topic-tmag5273x1_temp_offset-17774cbce961
>>
>> Best regards,
>