Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp1247166rdh; Fri, 27 Oct 2023 08:36:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGfnlR7Lk+UCrlFyJ+bxZ+qFPw1NXHXBWrvo0uyenWuQv/AiI6mEGkEx0OhH15WVg3goETO X-Received: by 2002:a25:4192:0:b0:d9a:634e:5ad3 with SMTP id o140-20020a254192000000b00d9a634e5ad3mr2959387yba.13.1698420980314; Fri, 27 Oct 2023 08:36:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698420980; cv=none; d=google.com; s=arc-20160816; b=OLcdLRG+QdiE8+QSxLQPoyFyx5QOWPYOZGvV0Eg6gEakr9fojSZ7115ezdUoevdBts pj3XJSfOX9uL78JsR6NsoaOwZ/LURIFbibDKUk3G0a0mJXgpSif99UBrsrLGQn5Onxh7 jFA3RXfCC5cfHnrIrR2mPctJQFVfck77piKzZ1ylVITc5t+Khqif4K6mpAG/CBM6zguF pzt2yDhyP7jGODpWB63dCwQw5MEFP4syinIxQpP36FIbcPc7HKJFSFqkc+Fv9QjiosAh hgHmrS4GICSOT5bpXOgzoGa+SPEJl6ASkJDbujE1XMpyIrR++sKc+n7sdY4A9IUxGjwd HcGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature:dkim-signature; bh=Lg62SdcOcY4QK/aupcXrChVt53f/cqtiZSnK0uNAjx0=; fh=1dQjqMUTvvD26NH9CfxdSSnKd3i2/7wAguBb1AyGjPU=; b=wH6L9yM6EwKETLU7YBT6tyHFBdmTm3XQmUButt2/K9y8NylSyunEVcrnuAi10mk29I xIOwpVWfRiUP5h/rkrTpK+8AgnAqpJ90x4LKFQDYdvTQoIbaTFwcKzR0tAqo/b23+qOQ XnX510shT9xNH8D68PyS6ghynLiLhEOl0xQjuEABHebltD/QRIJMRAoW7IJQFWEA4Pdl nJzJEOnqf0RfIX1078iaB71kQJBDGfCzMGnw3+g48zN+BLTtyumQmzc0X9SDCdPdjyqz l0WRRHv8eC0RC22oL0vuKJ4z6oCsu/dlJno4lCUa74evUYOde8MIDNkxp8JPw2gN1+31 UpmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b="my/Svs30"; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id a207-20020a25cad8000000b00d7b295f411csi3502240ybg.607.2023.10.27.08.36.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Oct 2023 08:36:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b="my/Svs30"; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 721BB83C0E21; Fri, 27 Oct 2023 08:36:16 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345505AbjJ0PgJ (ORCPT + 99 others); Fri, 27 Oct 2023 11:36:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230451AbjJ0PgI (ORCPT ); Fri, 27 Oct 2023 11:36:08 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FDDDAC for ; Fri, 27 Oct 2023 08:36:06 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6AAA121C9D; Fri, 27 Oct 2023 15:36:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1698420964; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Lg62SdcOcY4QK/aupcXrChVt53f/cqtiZSnK0uNAjx0=; b=my/Svs30oiD8PntOhDz1CqWiza73pKFdb1lQmT2zlaZPusi+LP6ofd5deKQQfOk6JNFIi7 GW59VGvHl8EGoEn+7t7yNKQG1WQKlLHi8+GQTY2lKHkI7pIFJMnktAAkyx8371eyvhhwSQ O4Kt6X6vqmB4cXW5XH+K55ubT07BC8M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1698420964; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Lg62SdcOcY4QK/aupcXrChVt53f/cqtiZSnK0uNAjx0=; b=o0BD2IkOzVOt8O7HOqpqnTzgiSDVcaCHBSpbXaPN9JB/2mT3XFe4NneZ+4afkTjeK1Hbu7 Wv70czFcaVvvsGDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3EFC41358C; Fri, 27 Oct 2023 15:36:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id GpqoDuTYO2VFHwAAMHmgww (envelope-from ); Fri, 27 Oct 2023 15:36:04 +0000 Message-ID: Date: Fri, 27 Oct 2023 17:36:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [RFC PATCH v3 3/7] slub: Reflow ___slab_alloc() Content-Language: en-US To: chengming.zhou@linux.dev, cl@linux.com, penberg@kernel.org Cc: rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chengming Zhou References: <20231024093345.3676493-1-chengming.zhou@linux.dev> <20231024093345.3676493-4-chengming.zhou@linux.dev> From: Vlastimil Babka In-Reply-To: <20231024093345.3676493-4-chengming.zhou@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -5.55 X-Spamd-Result: default: False [-5.55 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_CC(0.00)[google.com,lge.com,linux-foundation.org,linux.dev,gmail.com,kvack.org,vger.kernel.org,bytedance.com]; BAYES_HAM(-2.95)[99.78%]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-3.00)[-1.000]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_SEVEN(0.00)[11]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; SUSPICIOUS_RECIPS(1.50)[] X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 27 Oct 2023 08:36:16 -0700 (PDT) On 10/24/23 11:33, chengming.zhou@linux.dev wrote: > From: Chengming Zhou > > The get_partial() interface used in ___slab_alloc() may return a single > object in the "kmem_cache_debug(s)" case, in which we will just return > the "freelist" object. > > Move this handling up to prepare for later changes. > > And the "pfmemalloc_match()" part is not needed for node partial slab, > since we already check this in the get_partial_node(). Good catch. > Signed-off-by: Chengming Zhou Reviewed-by: Vlastimil Babka Thanks!