Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Fri, 27 Oct 2023 16:45:25 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     "Stoll, Eberhard" <eberhard.stoll@kontron.de>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Eberhard Stoll <estl@gmx.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "Schrempf, Frieder" <frieder.schrempf@kontron.de>,
        Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Krishna Yarlagadda <kyarlagadda@nvidia.com>,
        Leonard =?iso-8859-1?Q?G=F6hrs?= <l.goehrs@pengutronix.de>,
        Yang Yingliang <yangyingliang@huawei.com>
Subject: Re: AW: [PATCH 1/4] spi: Add parameter for clock to rx delay
Message-ID: <ZTvbFc+kFMotVUkh@finisterre.sirena.org.uk>
References: <20231026152316.2729575-1-estl@gmx.net>
 <20231026152316.2729575-2-estl@gmx.net>
 <20231027005643.4b95f17e@xps-13>
 <DB9PR10MB82468A8BD333B12D3FCB3C43F1DCA@DB9PR10MB8246.EURPRD10.PROD.OUTLOOK.COM>
 <ZTujIs2O+GYKIPlU@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="t+iyWvYvU8cBITVd"
Content-Disposition: inline
In-Reply-To: <ZTujIs2O+GYKIPlU@smile.fi.intel.com>
Precedence: bulk


--t+iyWvYvU8cBITVd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Oct 27, 2023 at 02:46:42PM +0300, Andy Shevchenko wrote:

> So, to me sounds like device tree source issue. I.e. you need to provide
> different DT(b)s depending on the platform (and how it should be).
> The cleanest solution (as I see not the first time people I trying quirks like
> this to be part of the subsystems / drivers) is to make DT core (OF) to have
> conditionals or boot-time modifications allowed.

> This, what you are doing, does not scale and smells like an ugly hack.

No, this seems like an entirely reasonable thing to have - it's just a
property of the device, we don't need to add a DT property for it, and
the maximum speed that the device can run at is going to vary depending
on the ability of the controller to control the sampling point.

As people have been saying there's a particularly clear case for this
with SPI flash which is probed at runtime and is readily substituted at
the hardware level.

--t+iyWvYvU8cBITVd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmU72w4ACgkQJNaLcl1U
h9AzXAf/U69EcDG6BKh7GvxVDQ45r9zmTFIm3xM7WXD0qH+qxx0fMewR3y/JF0LA
qMH/a2wPo8djtZBJOz5RM80PaIf4/2K9uj3D1m5iuWKuHIicML+KE6FCMmeSvXBo
TFd2RgKSOFkLoZXmcfJbTMN1oMw0DL/j8ZENCnexMxSF7hrCBFxlpRj3bcKyBp9n
wUhXhfew3/aZNffqWAj2e9HaixbJEqyTV/YYAldTFblGgLYZOdpHsV6br86mXdRv
H83PyiLZzWj/w/1If3GLEROsnzISxyoSuf+U28gGNEJlHrY4bANXEcFJUpnlDj8y
Y6ZrCknBoHrHpxc8xsL7ABl8Vk45Mw==
=atJr
-----END PGP SIGNATURE-----

--t+iyWvYvU8cBITVd--