Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <1c88d721-75ea-4c3b-9e50-706c4ec87899@amd.com>
Date:   Fri, 27 Oct 2023 11:53:52 -0400
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/amdgpu: Fixes uninitialized variable usage in
 amdgpu_dm_setup_replay
Content-Language: en-US
From:   Hamza Mahfooz <hamza.mahfooz@amd.com>
To:     Yuran Pereira <yuran.pereira@hotmail.com>, airlied@gmail.com
Cc:     sunpeng.li@amd.com, linux-kernel-mentees@lists.linuxfoundation.org,
        Xinhui.Pan@amd.com, Rodrigo.Siqueira@amd.com,
        linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, alexander.deucher@amd.com,
        Bhawanpreet.Lakha@amd.com, christian.koenig@amd.com
References: <DB3PR10MB683590457246A6625BAA6102E8DDA@DB3PR10MB6835.EURPRD10.PROD.OUTLOOK.COM>
 <dc2242cd-6522-4073-b376-edc2a9abc3d9@amd.com>
In-Reply-To: <dc2242cd-6522-4073-b376-edc2a9abc3d9@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TU91UEt5TWpucHB3YWpiMmorUWtTLy9jeVZZdFpXdlBHT3U5d2J5akdzSEd5?=
 =?utf-8?B?dDZZcDMrUTFDTkNFNXZ2bFFjeVgxL1Vmcmc2VTB2Ujd4aTlkVFVEbkNkTGkr?=
 =?utf-8?B?Sk1mUm93YW9pYWViTDFZdjhCaTkzVXZRTy8zYTlaUisyNW9xMG9teHBBeVRB?=
 =?utf-8?B?bUdHdTdZTmtqY0xHa3JRUFFiRU9oQmNIR05qcTIzZ1hMWkdlSVovNkJkMFd0?=
 =?utf-8?B?VGxlbXJBZUNXM002amE4Q3Y1Qm0rS2tpK21OVC9vSGFxbVF3Mm5MZVl1NHdh?=
 =?utf-8?B?NklVOWVNSmF1WHhrNkc5bVRiajB6VVFBTjVzWmp6czZFYVlDVjdjL1dtLzJ4?=
 =?utf-8?B?ZGh3WVRMSllIVlJuNTgwTlNuanY2dndFUDVDNGNreHdEaFdkczZ3VmNmUDF4?=
 =?utf-8?B?c1NYaWdyUmdZenBZM2RaRUpJK3Q5aDd6UE5temswZkNROFJxV3hSaFZ2MWRR?=
 =?utf-8?B?eWwzS2FpNkUvWGVGQVIyMk5FdjVOZmtudlJtNzJyOC9XWjVVengzSzdwRWV1?=
 =?utf-8?B?S2ZONVRldE9nY1N6SzdQSy9TbndnUGY4RHdCRGt3d0orUDMyRXFhMGhNZVFs?=
 =?utf-8?B?VlJkd1A2Nk1ySVZMYzcvK0JtY1NWWFE2UUw1Y1g3KzZhTktKVmFyS3Vya3E1?=
 =?utf-8?B?alN6bW54RUFJeWswalBOaGREZ3dMdWRWMVlONlNJRnQ2eUgrMXhJdjZsVWZP?=
 =?utf-8?B?cnBGWVBzd2JHOWVnL2JGclFrVFJIcFd3V3ZsOFdsMVVnYlFId1duZEZKQkpC?=
 =?utf-8?B?THoyWFZEOG1HeExrR1RKd3RUQytIMjJMb2sxZTZmb0p4aTFpeXdudi8zcjBT?=
 =?utf-8?B?ZStuQ1hRVWZkWTdvdFdqQWNvK3dnc0VyazJydXdXc1lLdlpIbndwdzRaTWp6?=
 =?utf-8?B?V3hKdzI5dStUbDBjVGQzQ2hBRHFiTCsyYm5YWDg0S1BWTFFFRmo5VCswTnh5?=
 =?utf-8?B?WkZEcmNtYitjaWlSR1ozRDBDNitycDEzN2tQeHpkek1PL2lYcmdqSGp1OUdN?=
 =?utf-8?B?bkJyMTRyMTFGcHdNL3ZkdGpWU1JIclduck9RQUVlcWl0WkY3b3U4ZUg1bGVT?=
 =?utf-8?B?ZWora1hUNVJYdHdDb1JBR2V0WER0d2pWb3ZQRWlPdkduSC90WE5VKzA2bEVG?=
 =?utf-8?B?ZGNvY0llKzg3T1JQTXNCdkh5RFBqZUV3UFk5Sm9wT2F2VTdMUTB2WC9vSWhM?=
 =?utf-8?B?bG9LSk0wazlMdFdETEN6Ums1aW56R2s1UWlBK2JpUTRHL0FWaE9kRnZMa0c2?=
 =?utf-8?B?QmVod3BNL3ZJL210V2RmQWxLU2RaR0lwVElZVExmZHpxRVkreDZNenRxTDdF?=
 =?utf-8?B?MjhhNXEvUWVjUmJ5eC9PTDA4czdxRFM1d1ZMSEhFU3RjNjlwQWlFU215dVZO?=
 =?utf-8?B?bkpSaStFT2ZsVjhNbEsvbWNnVmR4NDJMU3RiaE9xckh2WGZ0b3pHZ3lVUEtI?=
 =?utf-8?B?MjJrQ29hbFppKzRpNC9CWUtSL1NUNWc4QVYxVUJSeFVyKzF0VDF1Q3Z2d25G?=
 =?utf-8?B?ZGFoSG90RWpyUURrQ1RmaXhsek1sMFR4Yit1RkxucU5jdEZGaG5ZMXZuUTBn?=
 =?utf-8?B?em5YMnl2S2ZzSTdRM2UvaEJodWxveGxLTEQxMTI1QlRhZ3cwOFR6NlJ2ZkQr?=
 =?utf-8?B?RGQzL0s0Znc2R0gwWlI0U1d3RGU2SEtySEY3RUFHMThzMjJNZmZ6WjVKMGpO?=
 =?utf-8?B?R08xY3g2eUliYWhJVVdqTFBaK21kdU9YalJxb1l1QitSQnlNQ2xwUkhOdk5E?=
 =?utf-8?B?NndFQWNwL3VQb2o1S3ZSeFVVenllMStuSjdiK2E1UWI0dS84cGZydWdnU3ph?=
 =?utf-8?B?YU12ckg0dzdaemswY2gzMjBFU0FnUHlxREp2a0h1YmhKN2ptT1Z1SjF2VWox?=
 =?utf-8?B?K1hzei83NGdNUEdiZDAvak9XUjhyZXg0SGZ6SUhHVzJ0RDBPeUhnaklhd2ZL?=
 =?utf-8?B?OVZGMHZadmFNcHZ5VktqaVhYMUxmd1ZDeThPRTNDdjM1UFQ3azRDVEFEcjNr?=
 =?utf-8?B?TGExYi9GbEpWZWpQUE1OTDQ5anJZOGIxUlZ2L29QM2pDYmovUkVuSFArRmIz?=
 =?utf-8?B?cWZpY3BEMEcrSGF0dW1GK2FhMzF5YkZ5ck5VUUdJZkJIOTJKQmpsUkhSVS84?=
 =?utf-8?Q?SB5mqJ9Zp2bjys5SJCATnHRQJ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2b6797af-c04e-4c09-6af5-08dbd704ebc0
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2023 15:53:53.9109
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hfQ76IlKzQN9b4SJXPlx+V2gR9lzmn8dT6+S+EehqrMXmAkO4sPaHUBykzpDDNgnKqdcU33Sc+/BczaY35WdEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7528
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 27 Oct 2023 08:54:11 -0700 (PDT)

Also, please write the tagline in present tense.
On 10/27/23 11:53, Hamza Mahfooz wrote:
> On 10/26/23 17:25, Yuran Pereira wrote:
>> Since `pr_config` is not initialized after its declaration, the
>> following operations with `replay_enable_option` may be performed
>> when `replay_enable_option` is holding junk values which could
>> possibly lead to undefined behaviour
>>
>> ```
>>      ...
>>      pr_config.replay_enable_option |= pr_enable_option_static_screen;
>>      ...
>>
>>      if (!pr_config.replay_timing_sync_supported)
>>          pr_config.replay_enable_option &= ~pr_enable_option_general_ui;
>>      ...
>> ```
>>
>> This patch initializes `pr_config` after its declaration to ensure that
>> it doesn't contain junk data, and prevent any undefined behaviour
>>
>> Addresses-Coverity-ID: 1544428 ("Uninitialized scalar variable")
>> Fixes: dede1fea4460 ("drm/amd/display: Add Freesync Panel DM code")
>> Signed-off-by: Yuran Pereira <yuran.pereira@hotmail.com>
>> ---
>>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c 
>> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c
>> index 32d3086c4cb7..40526507f50b 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c
>> @@ -23,6 +23,7 @@
>>    *
>>    */
>> +#include <linux/string.h>
>>   #include "amdgpu_dm_replay.h"
>>   #include "dc.h"
>>   #include "dm_helpers.h"
>> @@ -74,6 +75,8 @@ bool amdgpu_dm_setup_replay(struct dc_link *link, 
>> struct amdgpu_dm_connector *ac
>>       struct replay_config pr_config;
> 
> I would prefer setting pr_config = {0};
> 
>>       union replay_debug_flags *debug_flags = NULL;
>> +    memset(&pr_config, 0, sizeof(pr_config));
>> +
>>       // For eDP, if Replay is supported, return true to skip checks
>>       if (link->replay_settings.config.replay_supported)
>>           return true;
-- 
Hamza