Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <c0ea139c-9861-4ea1-b547-6e3c380301b3@amd.com>
Date:   Fri, 27 Oct 2023 10:54:47 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 09/13] ASoC: amd: acp: add machine driver support for pdm
 use case
Content-Language: en-US
To:     Krzysztof Kozlowski <krzk@kernel.org>,
        Syed Saba Kareem <Syed.SabaKareem@amd.com>,
        broonie@kernel.org, alsa-devel@alsa-project.org
Cc:     Vijendar.Mukunda@amd.com, Basavaraj.Hiregoudar@amd.com,
        Sunil-kumar.Dommati@amd.com, venkataprasad.potturu@amd.com,
        arungopal.kondaveeti@amd.com, mastan.katragadda@amd.com,
        juan.martinez@amd.com, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Marian Postevca <posteuca@mutex.one>,
        Alper Nebi Yasak <alpernebiyasak@gmail.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        Gaosheng Cui <cuigaosheng1@huawei.com>,
        Jarkko Nikula <jarkko.nikula@bitmer.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20231021145110.478744-1-Syed.SabaKareem@amd.com>
 <20231021145110.478744-9-Syed.SabaKareem@amd.com>
 <4d5a4c67-2f4b-4111-b98b-ef575543fa6e@kernel.org>
 <3ec97548-1f91-49d0-adfb-4f8051ca9a97@amd.com>
 <f8f8017c-4e76-4d70-918f-d7cb45186184@kernel.org>
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <f8f8017c-4e76-4d70-918f-d7cb45186184@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NlBra3NCd0NOdGRPRFNJSEZxTm1iMTZ4T1V5aGhzYWsvbjcyaTNtd0hNUjhJ?=
 =?utf-8?B?ckZaR3l2U21ZSGhJMTdoQmdMajdYMTd0bGVpdUpjTVRGZVV4NUdTM21FRUsz?=
 =?utf-8?B?cFMveThNb3VmaDF6UVNYK3EwZFJHS1hJdkpxSzE2SzRWbG12cFRMT05hUmpR?=
 =?utf-8?B?Tkk3TE45V0hGeWlBS054Mm5TSGNEVVExY1RjYWtnSVIyTjJYWWNyU01XWEs1?=
 =?utf-8?B?akpEUjRSRThTYWY0Tlp3WnRFbWVsT1FBbjZsN0orazV2Q0YvVjA1dHVJZzNE?=
 =?utf-8?B?TE85Mk8vZXJPYjB6UnhRQlk2Wk5HVlorNGR2SzNXYnI2NlNyMGhKN0s3VHJx?=
 =?utf-8?B?WVNTemF5RVNBd0Q4WmdTaFR4Ly9aM2s1enpsY3FHWkNUUkw2bDd6eGpuaWp6?=
 =?utf-8?B?TTNxMjVGS2dWSmtmd3lBekdFZlE5bm1SR2daZG5TRUtLaUJUL2dCVDlLd0F3?=
 =?utf-8?B?T2tvRWRWaVRET0xhQVUvbFJnUXhuOFI5WVNtMW9xVitwbFRhSzRxd01qMVRM?=
 =?utf-8?B?S1kycDdZTkI1TUZ2QjhmckEwV1hFR3dsL0N6UURwSHdGbUJ3eDlTSjF4UjZ3?=
 =?utf-8?B?YXZHRmc4ZEFEWFNYdmhrTzVvOG9BOUJLQjJVWkZNZjJ3enZxZEZYSVd4eml1?=
 =?utf-8?B?TklreWpIdE9TZkE4SGdKeDFaZFZDNDNiRzlVT0swdUVwSVhmKzFlVlFORnlX?=
 =?utf-8?B?eE04N2wwK2ZpNmNIcFNtdFpacDlRRko0QWo5ZHhyNFFJOFlmbUd1OXM2R0Yw?=
 =?utf-8?B?Mm1hWUJIVEJNakhRRkdJeWZFVnZqQks0S1pBZ281b3RvMUxNUHZEKytoOGVz?=
 =?utf-8?B?c3FHMjFUdUZvaGNYUlRQY3Fac0JNVFBLdjdrajl0bUp5WkFLSkNZWXJPQms0?=
 =?utf-8?B?ZUxOV2o1UktjaFk4K2xQRkZVbm5tdU4yNThVRUxKMk5qN1FiYkVISThRS3Zz?=
 =?utf-8?B?ZmJpenM4bGQ0NXBySXN2UlNxY2s1anlEeG1pZVdsendYRmxXTTg2LzdEMDQy?=
 =?utf-8?B?UnZxOCtQM00zNWZhMHkvQ1hLbm9BS1RVTVVkWWc4SDMyeTV0V1NINVc2Vjh4?=
 =?utf-8?B?a2d1dEkwbHlVZ0VqcFRScTYzcHRVRGxqTUFVZFF6SE9hUWFJS2xJUFgwTXlE?=
 =?utf-8?B?eUg3dVUrcE9ncVF6cERjWXNjc3RQOC9zQW1HdUg4ZXFWbXY2T3lLTVV5NDdS?=
 =?utf-8?B?QXNNc2NYSmJpeUJ6ajk2ZVJJM3M5bkoweCtIRTU2NEFiYmErUkRwSXJaZ0x1?=
 =?utf-8?B?SGsvWW1YT09lNG8xVXBLb3FYQVZWUTUwVDNQaFFSZDdnOFQ0dVc3M3RuVjN5?=
 =?utf-8?B?SW5iSGdHSDdienV4VkNiUmsyYVZTUGRGOUsxMG1ON0tIcXdYNnN4SXNhMWpN?=
 =?utf-8?B?c1F2N01qdTJZVHAwWFkxMjkwVnRpVFU2VjNMNXRqVjdwcUVoTmduMjB3aXpU?=
 =?utf-8?B?U09QZEZmRGpJNGpRNDl5eUZKek5ocmx2enEvWGZ6NURBTlBDTHdid1VJSHU4?=
 =?utf-8?B?NzBZbVFPdXNGK1MxNy9wWEY1Rnd5dkpTcEVBc3VNdHB3ZlhIZmFFaU1lOFJK?=
 =?utf-8?B?RFAyY0lQNHNhZCtlR2UrMEkrbTEvNmlmWmh1cG9pZ3laT2FydzRtejNUUkEx?=
 =?utf-8?B?azdHUG5WS1ZiOWJvNTNIV3Z2T21PYUh5ZzRKWURBUVhoTDhTaFkvVGZUdTFT?=
 =?utf-8?B?VTU2WDFvWGpsNk1xUm5jOUtWY1dROXdFNFB5ellDckpBRlpNNE5IOVdEQ2dt?=
 =?utf-8?B?TVZHNVZjMS9HSUlvUTdUTGsyTDdpWHZWa3dNL1JJcWh2clB5MzhNaWdtQnBY?=
 =?utf-8?B?bVFuVXYzVSttSmRxQlFIRk1pejh3aG5nazRsSCt6WCtBU0dNUnhzTFM0SzEw?=
 =?utf-8?B?N3Fqc2l2MDZON3dZQzQ3cXhRU0sxNElEbVlBOVBqdXhPZllFcGxzRmRJNXY5?=
 =?utf-8?B?dnV5M0dHank4aXNKUzVrZUdGYzhlVy9wUFNFSGVvMVNUUjMrcDlNemNXbnh3?=
 =?utf-8?B?UzQ3aUpqMDdFQWN6WmZwanpIVlFianVJRHBuL0VSRFFoc1N4YTM0QW12SGtL?=
 =?utf-8?B?MU84c1g4R3VHN1lFSkNDSGtKNC9NRCtVd3Zqek5oTldwc3h3Q2h1dXV6TjJY?=
 =?utf-8?Q?/xTNjTs3HnxfyuXdxUgGa3OB9?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fe905bf6-b083-456a-0fa0-08dbd7050dab
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2023 15:54:50.8682
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: g/SuMr9PzGaetFxrY/xohODp+xpZZGZOW4nTbGddTICDSrszouu/sfXvfcpg2oz6I6fRafLXFZE4hCuwL+utwg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5208
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 27 Oct 2023 08:55:06 -0700 (PDT)

On 10/27/2023 10:51, Krzysztof Kozlowski wrote:
> On 27/10/2023 17:28, Mario Limonciello wrote:
>> On 10/27/2023 03:49, Krzysztof Kozlowski wrote:
>>> On 21/10/2023 16:50, Syed Saba Kareem wrote:
>>>> add pdm use case machine driver support
>>>>
>>>> Signed-off-by: Syed Saba Kareem <Syed.SabaKareem@amd.com>
>>>> ---
>>>
>>>
>>>>    	dmi_id = dmi_first_match(acp_quirk_table);
>>>>    	if (dmi_id && dmi_id->driver_data)
>>>> @@ -214,6 +221,10 @@ static const struct platform_device_id board_ids[] = {
>>>>    		.name = "rmb-rt5682s-rt1019",
>>>>    		.driver_data = (kernel_ulong_t)&rt5682s_rt1019_rmb_data,
>>>>    	},
>>>> +	{
>>>> +		.name = "acp-pdm-mach",
>>>> +		.driver_data = (kernel_ulong_t)&acp_dmic_data,
>>>> +	},
>>>>    	{ }
>>>>    };
>>>>    static struct platform_driver acp_asoc_audio = {
>>>> @@ -235,4 +246,5 @@ MODULE_ALIAS("platform:acp3xalc5682s1019");
>>>>    MODULE_ALIAS("platform:acp3x-es83xx");
>>>>    MODULE_ALIAS("platform:rmb-nau8825-max");
>>>>    MODULE_ALIAS("platform:rmb-rt5682s-rt1019");
>>>> +MODULE_ALIAS("platform:acp-pdm-mach");
>>>
>>> Please stop growing the aliases. Module alias is not a substitute for
>>> missing MODULE_DEVICE_TABLE.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>> I thought the way that this works is that top level ACP driver (IE
>> acp-pci.c) will have MODULE_DEVICE_TABLE.  This is how that module gets
>> loaded.
>>
>> Then it creates platform devices based on the detected needs for the
>> situation and the creation of those platform devices triggers a uevent
>> which due to MODULE_ALIAS will get appropriate other platform drivers
>> like this one loaded.
> 
> And why you cannot use MODULE_DEVICE_TABLE here? IOW, why do you need to
> manually duplicate entire table and re-invent MODULE_DEVICE_TABLE with
> MODULE_ALIAS?

What would actually go into MODULE_DEVICE_TABLE?

The platform devices created are contingent upon what was found during 
the top level ACP driver probe.  You don't want all the "child" platform 
drivers to load unless they're needed.