Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp1269537rdh; Fri, 27 Oct 2023 09:09:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEOHqcIsi2BfTfiMo9T1TozTV75ueXi5KMfV9S9o7Z018zi/Nib6XApr577RYb80G3oZgvN X-Received: by 2002:a05:6871:a4c2:b0:1c3:91b9:e1e7 with SMTP id wb2-20020a056871a4c200b001c391b9e1e7mr3927849oab.21.1698422979577; Fri, 27 Oct 2023 09:09:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698422979; cv=none; d=google.com; s=arc-20160816; b=vJous8kDUVeHhu6o2r0eWoTieuFCxLIRe+cCgzVCDQRAePxly5ShVxPcW3qGxolku/ DVJCHwV2Gt69ESKOaqQhEJeY3I+W5svFkGyG51iIprfEuD8WlF3xnMrFq484yAL5TMB6 0jVtiXalGeHGdimOWtvhOTQlR8gdlfYB2mgNo101bJUbXfhys6ETyoAOAYaAKsNoIiJS xhWv6PXY0bdfVTWWL1sdGlC8bvUsm0L5du7OMQB3P+4E+Fb0ei2WMQ31M0jYuYbEM+cJ fgQOUnd0eLQh6VNoqzq8M1DcqFxucGv5dm5vwQ0EHUS6rvkqY1/BSTE0b6I1FMvuiO1a 0TXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=uxRnfCpuxPVJ+kDeYXLQks4Hl4wHJXZuyzgip/4KY1M=; fh=XYsu224p0hsYJ5vrDRPS08kxb8XEofIi8g+3XjXaNfY=; b=VzENRm+8R5KDkaiHSres7o7Cr6D07tc+1IFKWamCe/xN1OaSNFlH4s9lxIWqDjFOOI Dm8u8hPKTbb3qKxnpZj1pQhD/P4AXrWVOCfyz/pqSC6PV3TaVJcJBoaUBFocy8ZVT8+O uUZGtOEbcSsiGVujNwNPS8ZCFA9ZJXEIzps8ZYg1aTRZyVyq+vo2/Vheleo7I0Exa4JO TtqpH+21REDZp+8o2ysr94JV0/Sod7DOwnzxJ8kBjS9WZ7/idFLnqXGMriAXVHwGmVN8 qjngTHMRdOGI/PYUqHQgUjp3FgWbwQI7e1NlSSjfNKH7DOwg6D1sTwmDZCVZgXqlq8wQ PtpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=T44TYV8p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id e5-20020a056102224500b0044ed5f26c72si294865vsb.826.2023.10.27.09.09.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Oct 2023 09:09:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=T44TYV8p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 4EF84822CB0D; Fri, 27 Oct 2023 09:09:36 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345406AbjJ0QJ1 (ORCPT + 99 others); Fri, 27 Oct 2023 12:09:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230440AbjJ0QJZ (ORCPT ); Fri, 27 Oct 2023 12:09:25 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77709E3; Fri, 27 Oct 2023 09:09:23 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7833EC433C9; Fri, 27 Oct 2023 16:07:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698422963; bh=32DaPpQ2+GGDuCnPPq4gjkvUJNBaDefp5jSQJmVDdM8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T44TYV8pgAjl04XUPa/dTxwEtXG3ZzogUt4Q7uHtIFH9WU+2J8gyA77H3BpXD3p1g 526/A0xz0Hbc3fi7o6rjJgn8Vqxpgjo0X5ZxDlQEzSC8gLFC7asIAdSRPOKlByJTzf 0vSOgdyZTtCWk6Ts6hAWEPVqSpITEm4Vy4FLBjAwv0uL+R1IGiRBZ+v+CY8710mu/B pjXe8FvvccGKsjfmsdFJMbjrrgMU4UYO11ZRVMVJNcIph7+hP4+jmha20u6cLm/gzL AhQ5neluUalg0xAZAKzcOXKFpGvgecRHP/YqslBuxz0QRcxqPyyCoK/bZ//kcvL/Wd 3FOPp8QQRmWSA== Date: Fri, 27 Oct 2023 17:07:00 +0100 From: Mark Brown To: Frieder Schrempf Cc: kernel test robot , Eberhard Stoll , Han Xu , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, oe-kbuild-all@lists.linux.dev, Eberhard Stoll , Amit Kumar Mahapatra , Amit Kumar Mahapatra via Alsa-devel , Michal Simek , Rob Herring , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Yang Yingliang Subject: Re: [PATCH 4/4] spi: spi-fsl-qspi: Add support for rx data sample point adjustment Message-ID: References: <20231026152316.2729575-5-estl@gmx.net> <202310270332.mcbckKCr-lkp@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="DPWNaVop7Q2nZF4X" Content-Disposition: inline In-Reply-To: X-Cookie: Save energy: Drive a smaller shell. X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 27 Oct 2023 09:09:36 -0700 (PDT) --DPWNaVop7Q2nZF4X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 27, 2023 at 08:51:49AM +0200, Frieder Schrempf wrote: > On 26.10.23 22:03, kernel test robot wrote: > > drivers/spi/spi-fsl-qspi.c: In function 'fsl_qspi_select_mem': > >>> drivers/spi/spi-fsl-qspi.c:558:38: warning: suggest parentheses around comparison in operand of '|' [-Wparentheses] > > 558 | if (chip->rx_sample_delay_ns != spi->rx_sample_delay_ns | > > | ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ > IIRC, when I prepared the patches for sending "checkpatch.pl --strict" > suggested to remove the parentheses here. Seems a bit inconsistent... Ignore chekpatch, and it does look like as well as parentheses you should have used || not | here. --DPWNaVop7Q2nZF4X Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmU74CMACgkQJNaLcl1U h9BnVgf9GY8BWySvtZ5d2AGwW76SozOSOKRpaczcNAXQI15bsOPsCiF9Yi2K6sej hrx1DGKrtfZMiEINFgU47bM1Jm7B9DcI7LO1QZD26xcdBw0xkupHoPmiGjdHk3nw Gb4tpZTci6NJAwbmCBvPRVrLEMjqQQKI0zYNC3O02s5dDbKnm9HMsuVCQ87UgUG7 uY2mkDZLEtceLojHnaS//JuUxGiGqRnBz2z3gwHg8RWUlzTV68ZH2Tb/fgQzc66B PHfbWMFtQ5esveWTsp5/sqhMgD+RfMtc7xtZmqMBz43AxpBpJGlHLL6mhcCPVotw kunJyE2e5jm7GKVCVt+w9nFATLDM+w== =pjbf -----END PGP SIGNATURE----- --DPWNaVop7Q2nZF4X--