Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp1284586rdh; Fri, 27 Oct 2023 09:32:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEU8FRwp9mP4IIMKHG637tknu5VaLiW0Nw7lG/PqQqXm9fEigKiQriSsj0C7U2o+oVY7EUR X-Received: by 2002:a25:9083:0:b0:d99:de67:c3dc with SMTP id t3-20020a259083000000b00d99de67c3dcmr3111687ybl.2.1698424371755; Fri, 27 Oct 2023 09:32:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698424371; cv=none; d=google.com; s=arc-20160816; b=WObpwz1d0BLn4tdC9sGyGKpQvnAURvNDfvcQHaRt6bTWPcg3GWRuCb8qrfu1U+/NMR gXOmQB10MR/avmydYuuclYxxRJJGQ7fF2nedMCn5xJQDV39wWRPdDyY3Utt0DakXXCuw mt9T3PSQdXRSR3deFna7AOKG9vyVjGo9ICat5LON9G9gGMP5gw5Ma9db8p9T65f00l6Y RlkKycL/2tunhtz01iVMBk/0X6jlelYC9KHjYDp4anBVrJbs00ISFB0g/17u1M7Vx7yO LIj9Wr7HrVTNeQSbAe2u4ABKhyN6zKpqSDI1+mxyFEkk1bnGeRJW3e8Rf6iystaF1I3z 7OIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=dPNqkc1ES6JJZGHAuCYPe5FQYFoBkHIw9IRmoH+jcIc=; fh=oydL89DcfV+xgn4HkZH2QO8MxI86TpL4OnLbJtAJaok=; b=bWIP7pfD7ULhQLwhIuEukPKnogt071kOkzFXFR95eS55a6yT6J6el4cakIKJMUm6tA 1LLJsvGFYb7HmtDQv2NBK8h/ki/bA30WTRLm3k9Pt1ZTnubAj0tKRfUG8PTzJ7t2L4in Z4Nnz3RM1eNmYgbYaArn98qBcW9dP+W7sJ1d+Vb+lNQibFEcalkWQhBpW00g9L/ivoQf CONJolS2oUJwSjmr0uRQWjJzagxWs8C+zH+Po06991xX+oifB86neiXYq/S38xyY7Ptf MD50hj/lEHcR34H+WEW2zaz3JhdR9AoXqI+nFU3MtRDHm1qUL3bRAhA/EFc1h1ITQ9AT s1Rg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=RudKEyFE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id h16-20020a25b190000000b00d9c6890b3c8si3716589ybj.220.2023.10.27.09.32.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Oct 2023 09:32:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=RudKEyFE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 588478060444; Fri, 27 Oct 2023 09:32:44 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231843AbjJ0Qca (ORCPT + 99 others); Fri, 27 Oct 2023 12:32:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231649AbjJ0Qc3 (ORCPT ); Fri, 27 Oct 2023 12:32:29 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33484128; Fri, 27 Oct 2023 09:32:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698424347; x=1729960347; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=5IcXRoptUEcVDpArktnOALVLCfO+5LN/wy4M44e5nIE=; b=RudKEyFE54qe2k4ieI/u7o3X/OrgZPuYdJyxP+7Ljhexz3GVHtFm7+uM tvYtPjucivomJfxeY4xeBxceXCBsk5HJR8+lkTLyJCc46VXch/pcZMBoC wBCn7Ht/hxk/OW/8l/ox38/pIlP0/f/Y6o5CzwsbLf6gyVZv1TFviDWJt JYfNt5jtCHIQ10YF9LYOTPBx+nAKBMoh7n+YK9sGu4E+4w8hsv1yCLdg0 x0Excs0nAtUhOfwPQtrLdNKiwID5rPjokpzxOks6V1/F66YD/zVuxVoni FNY2QOgdDhEummEHI6Oebcoj6PFAK9zbBBSDMxaIP9Ur1pu0D7sMx4Y2I g==; X-IronPort-AV: E=McAfee;i="6600,9927,10876"; a="368020368" X-IronPort-AV: E=Sophos;i="6.03,256,1694761200"; d="scan'208";a="368020368" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2023 09:30:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10876"; a="903316290" X-IronPort-AV: E=Sophos;i="6.03,256,1694761200"; d="scan'208";a="903316290" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2023 09:28:10 -0700 Received: from kekkonen.localdomain (localhost [127.0.0.1]) by kekkonen.fi.intel.com (Postfix) with SMTP id 3322E11F830; Fri, 27 Oct 2023 19:30:36 +0300 (EEST) Date: Fri, 27 Oct 2023 16:30:36 +0000 From: Sakari Ailus To: Sebastian Reichel Cc: Jacopo Mondi , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/4] GC0308 Camera Sensor Message-ID: References: <20231027011417.2174658-1-sre@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231027011417.2174658-1-sre@kernel.org> X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 27 Oct 2023 09:32:44 -0700 (PDT) Hi Sebastian, On Fri, Oct 27, 2023 at 03:12:00AM +0200, Sebastian Reichel wrote: > Hi, > > I did the following tests done by me on an i.MX6ULL based system [0]: > > * v4l2-compliance -u /dev/v4l-subdev1 > - v4l2-compliance 1.24.1, 32 bits, 32-bit time_t > (from Debian testing) > - Total for device /dev/v4l-subdev1: 44, Succeeded: 44 > * Using gstreamer + v4l2-ctl > - Tried 640x480, 320x240, 160x120 YUYV8_2X8 formats > - Tested effect of all exposed user controls > * checkpatch does not report any driver issues > * dt_binding_check does not report anything > > Note, that there is another patchset adding GC2145, which > adds the same vendor prefix. I just included it for completeness, > since it's needed to avoid checkpatch and dt_binding_check > warnings. Thanks for the update. There's a spelling error I noticed which I'll fix while applying but otherwise I'm looking forward to have Jacopo's comments on the patch. It seems good to me. -- Kind regards, Sakari Ailus