Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Gregory CLEMENT <gregory.clement@bootlin.com>
To:     Jiaxun Yang <jiaxun.yang@flygoat.com>, linux-mips@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, tsbogend@alpha.franken.de,
        vladimir.kondratiev@intel.com,
        Jiaxun Yang <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH 0/5] MIPS: Fix kernel in XKPHYS
In-Reply-To: <20231023191400.170052-1-jiaxun.yang@flygoat.com>
References: <20231023191400.170052-1-jiaxun.yang@flygoat.com>
Date:   Fri, 27 Oct 2023 18:35:38 +0200
Message-ID: <875y2s81lx.fsf@BL-laptop>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Hello Jiaxun,


> Hi all,
>
> This series fixes support for loading kernel to XKPHYS space.
> It is derived from "MIPS: use virtual addresses from xkphys for MIPS64" [1].
>
> Boot tested on boston and QEMU with loading address set to 0xa800000090000000.
> QEMU patch on the way.
>
> Gregory and Vladimir, do let me know if I missed anything.

Thanks for this series, I reviewed it and tested it on my platform, so
you can add for all the patches:

Reviewed-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Tested-by: Gregory CLEMENT <gregory.clement@bootlin.com>

However I add to fix the patch " MIPS: Handle mips_cps_core_entry within
lower 4G", I think you missed a case. I will comment on it.

Gregory


>
> Thanks
> - Jiaxun
>
> [1]: https://lore.kernel.org/lkml/20231004161038.2818327-3-gregory.clement@bootlin.com/
>
> Jiaxun Yang (5):
>   MIPS: Export higher/highest relocation functions in uasm
>   MIPS: genex: Fix except_vec_vi for kernel in XKPHYS
>   MIPS: Fix set_uncached_handler for ebase in XKPHYS
>   MIPS: Handle mips_cps_core_entry within lower 4G
>   MIPS: Allow kernel base to be set from Kconfig for all platforms
>
>  arch/mips/Kconfig               | 18 +++++++++++++----
>  arch/mips/include/asm/mips-cm.h |  1 +
>  arch/mips/include/asm/uasm.h    |  2 ++
>  arch/mips/kernel/genex.S        | 19 +++++++++++++----
>  arch/mips/kernel/smp-cps.c      | 27 +++++++++++++++++++------
>  arch/mips/kernel/traps.c        | 36 +++++++++++++++++++++++----------
>  arch/mips/mm/uasm.c             |  6 ++++--
>  7 files changed, 82 insertions(+), 27 deletions(-)
>
> -- 
> 2.34.1
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com