Date: Wed, 21 Nov 2007 12:51:19 +0000
From: Pavel Machek <pavel@ucw.cz>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Arjan van de Ven <arjan@infradead.org>,
       Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
       mingo@elte.hu, tglx@tglx.de
Subject: Re: [patch] Printk kernel version in WARN_ON
Message-ID: <20071121125119.GC5474@ucw.cz>
References: <20071117101552.2a7f34cb@laptopd505.fenrus.org> <20071117102720.251107d7.akpm@linux-foundation.org> <20071117103947.5b2052f8@laptopd505.fenrus.org> <20071117104652.8240af62.akpm@linux-foundation.org> <20071117113501.5e3e0d43@laptopd505.fenrus.org> <20071117194240.GD8568@uranus.ravnborg.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20071117194240.GD8568@uranus.ravnborg.org>
User-Agent: Mutt/1.5.9i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1538
Lines: 36

On Sat 2007-11-17 20:42:40, Sam Ravnborg wrote:
> On Sat, Nov 17, 2007 at 11:35:01AM -0800, Arjan van de Ven wrote:
> > On Sat, 17 Nov 2007 10:46:52 -0800
> > Andrew Morton <akpm@linux-foundation.org> wrote:
> > 
> > > > by ... not too much at least, gcc ought to be quite good at merging
> > > > same-strings into one, so it's just one extra pointer argument
> > > > 
> > > 
> > > I think I knew that.  At 1000 callsites.
> > 
> > ok so how about putting the same into dump_stack() instead? (see below)
> > added bonus is that it's now present for all dumps that use
> > dump_stack(), not just WARN_ON()
> > (the format I copied from the exact line used by oopses)
> 
> This solved the "zillion files being rebuild" issue I mentioned.
> So from that angle it is better.
> 
> And I notice you use the namespace aware helpers to access the
> kernelrelease string - I assume this is better than direct use
> of UTS_RELEASE.

I'm not sure... namespace-aware kernel release seems like madness to
me. This stackdump is from 2.6.10, but the other stackdump is from
2.6.20 running at the same machine at the same time?! Why do namespace
helpers touch UTS_RELEASE.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/