Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <f7562b7e-0a1c-46ea-aa72-236ada533558@oracle.com>
Date:   Fri, 27 Oct 2023 22:48:45 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] i915/perf: Fix NULL deref bugs with drm_dbg() calls
To:     Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>,
        Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
        Matt Roper <matthew.d.roper@intel.com>,
        intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Cc:     dan.carpenter@linaro.org, kernel-janitors@vger.kernel.org,
        error27@gmail.com
References: <20231027140729.2505993-1-harshit.m.mogalapalli@oracle.com>
 <1e844f00-fc16-4788-8d90-ebe115eb9313@intel.com>
 <4d850f3c-c199-470f-b83e-00bd9fddbd7a@linux.intel.com>
Content-Language: en-US
From:   Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
In-Reply-To: <4d850f3c-c199-470f-b83e-00bd9fddbd7a@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a3V3M09sdXpJU3Z6blF6MmFoSFBGRitHL3gyMmxpMnB0Y1VrenloRys1SXps?=
 =?utf-8?B?aXZ6OVhhZmJzTDJXLzZrYVNsczhmdEErWlRmQkZPUzZ4bUhLeVF3M3VtY0Nq?=
 =?utf-8?B?U251UnlHdFVvVXc5bTZTU1VXWEY2VUlSNTZHMUYwU3o2RG9zTUVsRFhhcW8z?=
 =?utf-8?B?SmtpK3JzN3FSbUhiRnhKYlVQRHJBQzI1YkFNZEFhdDlxMzlsaHc2SHVQUkNZ?=
 =?utf-8?B?Z1hCVFhRWFJzUWl0eHdpcFRGQ2J0ZGRJS3pTcUlYS1dPb2xCMnNVcDBydnJq?=
 =?utf-8?B?V3JzVjNKZlJVbzdwTmpiWDhIcGJJM0l4ZU9oenVYTE9nYUVNRzh1ekRCNXRw?=
 =?utf-8?B?Y2c0QVMwZjlJTHNGK0tSckQwbEQ4ckIzTTNXN3BPLzhrY3FkVk5xWmZWUTY0?=
 =?utf-8?B?WXJJdnpNQlZjcXovS0lUT3JQaFdxY3ZHSjdhVVQ1cTEvR1RRSWtCcERWZDBv?=
 =?utf-8?B?a1g1QTV1aGNZdjRFeXlJZHRoZWROMWNkTFgvekxWZzFHNkxsSWU3ZGZzZ3B0?=
 =?utf-8?B?OFJGK3BvMDNVRGk1cXhvLzFWTWFJR1pvQzhxWkRtVmVtbmh3THZVMTNHbzlm?=
 =?utf-8?B?eENLanduS21SeGtjckl2SFBmbWxhVUZXT29TTFpwSXVPQWcxK3VjUG83L2RN?=
 =?utf-8?B?RjIxdnZsTk8xdHRiRWppMGpnU1BmUW9FWVo5K0JhQlc3aFk1UW11Uk1PTXBB?=
 =?utf-8?B?VURKVDg2Q05QLzUzRkEzMkdyRy9vTFhDUncrUFNTWk9sU0pmVkN3ZDV1bkFh?=
 =?utf-8?B?ckxSazhLbkp4NW5qWVBzNTA2N1prRmhheWJ6OEZrcXRwRERjWjhWdkhuTXMr?=
 =?utf-8?B?RUZUNU96NHliLzJaR3ZlcWRlZHBUYVcyR2V1U3V3Uk9uMVpVUVNHZjZFZVZQ?=
 =?utf-8?B?cjZnVlltVXV0WVFGa1VVN09ocWo0MksvNmRCZnhjbG5SWHlQWGkyeGdxQVZp?=
 =?utf-8?B?U3BzeUhoMjJyTTA5ZEw4MXdNNUVqWHZNVHNJQjZySGlWbU11YWhQSGh1eWl4?=
 =?utf-8?B?Mk9tK3JLbXNKMzlNcVBKQ0dNSVM0c1p6VGxRQ3M4aGdWM0YwR2hkUGpmYlVk?=
 =?utf-8?B?VmRlVUxaOHAwR0hDb2ExRTQxVnZLVHpQYWpsc0plMzhyWTBkb2I2bXIxa0J6?=
 =?utf-8?B?MitpZjJrS3FRS1RWU2g2djZnVXBvVDdIT28xZUJnUnFqUlM0VHplMWM4Zjhu?=
 =?utf-8?B?bFRBWFRsR0NaTHUxTUpZaGw1Skx4Zm41RFJRNWhweWpBUldycEJmeWsrRVNC?=
 =?utf-8?B?NEt4S3RaK0JUQ3FNN0ZPK2xxNTNoRkVqNkxRbHdHVndyTHRqYUZpOWpLb0VK?=
 =?utf-8?B?VUZRV2o1cDh3emtDeFdVcjFHdDBpOUhheDZ3K1k1cDFXZ2UvTUF3bHBuQjEv?=
 =?utf-8?B?MzZWUEtUYTRlOFA0d2NRdTEybmpZbFlIaklFTk5RQk9TcXVnU1BzR3FHYktF?=
 =?utf-8?B?WmNSWk9ld1A4MG9lbm1obVJ5aDROcExLald1Znc5VXpMWmo4WmQ2WjVKY01G?=
 =?utf-8?B?c053YTFVMnIxaVlpUHZLd2VhdTBkS0N1Mlh4MVpnT0ZnQ3VWRUJYODFqbXVD?=
 =?utf-8?B?QlJYRUlPdUN0V1BkY2RkS0JEMC8zMHhhVVA1YTVGOXRPeDdoK20zZEVkUTN2?=
 =?utf-8?B?bmJwQTRKam1pbzVIdnA5UmtUOVliZ2lFNE5sVzdpdWZaSmY2U2NiZVN6aERE?=
 =?utf-8?B?WEFkWlVYbHFKSEt6NUsxVS9QTWRLbWxOL0pNL3Ewd0dHenIwSTVCOXNqN2w2?=
 =?utf-8?B?eng0bGl1SCtKMGgrUVdrUTVabzk2aHU5ZFVLYmJTZytuUUFxU2tWRHp1L2hZ?=
 =?utf-8?B?OE01cTJsam9oSXFwQVp3MW52S3U0VzJ3NUFCUzZxMHdORS9iV3g3K3BXa2ph?=
 =?utf-8?B?M2Z4QXhsa2xlL1BnNUJRNUxyVlBDdCttcmhZSHFEMnkvOVlSMUFpMzREakNS?=
 =?utf-8?B?ZjJDZllYYjBYZGpDVlEwamZ6dDVmZVhVN1RtclIwQVpjcW1ickpHdWh5ZU56?=
 =?utf-8?B?dmdhUjVMZlRHenBHM0tzRDZXYXBsYU53MkxyalU2TkZDdnJNSXZYRWJxK2Z6?=
 =?utf-8?B?NGl6YWZkang3Z3l2WFlZc2pzS2FJRlViYmdGQUZhRmlxYXhsT0hKT3R0MXhF?=
 =?utf-8?B?TWZseWgxRTVab0p6MVNwYUxKSEt0RUxNSkRrZlc2WG5nVEFMSENES3VzTTNX?=
 =?utf-8?Q?YhaBLQNPimKqYfebtNjzYlg=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?bmc4SW0zR0Jqb001ZmhLOWRKZ2VmUmtlZnJKVXBuUXIzSVJiNzZ5M2ZuUlFY?=
 =?utf-8?B?ZmZLWUsxWElPQlRPSFhuRFU2N0NtcnV0aGNtaStycnZnY0FHcWRyNllRd2Rn?=
 =?utf-8?B?NytxZ0gyT3BkdDJjZkZOUW01aXEwUGhyOEdjYUtiZ21Qa3FLV3NKV0V3UXR3?=
 =?utf-8?B?TUxIbUFXcnZvNUZYMStkU2hvR1RjTlRtUmh1MVlBU1hCbjQwcWhXSFQ5aEJz?=
 =?utf-8?B?WFJFWHNZSU5QM1VLaDBxbzh5akVSOHBNTUJvdTdoakl0bWRnRzNnZ0E3NmQ5?=
 =?utf-8?B?eUZyVHh2TzIycGY3TExrVjExbklKblZTOUkramlRK3dSVDV3cHdTYkxEWFdS?=
 =?utf-8?B?Y254d0dTRy9EL3FnQUJRT25UYm9KclE5ZXhjbTZ4Wk9ydVdnY0o2Rml0STVx?=
 =?utf-8?B?dGpMZG9xOWNIRlRnWmdqRWFJdmlqVStZbGFNZjYyV0FjR2pESW9lQmtqQVU2?=
 =?utf-8?B?aG9DcU9iN2pUTFR5NWpmRUJHU0RMeWwycDdzYTVjRExac05MaEY3aUEvYXly?=
 =?utf-8?B?eHQvY29ZeUk3MzNEalhUNzZpUEZOT3o4cVJUd01hZWc5QXIzUWMybVFXcmc2?=
 =?utf-8?B?U0xMLytYcEx3NmVhNE1sdkZhVHJmWUhpSnRHMm1kZmcvczdiSTRSaGh2R0t3?=
 =?utf-8?B?ZGNLNnY5L05zVVNIVGUzcGh4Q2pPSU5CREZOdUNlbGNkQTJ2TTBkR3k0R2ZI?=
 =?utf-8?B?R2tEWUppYTRyQ2ZrKzhxOGhkZ3kxRE5aN3lrQzc1RWVkaFkyTWJuZlc4dUs0?=
 =?utf-8?B?b3dOV0Y2S1RHMFB2NElQU25tTnNRR3RhZzllNE02UTVCeWFQaHE5ZGdzNmhl?=
 =?utf-8?B?V2FrVXBxWFBMcXMxTGFpMTV1TmpidU1mNjlKd0Y4UDhrdzFtbVNKYW1NSjda?=
 =?utf-8?B?dDFRRzh1ZndRaUFzcmZ2YURDZHlPd3doQ3pFeGtpSUo4dmdvS1BSYkYzZ2l0?=
 =?utf-8?B?eHNwWHVLUFVsUWtTenRyaURjUzVpQ21HWVJKd20xOHkvQUxDdTUxTjlCT0or?=
 =?utf-8?B?NnFIbGpmeDZtc0VETU4xREUyekJySmFZQklWa1B1VENJWXlUbmcvUUxFaURO?=
 =?utf-8?B?a05uVGh1L1lkZTdoRXRhKzZKYmptZHNPa3h1U0NhQ29DSnc5b0l6S2tOWThH?=
 =?utf-8?B?UGtaRzlYSFFvN29XY3VmbkVhckg5S21QeEhVbm9SeEVLSmEveTI3aWVYSVlj?=
 =?utf-8?B?c05sOEQ4VTIxdTQvZ0xxU3hNcWpmTWw1STM4NWJLTmQxRENmTWpHb2VQSDdu?=
 =?utf-8?B?S2xLaWx4bmFtSGE5ZmRJcnB4aFd6eWtkcGllSXdxMW1uSzk4TWhwRmFUU1VN?=
 =?utf-8?Q?V8yjeY3d4Mh18=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df8bb5b0-fb21-4694-a96b-08dbd710ccdd
X-MS-Exchange-CrossTenant-AuthSource: PH8PR10MB6290.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2023 17:18:56.2509
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FSR3XDbQho3CJdXNJ8wLwgE7AiM/JGz4K1slqYW+NkyH7M8/67+HCGqyi68nvHumiyOJzOGcKtYhpd8DSVJSLiHbAn3EuN4PcYZBm+1uS+0UwRCvsle1pA5lybYAspnq
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB5769
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-27_16,2023-10-27_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 spamscore=0
 malwarescore=0 mlxscore=0 adultscore=0 mlxlogscore=999 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310240000
 definitions=main-2310270150
X-Proofpoint-GUID: vnIva8HU1HbtqSe934N7E7AMQ5--Eaxp
X-Proofpoint-ORIG-GUID: vnIva8HU1HbtqSe934N7E7AMQ5--Eaxp
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 27 Oct 2023 10:19:39 -0700 (PDT)

Hi Tvrtko,

On 27/10/23 8:17 pm, Tvrtko Ursulin wrote:
> 
> On 27/10/2023 15:11, Andrzej Hajda wrote:
>> On 27.10.2023 16:07, Harshit Mogalapalli wrote:
>>> When i915 perf interface is not available dereferencing it will lead to
>>> NULL dereferences.
>>>
>>> Fix this by using DRM_DEBUG() which the scenario before the commit in
>>> the Fixes tag.
>>>
>>> Fixes: 2fec539112e8 ("i915/perf: Replace DRM_DEBUG with driver 
>>> specific drm_dbg call")
>>> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
>>
>>
>> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
> 
> Please hold off merging.
> 
>>> ---
>>> This is found using smatch(static analysis tool), only compile tested.
>>> ---
>>>   drivers/gpu/drm/i915/i915_perf.c | 9 +++------
>>>   1 file changed, 3 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/i915_perf.c 
>>> b/drivers/gpu/drm/i915/i915_perf.c
>>> index 2f3ecd7d4804..bb48c96b7950 100644
>>> --- a/drivers/gpu/drm/i915/i915_perf.c
>>> +++ b/drivers/gpu/drm/i915/i915_perf.c
>>> @@ -4228,8 +4228,7 @@ int i915_perf_open_ioctl(struct drm_device 
>>> *dev, void *data,
>>>       int ret;
>>>       if (!perf->i915) {
>>> -        drm_dbg(&perf->i915->drm,
>>> -            "i915 perf interface not available for this system\n");
>>> +        DRM_DEBUG("i915 perf interface not available for this 
>>> system\n");
> 
> What's that struct drm_device *dev function argument a few lines up? :)
> 
> Although TBH all these these could just be removed since I doubt they 
> are adding any value and ENOTSUPP is pretty clear.
> 

Thanks for checking. I will remove the dbg() calls and send a V2.

Regards,
Harshit

> Regards,
> 
> Tvrtko
> 
>>>           return -ENOTSUPP;
>>>       }
>>> @@ -4608,8 +4607,7 @@ int i915_perf_add_config_ioctl(struct 
>>> drm_device *dev, void *data,
>>>       int err, id;
>>>       if (!perf->i915) {
>>> -        drm_dbg(&perf->i915->drm,
>>> -            "i915 perf interface not available for this system\n");
>>> +        DRM_DEBUG("i915 perf interface not available for this 
>>> system\n");
>>>           return -ENOTSUPP;
>>>       }
>>> @@ -4774,8 +4772,7 @@ int i915_perf_remove_config_ioctl(struct 
>>> drm_device *dev, void *data,
>>>       int ret;
>>>       if (!perf->i915) {
>>> -        drm_dbg(&perf->i915->drm,
>>> -            "i915 perf interface not available for this system\n");
>>> +        DRM_DEBUG("i915 perf interface not available for this 
>>> system\n");
>>>           return -ENOTSUPP;
>>>       }
>>